Giter Site home page Giter Site logo

Comments (5)

Crecket avatar Crecket commented on May 28, 2024

This also requires the ability to turn off the validation and use a custom one when multitenant (/common/ endpoint) application scenario is used

Looks like this isn't the case and it is causing v2.0 usage to break for me with my implementation.

It is throwing an invalid issuer error since https://sts.windows.net/9188040d-6c67-4c5b-b112-36a304b66dad/ does not match https://login.microsoftonline.com/9188040d-6c67-4c5b-b112-36a304b66dad/v2.0 which I assume is caused by the usage of the common endpoints? I don't see a way to disable this check aswell

from oauth2-azure.

hajekj avatar hajekj commented on May 28, 2024

I will have to check this and get back to you. So you are using regular AAD created app with v2.0 endpoints, right?

from oauth2-azure.

Crecket avatar Crecket commented on May 28, 2024

Yeah so I basically use the options described in the readme

$provider->pathAuthorize = "/oauth2/v2.0/authorize";
$provider->pathToken = "/oauth2/v2.0/token";
$provider->scope = ["openid"];

from oauth2-azure.

Crecket avatar Crecket commented on May 28, 2024

Ah I think I found it, there is an API call to 'https://login.windows.net/' . $tenant . '/.well-known/openid-configuration' to get the issuer. But if I check my endpoints in my azure portal it shows

https://login.microsoftonline.com/common/v2.0/.well-known/openid-configuration

So that might be the reason why?

EDIT: Yup just modified the files locally to use v2.0 and that has fixed the issue for me. So adding an option to modify the openid-configuration endpoint for example could fix this?

from oauth2-azure.

Crecket avatar Crecket commented on May 28, 2024

Almost forgot, I also modified the https://login.windows.net/common/discovery/keys url to use the v2.0 keys since Firebase JWT was giving me an error for a missing KID value.

from oauth2-azure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.