thenikso/github-plus-theme

A VSCode theme inspired by GitHub color scheme

GitHub Plus Theme

A full VSCode editor theme inspired by the GitHub color scheme.

Use GitHub issues to report problems/requests (it might take a while to get feedback)

Extras

• Material Icon Theme is the suggested icon theme
• Trailing Spaces can be seen in the screenshot for trailing whitespaces highlight

github-plus-theme's Issues

What's the font-family in screenshot?

Brackets and variables not visually different in template literal strings

I'm on the latest version available through the Visual Studio marketplace. Attached is a screenshot from this theme, and below it is Octocat in Atom. I don't expect them to be exactly the same or anything, and I like that strings are green, but the curly brackets and variable inside aren't differentiated.

I'd love to submit a PR but I've never made or even modified a VSCode theme. I'll try to learn. Also if anyone could give me some hints on how to specifically target the curly brackets maybe I can figure it out.

contrast issue on selected files and quick action dropdown

i cannot read the name of the selected file:

and also the quick action dropdown has this issue with the selected item:

Template Literal Interpolation Expressions Unreadable in Markdown Preview.

I love this theme, but template literals that have interpolation expressions are unreadable in Markdown previews.

If I create a markdown file with a code block:

```javascript
if (refs.has('input')) {
console.log(Input value is: ${refs.get('input').value}.)
}
```

And then open the file in Markdown preview mode, the part ${refs.get('input').value}, which is an interpolation expression, is unreadable:

preview of markdown cannot show the math symbols in $$.

preview of markdown cannot show the math symbols in $$.

could you please add the reference line height-light function,please?

Low contrast ratio - action buttons for selected file in source control panel

Looks good on hover:

But when you select the file it is difficult to see the action buttons:

With something like gnomes night light feature or f.lux active you can't see the icons at all.

Colour issue on string template variables in Javascript

When access an object's value using the dot notation, the dots are displayed on when the cursor is place on the dots, else it matches with the background colour.

Without cursor

With cursor

Syntax coloring issue after regex in TypeScript

The syntax coloring doesn't work correctly after regex expressions as shown in the image above.

Change CSS values color

Hey Nicola!
Thank you for the awesome theme!
Everything is nice in it, I switched to it, but I think CSS looks a bit monotonous:

In my opinion it would be much better if CSS values color was black.
What do you think about this?

Color of dots in .js files

Hi

Is it possible to change dots color? I mean that comma, for example, is white and 3 dots is read. But one dot is black (or some dark color, no matter). It's probably would be more readable if single dot will be like comma.

Thanks,
Andrei

UPDATE: Problem is that your theme in conflict with all Babel packages.

Add support for inputOption.activeBackground

VS Code will be introducing a new token color, inputOption.activeBackground, in the July release (1.37). This color is for showing when a button toggle is active (search, find, terminal find, etc.). It also re-uses focusBorder but in this theme the focus color is set to transparent, which means the new token color is also transparent. See below where you can't tell which item is "active", please consider adding support for this. You can test this by using the Insiders version, which already adds this.

Visual Studio?

Really like this theme, is there a equivalent for visual studio?

Publish theme to https://open-vsx.org/

Hello.

I like this theme and would like to use it in VSCodium, but there is no this theme on https://open-vsx.org/

Please, publish it to https://open-vsx.org/

Python syntax differences

The Python syntax highlight in this theme:

differs greatly from the syntax highlight on Github:

Am I doing something wrong or is Python not supported?

Terminal theme in the future?

I'm really digging this theme. Will there be a hyper or iterm2 theme? :)

Intellisense selected text matches background color making it impossible to see

After updating vscode to 1.57.0, the background color of the intellisense popup selected item matches the color of the highlighted text making it invisible.

If anyone else is having this problem, I temporarily fixed it by adding these lines to my settings.json file:

  "workbench.colorCustomizations": {
    "editorSuggestWidget.selectedBackground": "#B1DAFF",
    "editorSuggestWidget.selectedForeground": "#24292E"
  }

Tree view: Arrow navigation item is not highlighter

Hello.
Thank you for the delightful colour theme!
I have a little issue in the left-side tree view in the git tree navigation.
If I select a folder item by a mouse and then expand it or jump up/down by an arrow, I don't see any highlight on the item, only the GitLens helping icons help 😄 . But in the Project Explorer view there are no icons, and I see absolutely nothing

On the screenshot below you can see I clicked on the manifest folder, then expanded it and went down to the objects.xml file.

The environment:
OS: MacOS Big Sur 14.01
VSCode: Version: 1.60.0
Github Plus Theme version (last bullet from CHANGELOG): [1.4.0] - 2021-08-26

Enums are not properly styled in PHP

The enum keyword and the available cases (both new in PHP 8.1) are not correctly styled:

For reference: a class definition that is correctly styled:

Request - github-plus-theme-dark

I love your theme so much! I love the colors you chose! Do you have any plans to create a dark version of this theme following the same syntax highlighting etc?