theotterlord/deckmaster

A prototype deck editor for the Yu-Gi-Oh! TCG

Yu-Gi-Oh! DeckMaster

Yu-Gi-Oh! DeckMaster is a deck editor for the Yu-Gi-Oh! trading card game. It features a full deck editor and a combo editor for live probabilities.

Installation

You can install DeckMaster via one of our installers, or by building from source. Visit the documentation for instructions.

Support

If you encounter any issues when using DeckMaster, or simply have a suggestion on how to improve it, please open an issue in our issue tracker and I'll get back to you.

Alternatively, if you do not have a GitHub account, please use the Discord server.

Contributing

DeckMaster is completely open-source and accepts contributions from the community. If you wish to contribute to DeckMaster, please read our contributing guide.

License

DeckMaster is distributed under the MIT license.

Thanks For All The Fish! (Attribution)

• Card data is served from the YGOProDeck database API

deckmaster's Issues

Feature Request: Deck Sorter

Requested Feature

Someone has requested a feature where the deck can be sorted by card set. In addition to this, I believe deckmaster needs a complete sorting API and UI. This issue will act as a todo list of sorts.

• Sorting API
• Sorting UI
• Ability to sort by card set release date

Add Limited Status

Add some sort of visual to show that a card is limited, semi-limited, or banned.

TODO

• Fetch banlist data
• Merge into main card data
• Display visuals

XSS vulnerability

Hi Reuben, I find many data fields in DeckMaster are rendered as HTML (like the "combos" field in the screenshot). I believe this is an XSS vulnerability, enabling a malicious ycb file to execute scripts inside DeckMaster. Maybe consider using innerText / textContent to replace innerHTML somewhere in your code?

(I'm working on a project to investigate the security of Electron apps. I see this is a personal project and may not affect too many users, but anyway I'm obliged to report every vulnerability. Hopefully this doesn't bother you...)

[BUG] File association causes error when opening YDK files

When opening a ydk deck file via file association, the deck editor loads, however the deck is not loaded and an error is printed to the dev console.

Uncaught TypeError: Cannot read property 'cards' of undefined
    at Deck.addCard (deckeditor.js:402)
    at Deck.addCards (deckeditor.js:396)
    at api.js:173
    at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:63)

Followed by these console logs.

Received new card data
Failed to write to cards.json
Received new cardset data
Failed to write to cards.json

Steps to recovery

• Identify the root of the problem
• Patch the bug
  • Patch the ygoprodeck read/write errors
  • Patch the deck loading
• Manually test the patch with and without a YGOPro path
• Release the patch