thephpleague/commonmark-ext-autolink

Extension for league/commonmark which autolinks URLs, emails, and @-mentions

commonmark-ext-autolink's Issues

Characters after a link reversed.

In the following example:
[image src='<image>' caption='source: ( https://www.example.com/test). ']

The resulting caption for the image is:
source: (https://www.example.com/test.)
The . and ) at the end are reversed.

This only happens with some links, specifically the /test in the example was necessary to reproduce the error. I think the closing paren that gets chopped off in processAutoLinks() needs to be prepended to $leftovers instead of appended. But I'm unsure if that is correct in all cases.

Fully implement the GFM spec

See https://github.github.com/gfm/#autolinks-extension-

Makes double links for <https://example.com/>

This extension does not take into account existing inline links surrounded by angle brackets, such as <https://example.com/> - this causes them to get doubled up with an anchor tag inside another anchor tag.

$environment = \League\CommonMark\Environment::createCommonMarkEnvironment()
    ->addExtension(new \League\CommonMark\Ext\Autolink\AutolinkExtension());

$commonMarkConverter = new \League\CommonMark\CommonMarkConverter([], $environment);

$commonMarkConverter->convertToHtml('<https://example.com/>');

// Expected: '<p><a href="https://example.com/">https://example.com/</a></p>'

// Actual: '<p><a href="https://example.com/"><a href="https://example.com/">https://example.com/</a></a></p>'

Extensibility question

So, if I want to do some customizations on the @-auto-linking. Should I just copy the class, as it's declared final and the logic inside is not very complex?

started something here:

• eventum/eventum#507

but really I want to do some internal lookup of the match, skip expanding if lookup not found, and on match add title html attribute. And don't actually want to link the handle, because there's yet no user page in that application.

Make compatible with league/commonmark 0.19

• Bump the constraint
• Type ALL THE THINGS
• Make private constants actually be private

links with underscores linked incorrectly

smartpunct and autolink don't play well

input:

it’s
https://eventum.example.net/history.php?iss_id=107092
https://gitlab.example.net/group/project/merge_requests/39#note_150630

output:

<p>it’s<br />
<a href="https://eventum.example.net/history.php?iss">https://eventum.example.net/history.php?iss</a>_id=107092<br />
<a href="https://gitlab.example.net/group/project/merge">https://gitlab.example.net/group/project/merge</a>_requests/39#note_150630</p>

remove the apostrophe ’ and links get formatted properly:

<p>it<br />
<a href="https://eventum.example.net/history.php?iss_id=107092">https://eventum.example.net/history.php?iss_id=107092</a><br />
<a href="https://gitlab.example.net/group/project/merge">https://gitlab.example.net/group/project/merge</a>_requests/39#note_150630</p>

wait, the second link still wrong.

doesn't matter which apostrophe being used, or are they in pairs:

• it's, it's ' ...

versions (if that's relevant):

league/commonmark                  0.18.2               PHP Markdown parser...
league/commonmark-ext-autolink     v0.2.0               Extension for leagu...
league/commonmark-ext-inlines-only v0.1.0               Extension for leagu...
league/commonmark-ext-smartpunct   v0.1.0               Intelligently conve...
league/commonmark-extras           0.2.1                Useful extensions f...

Autolink broken on multi-line?

$text = 'fsdfasdfsad ```foo``` 


 https://httpd.apache.org/docs/2.4/howto/access.html#host';

echo $markdown->convertToHtml($text);

This code fails to auto-link

Version 0.3.0