Giter Site home page Giter Site logo

uploads's People

Contributors

philsturgeon avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

uploads's Issues

Improving DataSource

I Like the way DataSource is a "copy" of the $_FILES superglobals but I don't think I'm alone when stating that using $_FILES abstraction with multiple upload is made more difficult as it should in PHP. Is it possible to borrow How Aura.Web resolves this ? It still takes as input the super global but internally it re-arranges the data to facilitate further manipulation. Thought ?

Permissions

This project contains files with permissive permissions. In order to avoid opening a security breach, you should restrict execution rights on following files:

  • LICENSE.md
  • README.md
  • composer.json

you can fix this with the command:

$ chmod a-x 'LICENSE.md' \
      'README.md' \
      'composer.json'

Decoupling UploadedFile from $_FILES

$_FILES is made available inside the class when using UploadedFile::createFromGlobals. I would prefer having the $_FILES array in the method signature like what I did in the league\Url package.

That way:

  • the package in itself is not bound to any PHP global variable
  • mocking is made more easy

So having UploadedFile::createFromGlobals(array $files, $name) instead would be great.
People may complain on the argument order but that another debate :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.