thermadiag/seq

The seq library is a collection of original C++14 STL-like containers and related tools

seq's Issues

Compiler errors gcc-12.2.0

Hi,

There's a couple of compile errors with gcc-12.2.0

First, an include seems to be missing:

cmake --build build
[ 14%] Building CXX object CMakeFiles/seq.dir/seq/internal/block_codec.cpp.o
[ 28%] Building CXX object CMakeFiles/seq.dir/seq/internal/lz4small.cpp.o
[ 42%] Building CXX object CMakeFiles/seq.dir/seq/internal/transpose.cpp.o
[ 57%] Building CXX object CMakeFiles/seq.dir/seq/internal/charconv.cpp.o
In file included from /home/bogdb/seq/seq/internal/../charconv.hpp:123,
                 from /home/bogdb/seq/seq/internal/charconv.cpp:26:
/home/bogdb/seq/seq/internal/../tiny_string.hpp: In function ‘size_t seq::detail::traits_string_find_first_of(const Char*, size_t, size_t, const Char*, size_t, size_t)’:
/home/bogdb/seq/seq/internal/../tiny_string.hpp:280:58: error: ‘CHAR_BIT’ was not declared in this scope
  280 |                                 unsigned char buff[256 / CHAR_BIT];

This is fixed by adding #include <climits> in tiny_string.hpp.

Another build error occurs if the user fails to provide appropriate compile flags:

[ 14%] Building CXX object CMakeFiles/seq.dir/seq/internal/block_codec.cpp.o
[ 28%] Building CXX object CMakeFiles/seq.dir/seq/internal/transpose.cpp.o
[ 42%] Building CXX object CMakeFiles/seq.dir/seq/internal/hash.cpp.o
[ 85%] Building CXX object CMakeFiles/seq.dir/seq/internal/lz4small.cpp.o
[ 85%] Building CXX object CMakeFiles/seq.dir/seq/internal/charconv.cpp.o
[ 85%] Building CXX object CMakeFiles/seq.dir/seq/internal/simd.cpp.o
/build/source/seq/internal/transpose.cpp: In function '__m128i seq::transpose_4x4(__m128i)':
/build/source/seq/internal/transpose.cpp:66:24: error: '_mm_shuffle_epi8' was not declared in this scope; did you mean '_mm_shuffle_epi32'?
   66 |                 return _mm_shuffle_epi8(m, _mm_setr_epi8(0, 4, 8, 12,
      |                        ^~~~~~~~~~~~~~~~
      |                        _mm_shuffle_epi32
/build/source/seq/internal/transpose.cpp: In function 'void seq::detail::extract2Bytes_sse3(const char*, seq::hse_vector (*)[16])':
/build/source/seq/internal/transpose.cpp:187:48: error: '_mm_shuffle_epi8' was not declared in this scope; did you mean '_mm_shuffle_epi32'?
  187 |                                 __m128i val0 = _mm_shuffle_epi8(v0, sh0);
      |                                                ^~~~~~~~~~~~~~~~
      |                                                _mm_shuffle_epi32
/build/source/seq/internal/transpose.cpp: In function 'void seq::detail::extract4Bytes_sse3(const char*, seq::hse_vector (*)[16])':
/build/source/seq/internal/transpose.cpp:214:48: error: '_mm_shuffle_epi8' was not declared in this scope; did you mean '_mm_shuffle_epi32'?
  214 |                                 __m128i val0 = _mm_shuffle_epi8(v0, sh0);
      |                                                ^~~~~~~~~~~~~~~~
      |                                                _mm_shuffle_epi32
make[2]: *** [CMakeFiles/seq.dir/build.make:104: CMakeFiles/seq.dir/seq/internal/transpose.cpp.o] Error 1

This is because the user has to provide at least -mssse3 (I think) as a compile flag.

Thanks for the amazing library!