thesachin/sutekishop

Automatically exported from code.google.com/p/sutekishop

sutekishop's Issues

the contend remains same and Name field can be chenged.

Hi Mikehadlow,

I like your program. It is worth to read it  although it is very  hard to 
me. I have been searched MVC examples 

for  a long time, so far yours is the best! 

I got a small problem: At version r376, the Text field of the content 
table can’t be edited. Although it shows 

“change has been saved “, the contend remains same and Name field can be 
chenged. However Text field can be 

inserted as adding a new page. Is it something  to do with Text Data type 
and NHibernate?  
I tried on version r371 on the same database (Linq2SQL) it worked. 

Regards, 

Dennis Wang

Original issue reported on code.google.com by [email protected] on 26 Apr 2010 at 12:44

Data Source in connection string cannot start with .

SQL Server connection strings accept use of dot (.) as an alias for local 
machine so the same connection string is usable on any machine.

The problem is indeed the first line in the ValueFromKey method:

var match = Regex.Match(connectionString, string.Format(@"{0}=([\w\\\(\)]+);", 
key));

where the regex does not consider dot as a valid character.

Original issue reported on code.google.com by [email protected] on 17 Feb 2011 at 8:30

It should not be possible to create content items with the same name.

There should be a validation check to prevent this from happening.

Original issue reported on code.google.com by [email protected] on 1 Oct 2011 at 9:03

Breadcrumb navigation

To back up the current navigation tree add
a breadcrumb navigation to the site.  This is an especially effective
way of telling the user where they are and provides quick links back
up the navigation tree.

Original issue reported on code.google.com by [email protected] on 27 May 2009 at 8:31

Stock page enhancements

1. Remove inactive products.

2. Collapse list of products by category. Maybe have +/- icons to expand.

Original issue reported on code.google.com by [email protected] on 6 Apr 2009 at 8:22

User authorization and authentication

Implement authorization and authentication

Original issue reported on code.google.com by [email protected] on 14 Apr 2008 at 8:02

/report/Orders.csv throws NHibernate Linq error

What steps will reproduce the problem?
1. Navigate to /report/Orders.csv

What is the expected output? What do you see instead?
- A CSV file of all orders
- But throws an exception:

could not resolve property: Total of: Suteki.Shop.Order 
[.Select(NHibernate.Linq.NhQueryable`1[Suteki.Shop.Order], Quote((o, ) => (new 
<>f__AnonymousType8`5(o.Id, o.Email, o.OrderStatus.Name, o.CreatedDate, 
o.Total.Amount, ))), )]

Total uses the new Money type. The NHibernate Linq provider doesn't know what 
to do with this.

Original issue reported on code.google.com by [email protected] on 7 Feb 2011 at 11:26

Filter states

There is problem with filters, used in sutekishop.
According to msdn: "Do not store filter state in a filter instance. Per-request 
state would typically be stored in the Items() property. This collection is 
initialized to empty for every request and is disposed when the request 
completes. Transient per-user state is typically stored in the user's session. 
User-state information is often stored in a database. The downloadable sample 
for this topic includes a timing filter that uses per-request state."

It was not a problem in MVC 2, but in MVC 3 it becomes a pain, because filters 
are cached and not created for each request.

So for example unitofwork is 

public class UnitOfWorkFilter : IActionFilter
    {
        private readonly IDataContextProvider provider;

        public UnitOfWorkFilter(IDataContextProvider provider)
        {
            this.provider = provider;
        }

        public void OnActionExecuting(ActionExecutingContext filterContext)
        {
        }

        public void OnActionExecuted(ActionExecutedContext filterContext)
        {
            var context = provider.DataContext;

            if (filterContext.Controller.ViewData.ModelState.IsValid)
            {
                context.SubmitChanges();
            }
        }
    }

and as you can see, it has a state - provider. And as long as it is not 
recreated for each request - it gives "object is disposed" exception. 
Looks like such implementation would solve a problem:
 public class UnitOfWorkFilter : IActionFilter
    {       
        public UnitOfWorkFilter()
        {            
        }

        public void OnActionExecuting(ActionExecutingContext filterContext)
        {
            var provider = ServiceLocator.Current.GetInstance<IDataContextProvider>();
            filterContext.HttpContext.Items.Add(filterContext.ActionDescriptor, provider);
        }

        public void OnActionExecuted(ActionExecutedContext filterContext)
        {
            var provider = (IDataContextProvider)filterContext.HttpContext.Items[filterContext.ActionDescriptor];
            var context = provider.DataContext;

            if (filterContext.Controller.ViewData.ModelState.IsValid)
            {
                context.SubmitChanges();
            }
        }
    }

Original issue reported on code.google.com by [email protected] on 28 Jan 2011 at 8:29

Unit Test: CreateSizedImages_ShouldCreateImagesOfTheCorrectSize

What steps will reproduce the problem?
1. Vanilla install
2. CreateSizedImages_ShouldCreateImagesOfTheCorrectSize unit test fails.

What is the expected output? What do you see instead?
Assembly.GetExecutingAssembly().Location is passing back a location in my 
temp directory when it looks like it's expecting a path under the source 
tree.

Original issue reported on code.google.com by [email protected] on 1 Jun 2008 at 9:51

Error when saving a category with an image

What steps will reproduce the problem?
1.Set up most recent build r427
2.log in as administrator
3.add category with an image

What is the expected output? What do you see instead?
Expected: Successfully added category and image

Received: Server Error
object references an unsaved transient instance - save the transient instance 
before flushing. Type: Suteki.Shop.Image, Entity: Suteki.Shop.Image 
Description: An unhandled exception occurred during the execution of the 
current web request. Please review the stack trace for more information about 
the error and where it originated in the code. 

Exception Details: NHibernate.TransientObjectException: object references an 
unsaved transient instance - save the transient instance before flushing. Type: 
Suteki.Shop.Image, Entity: Suteki.Shop.Image

Source Error: 


Line 32:             if (filterContext.Controller.ViewData.ModelState.IsValid 
&& thereWereNoExceptions)
Line 33:            {
Line 34:                transaction.Commit();
Line 35:            }
Line 36:            else


Source File: C:\bcave\DEV\playground\ASP.NET 
MVC\sutekishop\Suteki.Shop\Suteki.Common\Filters\UnitOfWorkAttribute.cs    
Line: 34 



What version of the product are you using? On what operating system?
build r427, Windows 7/64, IIS 7.5, Sql Server 2005, Visual Studio 2010

Please provide any additional information below.

This was duplicated many times with different images and category text.

The error does not occur if an image is not attached/upoaded with the Category 
Save.  No image results in expected behavior.

Original issue reported on code.google.com by [email protected] on 7 Oct 2010 at 6:32

Order Search should not be case sensitive

Order Search should not be case sensitive

Original issue reported on code.google.com by [email protected] on 6 Apr 2009 at 8:27

Card expiry date not being correctly displayed on order form

just wondering about something.
We get quite a few customers that have ended up giving us the wrong exp date on 
their card. It seams that after they have entered all their details and then 
for some reason go back to adjust something on their order, the exp date 
reverts to the default setting.
Is this some sort of security thing we need or is it a fix ?

Original issue reported on code.google.com by [email protected] on 23 Aug 2010 at 8:29

Incorrect syntax executing 009_Add_MailingListSubscriptions.sql

What steps will reproduce the problem?
1. Install SQL Server 2008 v9.0.4220
2. Execute sql scripts from 1 to 8
3. Execute script 009_Add_MailingListSubscriptions.sql 

What is the expected output? What do you see instead?
I expect that SQL Server correctly execute the SQL script, instead I 
receive the following error:
Msg 156, Level 15, State 1, Line 2
Incorrect syntax near the keyword 'SET'.

What version of the product are you using? On what operating system?
r356

Please provide any additional information below.

Original issue reported on code.google.com by [email protected] on 5 Aug 2009 at 1:34

Check for cookies on basket.

What steps will reproduce the problem?
1. Disable cookies.
2. Select a product and click 'Add to basket'
3. Basket page says: 'your basket is empty'

What is the expected output? What do you see instead?

We should display a message saying, 'you need to enable cookies to use this
site'.

Original issue reported on code.google.com by [email protected] on 28 Jun 2009 at 8:18

Update static data script

The script SutekiShop\Database\insert_static_data.sql 
line 12

reads:
insert category ([Name], ParentId, Position) values('- Root', null, 1)

but need to include the non nullable IsActive flag and should read:
insert category ([Name], ParentId, Position, IsActive) values('- Root',
null, 1, 1)

Original issue reported on code.google.com by [email protected] on 28 Sep 2008 at 7:28

HttpContext Roles does not work

What steps will reproduce the problem?
1. HttpContext.Current.User.IsInRoles("anything")
2.
3.

What is the expected output? What do you see instead?
the current users role.  m_roles[] is always empty so the above call is
always empty

What version of the product are you using? On what operating system?
latest release

Please provide any additional information below.

Original issue reported on code.google.com by [email protected] on 3 Feb 2010 at 12:46

Cannot search on status for orders

What steps will reproduce the problem?
1. http://localhost:50398/shop/Order 
2. Change status to 'Dispatched'
3. Click 'Search'
4. All orders are displayed. Expected only Dispatched orders.

Original issue reported on code.google.com by [email protected] on 13 Apr 2009 at 3:38

Nice URL for categories - SEO

Provide a nice url for categories. Currently they look like this:

https://<hostname>/shop/Product/Index/22

Better would be:

https://<hostname>/shop/Category/T_shirts

Original issue reported on code.google.com by [email protected] on 20 Aug 2010 at 8:42

Add ELMAH

Add ELMAH to Suteki Shop:

http://code.google.com/p/elmah/

Original issue reported on code.google.com by [email protected] on 19 May 2009 at 12:44

Product Search implementation patch

See discussion threade here:

http://groups.google.com/group/sutekishop/browse_thread/thread/27b02f1fea461931/
c4e3c167bffab7f4#c4e3c167bffab7f4

Original issue reported on code.google.com by [email protected] on 6 Apr 2009 at 2:05

Product can save with no default size

What steps will reproduce the problem?
1. Create a new product type with no size information
2. Attempt to view it
3. Application error thor on line 57 Suteki.Shop\models\Products.cs

What is the expected output? What do you see instead?
Expect validation on the creation screen. instead get an eror when viewing
the product: "Product has no default size"


What version of the product are you using? On what operating system?
Current release (288), OS = vista 64


Please provide any additional information below.

Original issue reported on code.google.com by [email protected] on 27 Apr 2009 at 12:49

IIS7 Compatibility

Does not work under IIS 7 integrated mode. Issued identified so far:
- UrlBasedComponentSelector accessed HttpContext.Current.Request which is
unavailable in Application_Start
- DisposePrincipal occurs after the DataContext has been disposed which
causes a webserver crash when the User attempts to load its Roles. 

Original issue reported on code.google.com by [email protected] on 12 Apr 2009 at 1:29

NewMenu_ShouldShowMenuEditView test failing

What steps will reproduce the problem?
1. Vanilla install
2. Run NewMenu_ShouldShowMenuEditView unit test

Test fails with an application exception.  Could be a data issue.

Original issue reported on code.google.com by [email protected] on 1 Jun 2008 at 9:20

Edit Menu throws InvalidOperationException

What steps will reproduce the problem?
1. Navigate to http://localhost:5401/shop/Menu/List/1

The model item passed into the dictionary is of type 
'Suteki.Shop.ViewData.CmsViewData', but this dictionary requires a model item 
of type 'Suteki.Shop.Content'.

Original issue reported on code.google.com by [email protected] on 8 Feb 2011 at 3:54

Basket Summary

You currently have a link to "View Basket" on the left hand side.
I would suggest adding to that a simple basket overview area i.e.
number of items and current cost of the items in the basket.  (e.g. 2
items : £25.23).  This way the user knows their current running total.

Original issue reported on code.google.com by [email protected] on 27 May 2009 at 8:30

Configurable Currency type

Right now, the currency type is £.  To change it to $ or something else,
you have to run a search/replace.  

I recommend the currency type be easily configurable.  Maybe through the
config file.  

Original issue reported on code.google.com by [email protected] on 3 May 2010 at 3:49

Format credit card numbers in groups of four digits when displayed.

Format credit card numbers in groups of four digits when displayed.

Original issue reported on code.google.com by [email protected] on 6 Apr 2009 at 8:30

Edit content throws SqlException

What steps will reproduce the problem?
1. navigate to http://localhost:5401/shop/Cms/EditTop/2
2. edit the content, and click 'Save Changes'
3. throws SqlException:

The UPDATE statement conflicted with the FOREIGN KEY constraint 
"FK4FEDF4B6E53A5F80". The conflict occurred in database "SutekiShop", table 
"dbo.ContentType", column 'ContentTypeId'.

Original issue reported on code.google.com by [email protected] on 8 Feb 2011 at 3:53

Descriptor for HornGet

Build a descriptor for HornGet.

Original issue reported on code.google.com by [email protected] on 1 Nov 2009 at 10:03

EU Cookie Law

What steps will reproduce the problem?
1. A Cookie warning and explanation text needs to be displayed on the website.

2. This should be configurable (on / off) by web admins.

Original issue reported on code.google.com by [email protected] on 6 Nov 2012 at 3:37

Could not load type 'System.Web.HttpContextWrapper2' from assembly 'System.Web.Abstractions, Version=3.5.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.

What steps will reproduce the problem?
1. Have the .Net MVC R1 framework installed
2. Attempt to run
3.

Received this error

Could not load type 'System.Web.HttpContextWrapper2' from assembly
'System.Web.Abstractions, Version=3.5.0.0, Culture=neutral,
PublicKeyToken=31bf3856ad364e35'.


What is the expected output? What do you see instead?

Unable to run the site

What version of the product are you using? On what operating system?

Windows Server 2008 64 bit

Please provide any additional information below.

Original issue reported on code.google.com by [email protected] on 22 Mar 2009 at 10:13

Transient lifestyles introducing memory leak?

http://stw.castleproject.org/Default.aspx?Page=LifeStyles&NS=Windsor&AspxAutoDet
ectCookieSupport=1

Transient components are tracked by the container
To ensure proper components lifecycle management Windsor will track your 
components, even transient ones. That means that unless you release them, 
Garbage Collector will not be able to reclaim them, and you'll end up with 
de-facto memory leak. Remember to release your transient components. 

You use transient on a lot of your interfaces and I don't see any calls to 
release.  Is this a problem?

Original issue reported on code.google.com by [email protected] on 24 Nov 2010 at 11:27

Related Products

Create the ability to relate products to each-other.

Original issue reported on code.google.com by [email protected] on 6 May 2010 at 2:34

Change 'Size' to 'Option' to be more product-neutral

I suggest the table/entity 'Size' be changed to 'Option' or 'ProductOption'
to be more product-neutral. 

Original issue reported on code.google.com by [email protected] on 3 May 2010 at 3:29

Product name change makes stock update throw on dispatch.

What steps will reproduce the problem?
1. Create an order.
2. Change the name of one of the products in the order
3. Dispatch the order

What is the expected output? What do you see instead?

Expect to see the order status change to dispatched and the stock level 
decremented. Instead, the stock control system throws an exception because it 
can't identify the product. (it is keyed on the ProductUrlName)

What version of the product are you using?
2.2.0.506

Please provide any additional information below.
The order ProductUrlName needs to be updated when a product name is updated.

Original issue reported on code.google.com by [email protected] on 26 Jun 2011 at 8:41

Keep user on product page after clicking 'Add to Basket'

When a user clicks on the "Add to Basket" button they are taken
straight to the Basket page, this means they are taken away from the
products' pages which some users find very annoying.  I would suggest
that when the button is press the page is refreshed and a simple "your
item has been added to the basket" message is shown.  This means they
can stay within the products sections.

Original issue reported on code.google.com by [email protected] on 27 May 2009 at 8:29

Validation tests, globalization issue

What steps will reproduce the problem?

1. Build Suteki.Common.Tests project on the machine with culture where 
float-point is not a dot, say ru-RU.
2. Run unit tests.
3. Get a ValidationException "Bind Failed. See ModelStateDictionary for 
errors" in the Suteki.Common.Validation.ValidatingBinder's UpdateFrom 
method. Test failed.

What is the expected output? What do you see instead?
Test ShouldBindCorrectValues() failed. 

What version of the product are you using? On what operating system?
Suteki.Common 1.0.0.0 on localized Windows Vista.


The cure.
Edit ValidatingBinderTest.cs file so the nunit setup code should be like 
that:
        [SetUp]
        public void SetUp()
        {
            Thread.CurrentThread.CurrentCulture = 
CultureInfo.GetCultureInfo("en-US");  // set test's culture 

            validatingBinder = new ValidatingBinder(
                new SimplePropertyBinder(),
                new BooleanPropertyBinder());
        }

Then all test run nice. Thank you!

Original issue reported on code.google.com by [email protected] on 7 Jun 2009 at 5:24

Possible Cross Side Scripting

Source Code review with Armorize Code Secure. 

Original issue reported on code.google.com by [email protected] on 30 Dec 2011 at 4:58

Attachments:

• Capture.PNG

Money type

It is my understanding that the money type is changed in code. However I have 
been unable to find which file this is kept in. 

Can anyone point out which file I need to look in to make this this adjustment.

Thank you

Original issue reported on code.google.com by [email protected] on 28 Aug 2013 at 8:54

Poor error handling when db connection fails

What steps will reproduce the problem?
1. Change connection string so that DB connection will fail
2. Start application

What is the expected output? 

The application should display a clear error message explaining that the
connection string is invalid.

What do you see instead?

Infinite loop of exceptions and retrys. If the application is being run in
the WebDev server, it eventually crashes the server.

Original issue reported on code.google.com by [email protected] on 28 Jun 2009 at 6:37

Order Search: Paging removes criteria

What steps will reproduce the problem?
1. /shop/Order 
2. Select status: 'Created'
3. Click Search
4. Correct first page of created orders is displayed
5. click '2' on the paging control
6. Second page of all orders is displayed, status is 'Any'. Should see the
2nd page of created orders.

Original issue reported on code.google.com by [email protected] on 13 Apr 2009 at 5:17

Product Description HTML validated on way out but not on way in allows unrenderable product to be created.

What steps will reproduce the problem?
1. Create a new Product
2. Cut and Paste HTML from another Web page directly into the Fck 
editors "design" mode. Text appears fine. Save product, product is added.
3. Return to Category menu and click on new product
4. Exception is thrown. Below is pertinent line from log.

System.Web.HttpRequestValidationException: A potentially dangerous 
Request.Form value was detected from the client (product.Description="<p 
class="product_te...").

It appears that the same validation on output is not running on output. 
The reason this is a larger problem (because its the wrong way to enter 
HTML) is that once the product is entered, you cannot fix it since it uses 
the same view to render for both admin and client-side.

Original issue reported on code.google.com by [email protected] on 4 May 2009 at 5:09