thesillydoggo/blur-bg

BlurBG

This is where she makes a mod.

blur-bg's Issues

shader VERY unoptimized; duplicate blur nodes on some layers

description

I decided to make this a single issue - the mod currently has two major problems:

• The blur shader used is very very unoptimized
• on some layers/pages/popups, CCBlurLayer gets added multiple times, causing further performance issues

I would consider my system more than able to run shaders (especially simple things such as blur!), even in parallel.
(see attached video below)

2024-05-14.12-34-42.mp4

_{side note: i intentionally made the CCBlurNodes invisible using devtools to show their performance impact}

my system

• CPU: AMD Ryzen 5 5600X @3.7GHz
• GPU: AMD Radeon RX 6900XT (roughly equivalent to an NVIDIA RTX 3080-ish)
• RAM: 48GB of corsair vengeance DDR4-3200, quad channel config
• OS: Arch Linux, GD running through GE-Proton9-5

reproducing

• the shader lag:
  • open a popup that has multiple sub-popups
  • frametime significantly jumps up at 3 visible CCBlurLayers on my system, becomes unusable at 4
• the CCBlurNode duplicating:
  • open almost any popup, examples:
    • quests/ChallengesPage creates 3
    • DailyLevelPage creates 2
    • GJPromoPopup creates 2
    • GJPathsLayer creates 2
    • GJPathPage creates 3
    • ProfilePage creates 2
    • CharacterColorPage creates 3
    • (this list is not exhaustive)

possible fixes?

for the shader lag, rewrite the shaders to be more optimized

for the duplicate nodes, keep track whether or not a CCBlurNode has already been created or not.
another cool thing would be to just have a single CCBlurNode even for nested shaders that adapts its blur strength using a glUniform instead of creating a new shader instance for every sub-layer. this could also fix the shader lag mentioned above.

Suggest: Add a progress/time indicator to pause menu or an option to disable for level pause

Sometimes players need to screenshot a pause screen to share their new things you know :/