Giter Site home page Giter Site logo

tuner's People

Contributors

ahangarha avatar blumia avatar djpohly avatar elastic-rock avatar glandos avatar poussinou avatar super12138 avatar thetwom avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

tuner's Issues

upload file mode

upload a file or record a file of you singing and be able to scroll at different speeds / scrub through it, this will be able to tell you the melody you sang

Some accessibility issues in GUIs

Description
This is a bug report about components that have accessibility issues within the GUI of such an App.
Also, as the following Figure, this report focuses on the content GUI page in the App.
MuMu20221128090856
Content
After I applied my proposed tool to detect the content page, I discovered the annotated buttons are small to click for low-vision users, and I sincerely struggled you could enlarge these buttons so that low-vision users would use this App more conveniently.
Thanks a lot~!

Green point starts at random location

No idea why but i feel like this could be improved.

  • Maybe hide it until there really is a sound
  • M aybe give it some fake trail.
  • Maybe make it remember the last trail drawn.

Screenshot_20210630-073514_Tuner.jpg

Note reference reading is a bit off for me?

I Have a clip on D'Addario tuner and when tuned to 440 E standard perfectly tuned open string (G for example) reads a bit sharp in this app, a fix for me would be to set reference as 443 and it become in sync with my hardware tuner.

I may provide screens or any additional info if this Happens to be my android p=one specific issue thanks!

Absolutely love scientific UI design since I could use it to train my ear for example or determine which frequency and note is produced by surrounding objects. (Im not a pitch perfect gang member)

Add identifying factor to name

Hi, you've created a very pretty tuner! It's also nice to find new open-source tuners! :)

A suggestion: Add something to the name that makes it unique. Searching for "tuner", it's pretty difficult to actually find this app.

Feature request: option for pure black background for OLED screens

Firstly, thanks for your work on the app! As a dev and a hobby musician, I love this nice open source tuner.

Just wanted to request that you add an option to make the blacks "pure" for OLED screens, as for example fdroid has in its settings.

Perhaps you've already done this in the upcoming release candidate as I see you've reworked the colors but unfortunately, for whatever reason, I was unable to install it on my Android 11 device. Perhaps that deserves a bug report of its own?

Make some settings more clear

This is the main one. No idea what it does:
Screenshot_20210627-150202_Tuner.jpg

In general though, it might be a good idea to help users understand the settings. Sound analysis is a complicated subject for most peope.

Not sure how this best is achieved though without adding tons of explanatory popups.

Add an ability to filter background noise

If there is some background noise when I'm tuning my guitar (for example someone is talking in the distance), the app goes all over the place when I don't play anything. Then I play a note and it suddenly jumps to the note I played. Then it jumps somewhere else when the note I played fades out or when I damp it.

Screen Content

Hi!
Great Turner, I am much liking the history-graph! Thanks!

For me as Wind Player, it is very much important to see the graph movements as exact as possible. For this reason it would be great to have the graph-section on a bigger surface.

so my suggestion: if selected the chromatic option, do not display the "string section" (the upper part of the screen). Only display the lower part of the screen, the "graph section" on the whole height.

Or a option in the settings to do so would also be good.

Am I understandable?
Best regards!

[Feature request] Display how many cents off the note is off from target pitch

It would make this great app even better if we could have an option to show exactly how flat or sharp the note is in cents and not just the graph (which already works great for most applications). Alternatively, perhaps on scientific mode the graph could also have more markings (every 10 cents or so) so the user can at least better estimate the value in cents.

Thank you :)

Indian solfege notations

What this app has provided to me is so much that i felt bad asking this feature request.

But i think it might help a lot of indian people out...

It would be nice to change the solfege notations with different ones..

Like change each word to something else

Do.... சா
Re.... ரீ
Mi... கா
Fa.... மா

These are not literal translation but notations in my language based upon Indian classical music practice..

We use

Do... Sa
Re... Ri
Mi... Ga
Fa... Ma

So is there a possibility of working this into the app while not messing up with too many settings.

And thanks a lot of this beautifully designed application... Hope one for metronome in future

Back button does not close the app

Hi, since last update (5.1.0), pressing the back button while in the main window of the app does not do anything. It used to close the app. Is it intentional? I cannot find a way to close the app different to switching it to background and then swiping it.

Thanks for the app, it helps me with my music studies. ^^

Add Violin

Could you maybe add the violin to the predefined instruments? Its strings are tuned to G, D, A and E. A is 440 Hz

Stop note-names from overlapping

In those big movements mentioned in #10, tons of note-names overlap.

I suggest only showing octaves of the note you're moving to when the names start getting too close.

Screenshot_20210628-191315_Tuner.jpg

Option to select the 7th Note in Solfege as "Ti" or "Si"

While translating this app into other language, I found the 7th note was called "Si" instead of "Ti". I suggest we can have a configuration to let users select to use "Si" or "Ti" since "Ti" is common to see and it's also okay if some users prefer to use "Si".

This is probably better to be a standalone option instead of bound to localization strings because even in the same region/country, a user can still have different preference to use either "Ti" or "Si". For example, in China, most people prefer using "Si" over "Ti", but there are still people prefer to use "Ti" since it won't be conflict with Solfege's chromatically altered syllables (in this case, raised 5 will be Si).

See also: Wikipedia: Solfege

See the previous discussions here: #57

[Feature] Basic/large tuner view

The tuner works great. The only difficulty I have is that it's hard to use quickly or at a distance/with bad eyesight (e.g. arm's length on a music stand) because of the small text and relatively large number of things on the screen.

I would love to see a basic tuner view with just a horizontal cents scale, the current target note in the middle, and a moving indicator. Alternatively, it could be a speedometer style tuner with a rotating needle which might be nicer.

Perhaps a red light on either side for sharp or flat and a green one in the middle for in tune. The separation would help with clarity and colour blindness.

[Feature] Add activity-indicator

Currently, when the tone gets too quiet, the line just stops moving.

With instruments that don't have much fluctuation within a single tone, the user has no idea whether the recording actually stopped or whether the note still is displayed, because all the user sees is this:
20210629_222220.jpg

I have to suggestions on how to fix this

  1. Add some lines that trail across the screen when the dot "is moving towards the right"
  2. Make it so that the trail always continues, but the trail changes color when the signal is insufficient.

Either fix is fine. Of course, I'm open to suggestions :)

pure tone

option to press a note and have it ring out a pure tone of that notw

Tuner & Metronome

Currently both your Tuner and Metronome apps are by far the best implementation of these tools in my opinion, and I love using them on a daily basis. the only request I have is if there was an app the has both the functionality in one place...

Feature request: custom tunings

Would it be at all possible to have a feature to add custom tunings? I don't know how hard this would be to implement but it would be fantastic.

Remove the duplicate of IPN

I assume that Default (A-B-C-...) and International (A-B-C-...) are the same and it's confusing.

Please, remove the duplicate and go to this:

Carnatic
Hindustani
International (Default)
Solfège

Current UI:
Screenshot_20231006-152441

Release announcement with wrong English

Hello,

you have the sentence "Reference note must not be A4"
in https://github.com/thetwom/Tuner/releases

"must not" means "darf nicht" in German, which is certainly not what you want to say, but that is what the native speaker reads here.

Correct: "Reference note does not need to be A4"
or positive: "Reference note can be different from A4"

I noticed this in the description in the F-Droid App-store as well.

Mfg!

Feature request: other equal temperaments besides 12-tone ones

One of the other ways people tune instruments is to different equal-divisions-of-the-octave or edo https://en.xen.wiki/w/EDO

I'm particularly promoting 41edo as used by Kite-fretting see https://kiteguitar.com/ and the associated up/down ^/v notation standard. That's now supported in some tuners on desktop computers (it's in Guitarix now) and on this simple web tuner which works on desktop or mobile: https://github.com/wilckerson/microtonal-tuner but the native Android app and your wonderful UI would be ideal.

P.S. Love the way this tuner works and that F-Droid is put first and the rest of the promotion of FLO values! Thanks!!

Feature request: custom temperaments (no need for GUI)

It would be great to support custom temperaments. It can be something not in the GUI, like the way https://billthefarmer.github.io/ctuner/ supports custom temperaments by the creation of a custom .txt file (incidentally, the most significant problem with that tuner itself for temperaments is that the software is limited to only 12 pitches per octave)

So, just a documented way for users to add their own temperaments would be big, even if they have to mess with text files and file directories rather than have a nice GUI for it.

P.S. calling these "temperaments" is technically imprecise because a tuning could be strictly Just Intonation, which is not a temperament, temperaments temper the pitches away from JI. So, "custom tuning" is the proper term, but I understand the confusion between instrument-tuning (like open strings) vs tuning as in pitch choices in a tuning system.

Add viola and cello tunings

How about including the orchestral string instruments to the default instrument list?

  • Viola: C3, G3, D4, and A4
  • Cello: C2, G2, D3 and A3

We already have Violin and Double Bass (4-string bass).

By the way, I love the app and the new custom tunings feature.

Thank you

Hello!
I just want to say, thank you for these tuner and metronome! These are literally best software for tuning and metronoming(?) ever and I use them every day!
How can I tip to you or something?

Material 3

Update the rest of the UI to Material 3 design.

E.g. these are still Material 2:
Screenshot_20231006-151453__01__01
Here Material 3:
Screenshot_20231006-152011__01
Screenshot_20231006-152036__01

Wrong octave

The octaves are off-by-one; A₄ is the 440 Hz one.

Feature request: option to display sharp/flat names side by side

Hi, inventor of ups/downs notation and the Kite guitar here. First of all, thank you for this wonderful app! The GUI is awesome! Seeing the tuning history in graph form is so nice!

An option to display the sharp name and the flat name side by side would be great. But in the lower half of the screen, this would make the tuning history window narrower. So perhaps the names would be one above the other? Or perhaps both names show up only in the top half of the screen?

Background: As a long-time microtonalist, I'm fine with the current state of the app. But we in the Kite guitar community do a lot of promoting 41edo to microtonal newbies. They have to go from 12edo straight to 41 without first using smaller edos like 17 or 22. Learning all the enharmonic equivalences can be overwhelming. The tuner they use is a natural place for them to learn that. True, they could use the #/b button to switch back and forth, but it's much easier for them if the 2 names are listed side by side.

Crash on app start

Hi Michael!
On app start I can see some grid structure for fractions of a second, then the app crashes. The Scoop app extracts this from the logs

FATAL EXCEPTION: main Process: de.moekadu.tuner, PID: 13084 android.content.res.Resources$NotFoundException: Resource ID #0x7f080072 at android.content.res.Resources.getValue(Resources.java:1351) at androidx.appcompat.widget.ResourceManagerInternal.loadDrawableFromDelegates(ResourceManagerInternal.java:252) at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:139) at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:132) at androidx.appcompat.content.res.AppCompatResources.getDrawable(AppCompatResources.java:104) at androidx.appcompat.view.menu.MenuItemImpl.getIcon(MenuItemImpl.java:505) at androidx.appcompat.view.menu.ActionMenuItemView.initialize(ActionMenuItemView.java:126) at androidx.appcompat.widget.ActionMenuPresenter.bindItemView(ActionMenuPresenter.java:207) at androidx.appcompat.view.menu.BaseMenuPresenter.getItemView(BaseMenuPresenter.java:188) at androidx.appcompat.widget.ActionMenuPresenter.getItemView(ActionMenuPresenter.java:193) at androidx.appcompat.widget.ActionMenuPresenter.flagActionItems(ActionMenuPresenter.java:495) at androidx.appcompat.view.menu.MenuBuilder.flagActionItems(MenuBuilder.java:1176) at androidx.appcompat.view.menu.BaseMenuPresenter.updateMenuView(BaseMenuPresenter.java:96) at androidx.appcompat.widget.ActionMenuPresenter.updateMenuView(ActionMenuPresenter.java:226) at androidx.appcompat.view.menu.MenuBuilder.dispatchPresenterUpdate(MenuBuilder.java:292) at androidx.appcompat.view.menu.MenuBuilder.onItemsChanged(MenuBuilder.java:1063) at androidx.appcompat.view.menu.MenuBuilder.startDispatchingItemsChanged(MenuBuilder.java:1090) at androidx.appcompat.app.ToolbarActionBar.populateOptionsMenu(ToolbarActionBar.java:462) at androidx.appcompat.app.ToolbarActionBar$1.run(ToolbarActionBar.java:57) at android.os.Handler.handleCallback(Handler.java:746) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:148) at android.app.ActivityThread.main(ActivityThread.java:5443) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:728) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)

Tuner v1.2.0 from F-Droid, Vanilla Android 6.0.1, Moto G4

App description is inaccurately modest

The app description in F-Droid and the Play Store is much too humble for what the app can do. I'd recommend replacing the word "basic" with something like "highly configurable." In addition, you could list a few (or all!) of the alternative temperaments supported, e.g. "Tuning to equal temperament, meantone, Kirnberger, Vallotti, various EDOs, and more."

Helmholtz notation

Add Helmholtz notation. It's important at least here in Nordic where Helmholtz is more common than International notation and it's confusing when tuner speaks a different "language".

International notation:
... C₀ ... C₁ ... C₂ ... C₃ ... C₄ ... C₅ ...
Helmholtz notation:
... C₂ ... C₁ ... C ... c ... c¹ ... c² ...

I think this is also pretty trivial to implement.

Remove/speed up zooming-animation

Regarding usability improvements: this is absolutely the largest one I can think of.

For a few instruments this might be fine. The guitar or a violin can produce a long, loud sound. No problems there.
However, when tuning other instruments (such as the piano) the higher strings are short and not able to produce a long, constant sound. This results in the tuner in stopping to register the current note, making it jump down all the way to some low note that's humming in the background. When you hit the note again, you have to wait for the tuner to move back all the way to the current note.
This happens a lot (sometimes multiple times a string) and it takes up a lot of time.

Suggested fix:

I won't suggest leaving out the animation completely. That might take away an important visual indicator.
Therefore, I suggest speeding up the note-switching animation, especially for cross-spectrum switches (from something like a 40Hz note to a 5000Hz note).


(Btw, the app 'universal tuner' also suffers from this)

Setting titles are cut off

Not sure what to do here but it's not great having to turn your phone sideways to even understand the settings.

Screenshot_20210627-131227_Tuner.jpg

Feature request: select key notation/language

Currently the app's key notation (and language) seems to be set according to the system's language (e.g. values-de seems to be used in my case).
It would be nice to have an option to select it manually.

Thank you for this wonderful app!

Solfage notation

thank you for the great app I had a feature request: I'd enjoy having the option to change the notation to Solfège (Do-Re-Mi-Fa-Sol-La-Si) because that's what many people are familiar with, it'd be cool if there were an option to change the notation.

turn off note amount adjustment

In the bottom window, the amount of visible notes can jump drastically. There should be an option to set how many notes are visible / an octave mode that after hearing the first new note it will show 6 notes above it and 6 below. This is a general idea, tweak at will

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.