thewoolleyman/process_helper

Makes it easy to spawn Ruby sub-processes with guaranteed exit status handling, capturing and/or suppressing combined STDOUT and STDERR streams, providing STDIN input, timeouts, and running via a pseudo terminal.

process_helper's Issues

Add :return_exit_status option to return `output, exit_status`

but only if expected_exit_status contains more than one value.

Correctly handle Errno::EINTR

See http://250bpm.com/blog:12

and https://github.com/ruby/ruby/blob/ruby_2_4/prelude.rb#L36

and https://www.freebsd.org/cgi/man.cgi?read(2)

THis should be captures and just retried in the read nonblock loop. The only thing that should exit the loop is the EOF exception.

Make `:include_output_in_exception` default to false if `:puts_output` is `:always` or `:error`

Otherwise it results in duplicate output.

output is occasionally swallowed

In some rare cases, some of the streaming output of the wrapped process is swallowed and never shown.

Don't have a reproducible case yet, but opening an issue just so users are aware it's a known issue even on most recent rubies (2.3).

Seems like this may be a bug in the underlying Open3.popen2e implementation, since process_helper is just a thin wrapper around that.

Add example bootstrap script

Add timeout for PTY subprocess to die after PTY ends

V 0.1.0 immediately raised an exception if child process wasn't dead by the time the PTY spawn returned, but it happens sometimes. Add a timeout to wait for it.

Handle STDIN as StringIO object rather than array of strings

Allow input as either a string or StringIO.

See https://ruby-doc.org/stdlib-2.3.0/libdoc/stringio/rdoc/StringIO.html

Should be more flexible and straightforward implementation.

Question: What mode? binary? Is this related to color?

No output from git log %H format command

Following gives no output in return value:

process('git log -1 --pretty=format:%H')

Should be invokable as a module method

Should be invokable via ProcessHelper.process instead of requiring module to be included.

Support color in terminals

When using the ruby system method to shell out, it sets the correct options to preserve color in the output. For example system(rspec --color). ProcessHelper should do the same.

Looking at the RSpec code, it uses the #tty? method to determine if color is supported, which is usually IO#tty? on $stdout.

In this specific instance, RSpec can be forced to use color by adding the --tty option in addition to --color; since ProcessHelper is intended for use on any command, it's best to support color output rather than figure out one-off overrides for every command.

• Perhaps relevant: rails/spring@95bca40

Include `process.exitstatus` as part of `UnexpectedExitStatusError`

This can make it easier to differentiate between different types of failures without having to parse the output.