thiagodp/database-js-mssql

Database-js driver for SQL Server that works on Linux, Mac, and Windows

database-js-mssql

Database-js driver for SQL Server that works on Linux, Mac, and Windows

This database-js driver is a wrapper for node-mssql and works with MS SQL Server 2000-2017. Pull Requests are welcome!

Install

npm install --save database-js-mssql

Example

var Connection = require('database-js').Connection;

(async function() {
    let conn, statement, results;
    try {
        conn = new Connection('mssql:///username:password@localhost/database');
        statement = conn.prepareStatement("SELECT * FROM states WHERE state = ?");
        results = await statement.query("South Dakota");
        console.log(results);
    } catch (reason) {
        console.log(reason);
    } finally {
        if (conn) {
            await conn.close();
        }
    }
})();

License

MIT © Thiago Delgado Pinto

database-js-mssql's Issues

Error: Global connection already exists. Call sql.close() first.

Using a StaticPool in database-js with mssql in the common idiom found in the code:

    // query(sql,params) : executes sql against the database
    // 
    query: async (sql,params) => {
        let connection
        try {
            if(!pool) { // pool declared at higher scope
                pool = new StaticPool(process.env['CNXN_STRING']) // a mssql://... URI
            }
            connection = pool.getConnection()
            let statement = await connection.prepareStatement(sql)
            return await statement.query.apply(statement, params)
        } catch(err) {
            console.error(`query("${sql}",${require('util').inspect(params)}) : ${err}`)
        } finally {
            await connection.close()
        }
    },

Note that connection.close() is called in the finally, so the connection itself is cleaned up.

The problem is when the code is done and goes to clean up the StaticPool, with pool.close(), a Error: Global connection already exists. Call sql.close() first. error is returned.

It looks like in class MsSql's close method, it's obtaining the pool via _pool(), which re-connects to the database if the connection is already closed. I think the close method should check _isConnected first, and only clean up if it is connected.

Using:

• database-js: 3.0.8
• database-js-mssql: 0.2.2

Version 0.3 not published

Thanks to @orihomie that registered an Issue at database-js.