Would you consider a PR that adds a third state for the timer?

[ervinebalo]

Would you consider a PR that adds a third state for the timer?

[ervinebalo]

@thibaultboursier I can create a PR to create a status

[thibaultboursier]

Hello @ervine13,

I approved your PR and merged in into develop branch. I'll merge it into master soon, and will make a new version 2.0.0.
Then, we'll close this issue if it's OK for you.

Thanks ;-)

[ervinebalo]

Thanks, @thibaultboursier

[thibaultboursier]

Hello @ervine13,

Thanks for opening this issue. It could be a good idea to have others states that just isRunning.
Can you give me an example of the kind of properties you would like to access when using this useTimer hook? isPaused, ...

Have a nice day.

[ervinebalo]

@thibaultboursier , sorry for the delayed response. isPaused was the only one I could think of. At least for my use case.

If you're open to more significant change, you could create a status property that returns 3 values active, paused, stopped.

[thibaultboursier]

Hello @ervine13,

Very good idea to have a status property. It should make a breaking change and a new major release, as we currently return isRunning property, and we would remove it.

So, two choices to handle your point:

1. Return separate properties

We would return isRunning (maybe semantically better than isActive?), isPaused, isStopped.

2. Return a status string

We could create a status type:

export type Status = 'RUNNING' | 'PAUSED' | 'STOPPED';

We would update status value inside reducer.

What do you think? Would you like to make a PR?

[thibaultboursier]

@ervine13 You rocks 🦸‍♂️