Giter Site home page Giter Site logo

kapla's People

Contributors

hyakki avatar thierrymichel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

luruke gablyazov

kapla's Issues

Custom events that not unbind

Hi (and thanks for Kapla!)

I've found these two problems related to events.
I've build a repo to test them and show you the code:
https://github.com/gfnool/kapla-test

  1. If a component is listening to two custom 'global' events, when the component is destroyed only one of the event is unbind. This does not happen if the custom event type is 'component'
    https://kapla-test.netlify.app/global-events.html

  2. If a dom node has two components attached and they are listening to the same custom event, when the node is destroyed only one of the listener is unbind.
    https://kapla-test.netlify.app/same-node.html

Are they known bugs?
Is there a better way to use global events?

Thank you!

Multiple "same-component" instances on the same "page"

I see the components are indexed in the Manager using their slug.
The slug is the name of the component "normalized" right?

I haven't tested, but we should check if we can have multiple "same components" on the same page, each one with its own instance.

Add more tests

Improve tests and coverage to avoid "testing-patching-publishing" workflow…

Web components?

I know, i'm late to the party 🎉 ...
Have you took in consideration to use web components instead of manually checking DOM mutation?

Web Components seems to have automatic lifecycle callbacks (connected/disconnected...) that may simplify the library meanwhile using a living standard. I'm sure there are also good polyfills methods for web components.

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.