thirdweb-dev/docs

thirdweb docs portal

docs's Issues

Mismatch between code example and type information

About

docs/docs/typescript/thirdwebsdk.fromsigner.mdx

Lines 23 to 26 in 25c21ff

	const sdk = ThirdwebSDK.fromSigner(signer, {
	clientId: "YOUR_CLIENT_ID", // Use client id if using on the client side, get it from dashboard settings
	secretKey: "YOUR_SECRET_KEY", // Use secret key if using on the server, get it from dashboard settings
	});

In this example, the second argument passes an object containing the clientId and secretKey.

However, the following type information shows that no object containing those two is passed.
The documentation needs to be corrected.

https://github.com/thirdweb-dev/js/blob/ec36b13a30e0071548df0b7a6eb5299e2e65e4f9/packages/sdk/src/evm/core/sdk.ts#L181-L186

https://github.com/thirdweb-dev/js/blob/ec36b13a30e0071548df0b7a6eb5299e2e65e4f9/packages/chains/src/types.ts#L15-L46

A suggestion for updating the "useContractRead" documentation.

Issue: When using the read functions (via useContractRead), the sender address is not automatically sent, causing msg.sender to be inaccessible to any view function within the smart contract. To work around this, I must explicitly fetch and pass the address using the "from" property in overrides. demonstrated in the image below calling the function with and without "from" property in overrides.

[Image: Image with and without Overrides]

Suggestion: It would be beneficial to enhance the user experience by adding a note or highlighting the importance of including the sender's address in view functions. Furthermore, consider implementing a boolean toggle that allows users to enable or disable the automatic forwarding of the sender's address, providing greater flexibility in contract interaction.

note:- above suggestion can be applicable to both Docs and Dashboard.

document update or any thing! please let me know, i'm happy to contribute.

Thank you.

A suggestion to add the code for nextJs 13 App router

As we already now NEXTJS is doing great and evolving constantly . One of there major update is Its APP ROUTER which is easy to use but if some one is building with app router there is many point where Newbie can stuck. it would be great if someone also add the App Router Code snippet there too.

I'm also open to contribute in the documentation.