thisissoon/angular-scroll-collapse

A simple lightweight library for Angular that detects scroll direction and adds a sn-scrolling-up or sn-scrolling-down class to the element. The library can also detect when the user has scrolled passed the element and apply a sn-affix class. Useful for make a element sticky when the user has scrolled beyond it. This library can will also apply sn-minimise class after the user has scrolled beyond the height of the element

angular-scroll-collapse's Issues

Not working with latest Angular version (8.1.2), Could you please make it compatible.

bug(minimise): minimise not functioning as expected when viewport not at top of page on load

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

sn-minimise class not applied correctly to nav element in repo example app when page loaded with viewport not at top of page.

Expected behavior

sn-minimise class should be be applied as normal (e.g when page loaded with viewport at top of page)

Environment

This repos demo app.

Bug with angular-inviewport v4.0.0

Hi,

I have an error after updating your package thisissoon/angular-inviewport to v4.0.0 :

ERROR in node_modules/@thisissoon/angular-scroll-collapse/app/scroll-collapse/scroll-collapse.directive.d.ts(2,10): error TS2305: Module '".../node_modules/@thisissoon/angular-inviewport/thisissoon-angular-inviewport"' has no exported member 'WindowRef'.

Is it possible to fix it ?

Thank you

Change scrollCollapse selector to snScrollCollapse

This is best practice to avoid clashes with other libs and future standards.

<nav snScrollCollapse>...</nav>

bug(window height change): directive doesn't function correctly after viewport height change

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

Directive appears broken if viewport height is changed after page load.

Expected behavior

Directive should work as normal after viewport height change.

Environment

This repos demo app.