thomasrayner/broombot

Azure DevOps Pull Request Minder

broombot's Issues

Reporting, dashboarding

Right now, there is no kind of reporting or dashboarding conveniently available to track stale PRs or the activities of BroomBot. There is logging in the Azure Function itself, but this is not a management/PM/normal human-friendly way to communicate this data.

Close/Update work items

ADO PRs may have work items attached to them. There may be an opportunity to interact with the work items according to what the status of the PR is.

For instance, if a PR is stale but the attached work item is closed, perhaps the work item should be re-opened and the person it's assigned to should be notified.

Docs - readme.md

readme.md is very basic and introductory, and in need of expansion. Information on contributing, deployment, and just overall more details are needed.

Test

Test

Tag users in stale PR message

The template for the stale PR message and the attribute of the PR creator that is used in that message fails to properly tag the user. @udubnate figured out the right syntax and PR author property to use to make this work, and it's high time we implemented it 😁

User configured option to alert or add reviewers

This issue tracks the effort to alert/add PR reviewers when a PR is determined to be stale.

Teams Integration

This issue tracks the effort of integration with MS Teams. Cards that are sent to Teams from BroomBot to alert users of stale and abandoned ADO PRs with links to them for resolution/action.

Custom message for when a PR is abandoned

When a PR is abandoned, right now it just gets the normal "this PR is stale" message. Instead, there should be a more specific message about "we warned you, now this thing is getting toasted".

Possibility to execute commands

Hi I've a question.

Would it be possible to execute commands?

for instance, addressing the bot
@brombot ./deploy_ml_model

or just a comment in PR thread
./test_mymodel

Similar approach as to this repo

There the bot 'listens' to events (commands).

Thanks in advance!

Error In Azure Devops when a repository is disabled

I believe marking a repository as disabled breaks this function.

I noticed failures in the eventlog.xml due to unable to access a repository that does show up when running az repos list. However, this repository was marked disabled, and is breaking the GitHttpClient.GetRepositoriesAsync call.

</Data>.... Application: w3wp.exe
CoreCLR Version: 4.700.21.35901
.NET Core Version: 3.1.18
Description: The process was terminated due to an unhandled exception.
Exception Info: Microsoft.VisualStudio.Services.Common.VssServiceException: TF401019: The Git repository with name or identifier {REDACTED_GUID_HERE} does not exist or you do not have permissions for the operation you are attempting.
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.HandleResponseAsync(HttpResponseMessage response, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync(HttpRequestMessage message, HttpCompletionOption completionOption, Object userState, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync[T](HttpRequestMessage message, Object userState, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync[T](HttpMethod method, IEnumerable`1 additionalHeaders, Guid locationId, Object routeValues, ApiResourceVersion version, HttpContent content, IEnumerable`1 queryParameters, Object userState, CancellationToken cancellationToken)
   at BroomBot.BroomBotUtils.GetPullRequests(GitHttpClient gitClient, String project) in /home/vsts/work/1/s/BroomBot/BroomBotUtils.cs:line 24
   at BroomBot.SweepBroom.Run(TimerInfo myTimer, ILogger log).......

EDIT: Confirmed this is the issue. Now that I renabled the repo, the eventlog is correctly showing pull requests being processed.

I'd be fine if we could just have a disable app error log as a warning instead of a terminating error.

Repo filtering

Right now, all repos in a project are scanned for stale PRs. There should be a user configurable filter, or an check-only/exempt list of repos for controlling which repos in a project are scanned for stale PRs by BroomBot.

Apply a specific tag/label to stale PRs

Right now, BroomBot applies a label to PRs it deems are stale to track the warnings given to the PR owner. There should be a configurable option to apply a label like needs review or similar to stale PRs.

Pull Requests Draft Status Is Ignored

Just raising this up since I saw draft status is still getting Broombot alerts. Not sure yet where to add this in the code, but want to make sure it was captured as an issue for those that use Draft status.

Docs - Deployment & User Config

BroomBot is in need of a robust document that describes exactly how to deploy it. This depends on a streamlined deployment mechanism being completed.