The downloadlist from threadi

dashicons stylesheet not enqueued

I only noticed this when logged out (as dashicons is loaded when logged in), but the dashicons stylesheet is not enqueued after 6b024cb, as it's trying to enqueue downloadlist-dashicons, which doesn't exist.

As a workaround, I've set up that handle as an alias of dashicons:

wp_register_style('downloadlist-dashicons', false, ['dashicons']);

Use overridable templates for html-output

Currently, the HTML templates are fixed. This should be changed:

Create template to define the surrounding list.
Create template to define a list entry.
Implement the templates in such a way that they can be overwritten, e.g. by a child theme, in order to adapt the output.

Remove custom attachment title und description on uninstall

Remove custom attachment title und description on uninstall

Add custom title and description per file in block

Add the following way to add individual titles and descriptions to individual files in the list:

Edit the title of a file within the list and save it only in the list, not in the Media DB.
Description as well.

This would allow individual titles and descriptions per file. One could use the same files in several lists with different labels.

Add possibility to set icons for file-types

Find a way to assign an icon to each file type. Tasks to be done for this:

Which icons to choose from? Dashicons, FontAwesome?
Create an interface to manage the icons. Where?

Add possibility to load files from a given directory

Add a way to load and list files from a defined directory on the server instead of from the media database.

How to set the title and description of the file if they are not in the media database?
Add tab in Media-Choose-Popup to select the directory. Setting is saved on the block.
Add button to re-read the directory with a click.
Read out and display files in the directory.
Possibly make available as a separate plugin that connects to downloadlist, as it would considerably exceed the intended scope of functions.

Test compatibility with third-party-plugins

https://wordpress.org/support/plugin/download-monitor/

Attachments with MIME types that include a dot do not get a custom icon

For example, an attachment with MIME type application/vnd.openxmlformats-officedocument.spreadsheetml.sheet gets the following classes:

attachment-123
file_application
file_vnd.openxmlformats-officedocument.spreadsheetml.sheet

While the generated CSS selector is something like this:

.wp-block-downloadlist-list.iconset-dashicons .file_vnd.openxmlformats-officedocument.spreadsheetml.sheet:before {
    content: "\f495";
    font-family: "dashicons", sans-serif;
    font-size: 24px;
}

While the class that includes the "." is technically valid, the selector that's generated won't match it, as the browser will try and parse all the dots as a compound selector. To keep these class names but have the selector work, the dots in the class name would need to be escaped. I think ideally, the dots should not be used in the class names at all.

I've worked around this myself for now by replacing the dots with underscores via your filters, and then fixing them on the frontend by hoking the attribute_escape function:

/**
 * Convert dots to underscores in all mime types
 */
add_filters(
    ['downloadlist_dashicons_icons', 'downloadlist_bootstrap_icons', 'downloadlist_fontawesome_icons'],
    function ($dashicons) {
        return array_combine(
            str_replace(
                '.',
                '_',
                array_keys($dashicons)
            ),
            $dashicons
        );
    }
);

/**
 * Do the same conversion for the frontend output
 */
add_filter('attribute_escape', function ($safe_text, $text) {
    if (strpos($safe_text, 'vnd') === 0 && strpos($safe_text, '.') !== false) {
        return str_replace('.', '_', $safe_text);
    }

    return $safe_text;
}, 10, 2);

Add PDF thumbnail

Hi,
I have a used case where I need to display thumbnail for each file.
I have made my own version of your plugin for that.
This is what the result looks like http://typomet.re/i/rFmpp1

I don't have the skills and knowledge in Js, webpack, react and all so I only changed the php for the output and managed to add controls to hide thumbnail and filename based on the finished and deployed plugin files. So the block in gutenberg is unchanged, from you version, only the new controls are added.
I use the pdf thumbnail Wordpress provides when the servers as imagemagick and ghostscript. It shows file icon when there is no such thumbnail.
Ultimately i would like to add the possibility to choose a specific image to act as the thumbnail.

What I ve done is dirty but meets my need and in case you would like to evolve your plugin I could send you my version. I didn't know how to use webpack or the build process required so I can't really make a proper fork and Pull request.
Best regards.

Set default settings for all blocks of this plugin (e.g. hide things) incl. auto-update them in one task

Find a way to make this option possible:

Where to place this option?
Provide a form with the options of the block, which searches all posts and pages with a click and sets the settings on the blocks there.
WP-Cron to set the defined settings.

threadi / downloadlist Goto Github PK

downloadlist's Introduction

Download List with Icons

Usage

Test

Release

Translations

generate pot-file

update translation-file

export translation-file

generate json-translation-files

Build blocks

Requirements

Run for development

Run for release

Check for WordPress Coding Standards

Initialize

Run

Repair

Generate documentation

downloadlist's People

Contributors

Stargazers

Watchers

downloadlist's Issues

Recommend Projects

Recommend Topics

Recommend Org