threetwosevensixseven/ayfxedit-improved

AYFX Editor (Improved)

ayfxedit-improved's Issues

Loading AFX files with 'file association' doesn't work

Various AFX files I tried loading with file association loaded corrupt but if you load them with the File-Load Current Effect they work.

corrupt

proper

Bug in ayfxplay.a80

In line:
133 ld b,#ff
134 ld b,c ;в BC заносим наибольшее время
maybe
ld c, b ?

Overrun in ayfxplay.a80

On line 45:
ld bc,#0cfd
'b' holds the loop counter and the loop initializes 4 bytes at a time for a total of 4 * 12 bytes. My guess is this line should be:
ld bc,#03fd
4 * 3 = 12 bytes which is the size of the data reserved for afxChDesc.

Missing library (rtl250.bpl)

The provided .exe doesn't seem to work; the error message says rtl250.bpl is missing.
May be a run-time library ("rtl") from Embarcadero (that should be distributed along the .exe)?

I'm running Windows 10 (version 1803, compilation 17134.228) and it is a relatively clean install.

Thanks!

BaseNote computation is wrong for Octave

Basenote is supposed to be set to C-5 (Note=0, Octave=5), Octaves for Vortex tracker are between 1 and 8.

thus, basenote should range between 112+0=12 and 812+11=103

in UnitVT2Instrument.cpp, TFormVortexExp::FormCreate
Basenote is initialized to Basenote =5*12;

in export_vt2.h
offset array is computed with octaves ranging between 0 and 7 !

when you grab the value offset[base], with base=basenote, you actually take the offset for C-6.
indices of index are ranging from 0 to 91

offset should be computed like this instead : offset[base-12]

noise sub #20

ayfxedit-improved/zeusexample/ayfxplay.asm

Line 203 in e732307

sub $20

sub #20 is used to check if it is the end of the effect, then that decreased value is sent to AY. Is this correct? I do not see that a noise period stored in the SFX data was initially increased by #20 to compensate for that "sub #20" operation.