thwjason/hyf-javascript2

HYF Javascript 2

hyf-javascript2's Issues

Feedback homework JS2 Week 3

Hi Jason, here is my feedback on your homework.

I see lot's of similarity between your work and the work of others. Since they submitted earlier you must have been 'inspired' by their work. Please don't copy.

Although it may seem handy to have the assignment in comments in your code, this is what I commented on Kemirdin's work:

You should not leave old, commented out code in your repo. Just as you should not leave crossed-out text in your CV. Remember I'm your reviewer. Your next reviewer may be your potential boss.

Step 4.1

OK

Step 4.2

I think this is the result of work we did together. Needles to say that it works.

Step 4.3

When I try to run this I get a run-time error:

/Users/jimcramer/hackyourfuture/class13/js2/week3/jason/Week3/4-3.js:29
    console.log("Function using 'for' loop: " + newString);
                                                ^

ReferenceError: newString is not defined

How did you run it?

I've seen this code before in the homework of Elmira (without the errors).

Step 4.4

OK

Step 4.5

Looks like Elmira's work

Step 4.7

Conclusion is correct.

Step 5

Look's like Anan's work.

Bonus

Looks like Kenan's work

mahmut`s feedback

Hi Jason, just use 'map' and 'filter' for this homework as Jim said. but in general it looks better than mine. good job!

about book home work

hi Jason, I think it 's better write
// const root = document.getElementById("root"); // before the for loop.
and write
// const unorderedList = document.createElement("ul");
root.appendChild(unorderedList);
const li = document.createElement('li');
unorderedList.appendChild(li);//
and the other HTML to JS codes in the for loop.
good luck !