tidymodels/modeldb

Run models inside a database using R

modeldb's Issues

MSSQL - Kmeans case_when fails

The boolean expression in the case_when() translations fail on a MS SQL back end.

Possibly related to this issue: tidyverse/dbplyr#148

Match outputs with broom tidiers?

Just was taking a look at the kmeans tidier!

Would it make sense to match outputs up with the broom tidiers to the degree possible for consistency within tidyverse / db universe? Or to provide augment(), glance() and tidy() methods for database models?

Move `master` branch to `main`

The master branch of this repository will soon be renamed to main, as part of a coordinated change across several GitHub organizations (including, but not limited to: tidyverse, r-lib, tidymodels, and sol-eng). We anticipate this will happen by the end of September 2021.

That will be preceded by a release of the usethis package, which will gain some functionality around detecting and adapting to a renamed default branch. There will also be a blog post at the time of this master --> main change.

The purpose of this issue is to:

• Help us firm up the list of targetted repositories
• Make sure all maintainers are aware of what's coming
• Give us an issue to close when the job is done
• Give us a place to put advice for collaborators re: how to adapt

message id: euphoric_snowdog

Upkeep for modeldb (2023)

Pre-history

• usethis::use_readme_rmd()
• usethis::use_roxygen_md()
• usethis::use_github_links()
• usethis::use_pkgdown_github_pages()
• usethis::use_tidy_github_labels()
• usethis::use_tidy_style()
• usethis::use_tidy_description()
• urlchecker::url_check()

2020

• usethis::use_package_doc()
  Consider letting usethis manage your @importFrom directives here.
  usethis::use_import_from() is handy for this.
• usethis::use_testthat(3) and upgrade to 3e, testthat 3e vignette
• Align the names of R/ files and test/ files for workflow happiness.
  The docs for usethis::use_r() include a helpful script.
  usethis::rename_files() may be be useful.

2021

• usethis::use_tidy_dependencies()
• usethis::use_tidy_github_actions() and update artisanal actions to use setup-r-dependencies
• Remove check environments section from cran-comments.md
• Bump required R version in DESCRIPTION to 3.6
• Use lifecycle instead of artisanal deprecation messages, as described in Communicate lifecycle changes in your functions
• Make sure RStudio appears in Authors@R of DESCRIPTION like so, if appropriate:
  person("RStudio", role = c("cph", "fnd"))

2022

• usethis::use_tidy_coc()
• Handle and close any still-open master --> main issues
• Update README badges, instructions in r-lib/usethis#1594
• Update errors to rlang 1.0.0. Helpful guides:
  https://rlang.r-lib.org/reference/topic-error-call.html
  https://rlang.r-lib.org/reference/topic-error-chaining.html
  https://rlang.r-lib.org/reference/topic-condition-formatting.html
• Update pkgdown site using instructions at https://tidytemplate.tidyverse.org
• Ensure pkgdown development is mode: auto in pkgdown config
• Re-publish released site; see How to update a released site
• Update lifecycle badges with more accessible SVGs: usethis::use_lifecycle()

2023

Necessary:

• Update email addresses *@rstudio.com -> *@posit.co
• Update copyright holder in DESCRIPTION: person(given = "Posit Software, PBC", role = c("cph", "fnd"))
• Run devtools::document() to re-generate package-level help topic with DESCRIPTION changes
• Double check license file uses '[package] authors' as copyright holder. Run use_mit_license()
• Update logo (https://github.com/rstudio/hex-stickers); run use_tidy_logo()
• usethis::use_tidy_coc()
• usethis::use_tidy_github_actions()

Optional:

• Review 2022 checklist to see if you completed the pkgdown updates
• Prefer pak::pak("org/pkg") over devtools::install_github("org/pkg") in README
• Consider running use_tidy_dependencies() and/or replace compat files with use_standalone()
• use_standalone("r-lib/rlang", "types-check") instead of home grown argument checkers
• Add alt-text to pictures, plots, etc; see https://posit.co/blog/knitr-fig-alt/ for examples

^{Created on 2023-10-31 with usethis::use_tidy_upkeep_issue(), using usethis v2.2.2}

modeldb::linear_regression_db invalid operation

I am trying to run a model remotely with the 'linear_regression_db' function from the modeldb package. but am getting the following error:

This is being done via a connection to Amazon Redshift (which is based on postgresql 8.4) and maintained at the most up to date version. I have tried changing the JDBC driver to the latest version as well and still relieve the same error. I notice that it refers to the SQL count function - "(Amazon Invalid operation: function count() does not exist;)" , but am not sure what to make of this.

Thanks.

Release modeldb 0.3.0

Prepare for release:

• git pull
• Check current CRAN check results
• Polish NEWS
• urlchecker::url_check()
• devtools::build_readme()
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• revdepcheck::cloud_check()
• Update cran-comments.md
• git push
• Draft blog post
• Slack link to draft blog in #open-source-comms

Submit to CRAN:

• usethis::use_version('minor')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• Add preemptive link to blog post in pkgdown news menu
• usethis::use_github_release()
• usethis::use_dev_version(push = TRUE)
• Finish blog post
• Tweet

Release modeldb 0.2.3

Prepare for release:

• Check current CRAN check results
• Polish NEWS
• devtools::build_readme()
• urlchecker::url_check()
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• rhub::check_for_cran()
• revdepcheck::cloud_check()
• Update cran-comments.md

Submit to CRAN:

• usethis::use_version('patch')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• usethis::use_github_release()
• usethis::use_dev_version()

Fix build badge on README

Add `parsnip` interface

linear_reg() %>%
  set_engine("modeldb-lr") %>%
  fit_xy(mpg, wt, data = mtcars)

[Feature Request] Standardizing variables

Hi,
Wondering if simple_kmeans_db uses standardized variables. If not is it possible to include an option to standardize variables when calling simple_kmeans_db?

Thanks

Improve kmeans query

In the query, pass the actual center numbers as a column rather than the formula

simple_kmeans_db() relies on a right join which is not supported by SQLite

When using simple_kmeans_db() with a database connection, it relies on a right join. However, right joins (and also full outer joins) are not supported in SQLite (see documentation here), which is used to create the necessary query.

Error generated when attempting to use simple_kmeans_db() with a db con:

Query generated from same model (can see right join about halfway down):

The code will need to be refactored likely to use a left join instead, as that's supported by SQLite. Alternatively, another SQL database engine could be attempted.