tifmoe/go-fishbowl

Go + React web app to play FishBowl remotely:

go-fishbowl's Issues

GetGame called before gameID exists

When starting a new game (on the home page, after typing in team names), the following error always shows up:

This is being caught here (line 70):

go-fishbowl/src/repository/store.go

Lines 67 to 72 in 2859b56

	func (c conn) GetGame(gameID string) (game *Game, err error) {
	data, err := c.Client.Get(gameID).Result()
	if err != nil {
	fmt.Printf("Game %s does not exist: %v\n", gameID, err)
	return game, err
	}

After doing some digging, I found that in Repository.SaveNewGame, GetGame is called before the gameID is set:

go-fishbowl/src/repository/store.go

Lines 35 to 65 in 2859b56

	func (c conn) SaveNewGame(gameID, team1, team2 string) error {
	exists, _ := c.GetGame(gameID)
	if exists != nil {
	err := fmt.Errorf("failed to save: game %s already exists", gameID)
	return err
	}
	game, err := json.Marshal(Game{
	ID: gameID,
	Teams: Teams{
	Team1: Team{
	Name: team1,
	},
	Team2: Team{
	Name: team2,
	},
	},
	})
	if err != nil {
	fmt.Printf("Error marshalling new game %s: %v\n", gameID, err)
	return err
	}
	err = c.Client.Set(gameID, game, ttl).Err()
	if err != nil {
	fmt.Printf("Error saving game %s: %v\n", gameID, err)
	return err
	}
	return nil
	}

GetGame is trying to access GameID here:

go-fishbowl/src/repository/store.go

Line 36 in 2859b56

exists, _ := c.GetGame(gameID)

but it is not being set util here:

go-fishbowl/src/repository/store.go

Line 59 in 2859b56

err = c.Client.Set(gameID, game, ttl).Err()

.

GetGame is called again when the GamePage is loaded here:

go-fishbowl/ui/src/pages/Game.js

Lines 61 to 67 in f9d1865

	componentDidMount() {
	const { params: { gameId } } = this.props.match;
	axios({
	method: 'get',
	url: `/v1/api/game/${gameId}`,
	timeout: 4000, // 4 seconds timeout
	})

But the error no longer prints to the console because by then the gameID is already set. So we have a situation where GetGame is being called twice in a row with different behavior.