timmisiak/dbgrs

A windows debugger written in Rust, for educational purposes

dbgrs's Issues

Do not parse buffers as strings.

dbgrs/src/main.rs

Line 11 in 43c0c3e

fn parse_command_line() -> *mut u16 {

Parsing the cmdline as if it was a buffer C style is a bad idea and it leads to the kind of bugs C leads to.

Import it as an OsString or &OsStr first and find a sensible way to parse from there safely.

use std::ptr::null; rather than ptr;

dbgrs/src/main.rs

Line 7 in 43c0c3e

use std::ptr;

Since you don't have any other symbol called null in the main namespace, importing std::ptr::null; makes more sense.

expect_step_exception is thread-specific

Setting expect_step_exception should be thread-specific, because the step command modifies the context of a particular thread, and expects that thread to trap after running the instruction. Setting expect_step_exception to true and then ignoring an exception from a different thread is a debugger bug, unless I'm missing something.