tinkertanker/pxt-rotary-encoder-ky040

Tinkercademy MakeCode package for using the KY-040 rotary encoder with the BBC micro:bit

pxt-rotary-encoder-ky040's Issues

Add icon.png

Add a icon.png image in the root folder. It will be used when displaying the package in the "Add package" dialog.

Compatibility with micro:bit v2

Hi @tinkertanker,

As you might have seen from microsoft/pxt-microbit#3506 this extension is currently not compiling against the latest version of Micro:bit CODAL. This means it will not work with micro:bit V2.

Software for micro:bit V2 boards is built using CODAL rather than the DAL, and no longer includes the mbed layer. We’ve implemented the most frequently used mbed classes to support easy porting of existing extensions, but there may still be corner cases with this compatibility layer.

As your extension is currently not building, it will be disabled for micro:bit V2. People attempting to use your extension with a micro:bit V2 board will get error 929. This extension will only be re-enabled on micro:bit V2 once it is fixed.

There are details on how to ensure extensions work on both version of the micro:bit here (lancaster-university/codal-microbit-v2#31).

Looking at your extension source I believe that your extension falls under this category:

1. Use of mbed APIs that are in the compatibility layer, but no inclusion of mbed.h

/home/build/prjclone/pxtapp/ky040/ky040.cpp:3:9: error: 'vector' does not name a type
 typedef vector<Action> vA;
         ^~~~~~
/home/build/prjclone/pxtapp/ky040/ky040.cpp:31:25: error: 'InterruptIn' does not name a type
 uint32_t lri = 0, lbi=0;InterruptIn *ri; DigitalIn *dv, *dsw; Timer tsb; vA leftRotate, rightRotate, pressRotate;
                         ^~~~~~~~~~~
/home/build/prjclone/pxtapp/ky040/ky040.cpp:31:42: error: 'DigitalIn' does not name a type
 uint32_t lri = 0, lbi=0;InterruptIn *ri; DigitalIn *dv, *dsw; Timer tsb; vA leftRotate, rightRotate, pressRotate;
                                          ^~~~~~~~~
/home/build/prjclone/pxtapp/ky040/ky040.cpp:31:69: error: no matching function for call to 'codal::Timer::Timer()'
 uint32_t lri = 0, lbi=0;InterruptIn *ri; DigitalIn *dv, *dsw; Timer tsb; vA leftRotate, rightRotate, pressRotate;

020 crash in MakeCode v2 and MakeCode beta (06.08.20)

This program crashes when the encoder is turned rapidly left or right.

https://makecode.microbit.org/_TqjJ4m2pV3Xc

MakeCode Compatibility

When I use MakeCode and add this module, my project doesn't seem to put thing in the order the readme intends. the init code is placed after the events code. I'm not sure if this is really my problem, but I can't get any events to fire that make sense.