tir38/android-buddybuild

[DEPRECATED] A BuddyBuild client for Android

android-buddybuild's Issues

Remove Lombok

Either migrate back to plain old getters/setters or migrate to Kotlin

Make up my mind about Assert-J Android vs Truth

We are currently using Assert-J for junit assertions. As we add robolectric tests it would be nice to add some "android specific" assertion library. I'm on the fence about Assert-J Android vs Truth. Assert-J Android was recently deprecated, but Truth is just huge (includes Guava).

Queued time not showing if currently in queue

Here is a build that is being queued.

However app shows no "queued for" time. I suspect this would be the same for "started" and "build duration" too.

SocketTimeout when fetching many branches

On main screen we fetch builds for each branch. If a repo has many branches, this eventually times out.

The solution is to return each branch to the UI one at a time and perhaps lazy load more as the user scrolls.

java.lang.IllegalArgumentException: Comparison method violates its general contract

com.buddybuild.debug E/BuildsFragment$$Lambda: java.lang.IllegalArgumentException: Comparison method violates its general contract!
                                                                                  at java.util.TimSort.mergeLo(TimSort.java:777)
                                                                                  at java.util.TimSort.mergeAt(TimSort.java:514)
                                                                                  at java.util.TimSort.mergeCollapse(TimSort.java:441)
                                                                                  at java.util.TimSort.sort(TimSort.java:245)
                                                                                  at java.util.Arrays.sort(Arrays.java:1498)
                                                                                  at java.util.ArrayList.sort(ArrayList.java:1470)
                                                                                  at java.util.Collections.sort(Collections.java:201)
                                                                                  at com.buddybuild.ui.BuildsFragment.lambda$setApp$0$BuildsFragment(BuildsFragment.java:121)
                                                                                  at com.buddybuild.ui.BuildsFragment$$Lambda$0.apply(Unknown Source:0)
                                                                                  at io.reactivex.internal.operators.single.SingleMap$MapSingleObserver.onSuccess(SingleMap.java:57)
                                                                                  at io.reactivex.internal.operators.single.SingleDoOnSuccess$DoOnSuccess.onSuccess(SingleDoOnSuccess.java:59)
                                                                                  at io.reactivex.internal.operators.observable.ObservableToListSingle$ToListObserver.onComplete(ObservableToListSingle.java:113)
                                                                                  at io.reactivex.internal.operators.observable.ObservableFlatMap$MergeObserver.drainLoop(ObservableFlatMap.java:367)
                                                                                  at io.reactivex.internal.operators.observable.ObservableFlatMap$MergeObserver.drain(ObservableFlatMap.java:323)
                                                                                  at io.reactivex.internal.operators.observable.ObservableFlatMap$InnerObserver.onComplete(ObservableFlatMap.java:579)
                                                                                  at io.reactivex.internal.observers.BasicFuseableObserver.onComplete(BasicFuseableObserver.java:119)
                                                                                  at io.reactivex.internal.operators.single.SingleToObservable$SingleToObservableObserver.onSuccess(SingleToObservable.java:60)
                                                                                  at io.reactivex.internal.operators.single.SingleMap$MapSingleObserver.onSuccess(SingleMap.java:64)
                                                                                  at io.reactivex.internal.operators.observable.ObservableSingleSingle$SingleElementObserver.onComplete(ObservableSingleSingle.java:111)
                                                                                  at io.reactivex.internal.operators.observable.ObservableSubscribeOn$SubscribeOnObserver.onComplete(ObservableSubscribeOn.java:68)
                                                                                  at retrofit2.adapter.rxjava2.CallExecuteObservable.subscribeActual(CallExecuteObservable.java:47)
                                                                                  at io.reactivex.Observable.subscribe(Observable.java:10903)
                                                                                  at io.reactivex.internal.operators.observable.ObservableSubscribeOn$SubscribeTask.run(ObservableSubscribeOn.java:96)
                                                                                  at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:452)
                                                                                  at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:61)
                                                                                  at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:52)
                                                                                  at java.util.concurrent.FutureTask.run(FutureTask.java:266)
                                                                                  at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
                                                                                  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
                                                                                  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
                                                                                  at java.lang.Thread.run(Thread.java:764)