tirupati17/currency-converter-swift3.0-viper

Calculates money quick and easy way to see live foreign exchange rates (Based on swift 4.2, viper architecture and special thanks to https://github.com/hakanensari/fixer-io for conversion API)

currency-converter-swift3.0-viper's Issues

Add NTD

Suggestion, add NTD (New Taiwanese Dollar) to list of currencies as it seems to have been not included in the App as well.

Add More Countries

the api only has few bunch of countries, can the api support other currencies.

Doesn't work

The problem is linked with podfile - when I try to run pod install - I get:

[!] Error installing Crashlytics
[!] /usr/bin/curl -f -L -o /var/folders/sy/4_wxmzmj75j733p9k30rms7d7rjblp/T/d20170622-2535-12kcl4p/file.zip https://kit-downloads.fabric.io/cocoapods/crashlytics/3.8.4/crashlytics.zip --create-dirs --netrc-optional

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (35) SSL peer handshake failed, the server most likely requires a client certificate to connect

Why do you use crashlytics at all in this project?

json error

i have this error

Call can throw, but it is not marked with 'try' and the error is not handled
let jsonObject = JSON(data: response.data!)

Alamofire.request("http://api.fixer.io/latest?base=\(baseCurrencyCode)").responseJSON { response in print(response.request?.description) if response.result.isSuccess { let jsonObject = JSON(data: response.data!) completion?(jsonObject as AnyObject) } else { failed?(response.result.error as AnyObject) } } }