tizian/tonemapper

A tool for exploring and applying various tonemapping operators.

tonemapper's Issues

Reasoning for -stdlib=libc++ flag?

I'm building your project on Linux and noticed you've got -stdlib=libc++ in CMakeLists.txt#L14.

Reading your README.md, I'm assuming you're developing on MacOS, which seems to be backed up by this stackoverflow reply.

I'm not that familiar with CMAKE or clang, so I was wondering if there a reason that you're explicitly specifying it against the advice of this SO answer?

I hope to support the PNG image format of regular RGBA32 and compile it into an .a static library using mingw32

I hope to support the PNG image format of regular RGBA32 and compile it into an .a static library using mingw32
thank you

Incorrect arguments used in ReinhardDevlinOperator::setParameters

I'm not sure about this one since I'm not that familiar with the algorithm, but this looks wrong to me:
parameters["Iav_r"] = Parameter(image->getAverageIntensity().r(), "Iav_r"); parameters["Iav_g"] = Parameter(image->getAverageIntensity().r(), "Iav_g"); parameters["Iav_b"] = Parameter(image->getAverageIntensity().r(), "Iav_b");

It uses the red-channel of the average intensity for all three parameters, I assume it should be r(), g() and b() respectively?

Small typo on an author name.

The presenter of "HDR Theory and Practice" is Hajime Uchimura.

command mode

Well, this is a very useful tool! But as a lazy user, I will be glad to use a command line to batch process many exr files. For example "tonemapper.exe --input_path --output_name --operator "
Just a suggestion!~

Unkonwn option "--Lwhite" when using clamping operator

Looking at the source for the clamping operator, it seems like --Lwhite should work as an argument. However, when I try to use it I am getting an error.

$ tonemapper --no-gui --operator clamping --Lwhite 0.01 master.hdr

Chosen operator:
    "Clamping"
    Clamps everything above a given luminance threshold to 
    1. Discussed in "Quantization Techniques for 
    Visualization of High Dynamic Range Pictures" by 
    Schlick 1994. 

Operator specific parameters:
  --gamma  Gamma correction value. 
           (Default: 2.2)



Unkonwn option "--Lwhite"

I'm on an M2 MacBook Air

Small typo in README.md

The second "Hill ACES" should be "Guy ACES".

How to move the image

I tried this app a while back and find it very nice. WHen i open an image i just see a small section and i cant move it around. Im using the last version 1.1 on osx 10.11.6

However i tried it again today and noticed i could not open an HDR image saved from my render engine. It does allow me to open the exr files.

Changes to support more operator types

It would be interesting to refactor the existing code to be more flexible:

• Add mappings that differs for R,G,B channels, to support e.g. the ACES fit by Stephen Hill: https://github.com/TheRealMJP/BakingLab/blob/master/BakingLab/ACES.hlsl

• Add option to load data-driven curves from text files as described in https://64.github.io/tonemapping/, e.g. to load in actual camera response functions