Giter Site home page Giter Site logo

Comments (2)

tjmoses avatar tjmoses commented on July 18, 2024 1

Since this library is dealing with State, only comparison of keys within the object should ever be considered whether that's with natural, surrogate, or composite keys. I implemented basic keys within strings (natural and surrogate), but do think composite keys would be nice. Additional checks would be introducing side-effects, and limiting those is best.

I don't think a matcher function is beneficial to everyone in the sense that most would not provide this and if they are writing a basic matcher function, they probably already know what they want to compare and won't use this library. Although, you bring up a valid point in that composite keys should be implemented.

I would be open to adding that in with an additional array argument of keys vs the single that exists. Also, from your PR using indexOf is faster than several other methods and why I used it. I mean I can make it extremely short with 100% ES6+ code, but I was concerned with performance and speed. Anyways, if you want to implement something that can take a given list of composite keys to check I'm game. Thanks for your input!

from crud-compare.

avrahamcool avatar avrahamcool commented on July 18, 2024

OK. understood.

from crud-compare.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.