[improvement] better key finding

[tjmoses]

[improvement] better key finding

[tjmoses]

On my prior comment about performance, I was speaking to not adding in additional function calls from your PR due to performance issues it would incur. Yes, performance in general is nice but people can go overboard with it as well.

Good call though, and I agree that using an Object, Map, or even Array with basic given keys would be faster. Although, if there were more complex common key values that were say other Objects/Arrays, there might be trouble iterating on the logic later. In addition, I would assume the browser hashes everything in memory for very quick look-ups with arrays even w/o good sorting. Also, you could get away with just creating a single object for the key value truthy check along with a boolean for the deleted val check. There are several ways of doing this.

Yes, local variables help as well for additional calls. There are several additional performance factors, another quick one I see would be converting to while loops. I may opt for using the google closure compiler to automate most minute performance fixes in the future.

I will take your thoughts into consideration for the next release which will probably have updates for deep object checks as well.

Thanks!