tlater/elytrant

elytrant's Issues

Various vanilla and BYG biomes do not generate

Terraforged only generates a handful of biomes. Crucially, the swamp biome, which is required for the Hexerei mod, does not generate, but this also means a number of wood types are very hard to acquire.

Squids do not spawn under normal conditions

An extremely bizarre bug caused by terraforged. Squid do seem to spawn in worlds using normal world gen, just not when terraforged's world gen is used.

I wonder if the ocean/river biomes used by terraforged are not the vanilla ones, and therefore somehow don't spawn squid.

This only applies to non-glow squid. Glow squid spawn fine, but they are allowed to spawn in any biome.

Vanilla cave update caves do not generate

This means that, generally, caves do not generate below y = 0 (except for some small dips below this, down to ~-10) and most 1.18 underground biomes simply do not appear.

This causes rare ores to practically not generate in caves, making strip mining the only feasible way of obtaining ore, except for the occasional mineshaft.

Figure out how to remove the remaining two guide books

There are still two guide books that end up in the player's inventory.

Various textures are too big

This mostly affects tinker's construct and Sophisticated storage; A variety of the icons (largely added by the texture pack) render far too big on blocks.

Unsure whether this is caused by the texture pack or something else.

Add a per-mob mob griefing mod

To allow e.g. villagers to pick up crops, and snow golems to leave snow trails.

Something like: https://www.curseforge.com/minecraft/mc-mods/better-mobgriefing-gamerule

Quark building tweaks allows placing blocks in other players' chunks

Upstream issue: VazkiiMods/Quark#3638

Fluids from tinker's construct do not render

This is caused by a bug in oculus: Asek3/Oculus#105.

Neptunium boots don't add any swim speed

Exotic Birds spawn in the Twilight Forest again

We'd previously configured them not to, but this seems to have broken.

Possibly the config wiped when we removed Mana & Artifice or such? Either way need to check this with Johan.

Inventory pop-up is too easy to trigger accidentally

A few players have accidentally brought up the inventory backdrop added by the inventory HUD mod now, with no idea how to disable it again.

We should un-bind that key by default, nobody actually uses it (and quark adds a better one).

Worldgen causes crash near spawn

When generating a chunk near -800, 50, the following crash occurs:

[16:09:15] [Server thread/ERROR] [minecraft/MinecraftServer]: Encountered an unexpected exception
net.minecraft.ReportedException: Exception ticking world
	at net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:906) ~[client-1.18.2-20220404.173914-srg.jar%23190!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin,pl:mixin:APP:chunkpregen.mixins.json:common.server.MinecraftServerMixin,pl:mixin:APP:terrablender.mixins.json:MixinMinecraftServer,pl:mixin:APP:byg.mixins.json:access.MinecraftServerAccess,pl:mixin:APP:byg.mixins.json:server.MixinMinecraftServer,pl:mixin:A}
	at net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:842) ~[client-1.18.2-20220404.173914-srg.jar%23190!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin,pl:mixin:APP:chunkpregen.mixins.json:common.server.MinecraftServerMixin,pl:mixin:APP:terrablender.mixins.json:MixinMinecraftServer,pl:mixin:APP:byg.mixins.json:access.MinecraftServerAccess,pl:mixin:APP:byg.mixins.json:server.MixinMinecraftServer,pl:mixin:A}
	at net.minecraft.client.server.IntegratedServer.m_5705_(IntegratedServer.java:84) ~[client-1.18.2-20220404.173914-srg.jar%23190!/:?] {re:classloading,pl:runtimedistcleaner:A,re:mixin,pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:685) ~[client-1.18.2-20220404.173914-srg.jar%23190!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin,pl:mixin:APP:chunkpregen.mixins.json:common.server.MinecraftServerMixin,pl:mixin:APP:terrablender.mixins.json:MixinMinecraftServer,pl:mixin:APP:byg.mixins.json:access.MinecraftServerAccess,pl:mixin:APP:byg.mixins.json:server.MixinMinecraftServer,pl:mixin:A}
	at net.minecraft.server.MinecraftServer.m_177918_(MinecraftServer.java:261) ~[client-1.18.2-20220404.173914-srg.jar%23190!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:balm.mixins.json:MinecraftServerMixin,pl:mixin:APP:chunkpregen.mixins.json:common.server.MinecraftServerMixin,pl:mixin:APP:terrablender.mixins.json:MixinMinecraftServer,pl:mixin:APP:byg.mixins.json:access.MinecraftServerAccess,pl:mixin:APP:byg.mixins.json:server.MixinMinecraftServer,pl:mixin:A}
	at java.lang.Thread.run(Thread.java:833) [?:?] {re:mixin}
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 24 out of bounds for length 24
	at net.minecraft.world.level.chunk.ChunkAccess.m_183278_(ChunkAccess.java:151) ~[client-1.18.2-20220404.173914-srg.jar%23190!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:byg.mixins.json:access.ChunkAccessAccess,pl:mixin:APP:byg.mixins.json:common.world.MixinChunkAccess,pl:mixin:A}
	at com.terraforged.mod.worldgen.util.ChunkUtil.fillChunk(ChunkUtil.java:114) ~[TerraForged-1.18.2-0.3.1-alpha-2.jar%23181!/:?] {re:classloading}
	at com.terraforged.mod.worldgen.Generator.lambda$fillFromNoise$4(Generator.java:189) ~[TerraForged-1.18.2-0.3.1-alpha-2.jar%23181!/:?] {re:classloading}
	at com.terraforged.mod.worldgen.terrain.TerrainCache.lambda$combineAsync$0(TerrainCache.java:91) ~[TerraForged-1.18.2-0.3.1-alpha-2.jar%23181!/:?] {re:classloading}
	at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:646) ~[?:?] {}
	at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?] {}
	at net.minecraft.server.level.ChunkTaskPriorityQueueSorter.m_143188_(ChunkTaskPriorityQueueSorter.java:62) ~[client-1.18.2-20220404.173914-srg.jar%23190!/:?] {re:classloading}
	at net.minecraft.util.thread.ProcessorMailbox.m_18759_(ProcessorMailbox.java:91) ~[client-1.18.2-20220404.173914-srg.jar%23190!/:?] {re:classloading}
	at net.minecraft.util.thread.ProcessorMailbox.m_18747_(ProcessorMailbox.java:146) ~[client-1.18.2-20220404.173914-srg.jar%23190!/:?] {re:classloading}
	at net.minecraft.util.thread.ProcessorMailbox.run(ProcessorMailbox.java:102) ~[client-1.18.2-20220404.173914-srg.jar%23190!/:?] {re:classloading}
	at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1395) ~[?:?] {}
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}
	at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}
	at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {re:computing_frames}
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {re:computing_frames}
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {}

Terraforged is implicated in this, but has not conclusively been proven the culprit.

Create a non-terraforged dimension

To work around #6, #7 and #8, we're considering the solution of creating a new dimension with default world gen.

This is very possible using some datapack settings. The only problems are:

• How do we teleport there?
  • A simple command block at spawn with a pressure plate on it could do the trick.
    • Feels a bit cheaty.
  • Custom portals are apparently possible, but nontrivial. Looking into others' solutions for this.
• How do we keep people from wanting to live there?
  • Desirable because otherwise the overworld will become too sparsely populated, and megaprojects much less practical.
  • We could:
    • Make beds blow up
    • Keep it night constantly
    • Something else?