SQL insert with Guid or Assigned KeyType

[tmsmith]

SQL insert with Guid or Assigned KeyType

[garyhuntddn]

I thought a bit more about this last night - maybe what would be better would be to have a KeyType of Immutable - as that's essentially what's going on here. My comment above about it being WriteOnly isn't correct, it's WriteOnce.

I've also just added some concurrency checking by including a RowVersion column as a KeyType which works really nicely - it's not actually a key but the effect on the SQL generated was exactly what I wanted.

[aboy021]

I'm experiencing a closely related issue.
Under replication using sql server, I've been getting an error:

Failed to update database System.Data.SqlClient.SqlException (0x80131904): Updating columns with the rowguidcol property is not allowed.

If the primary key of the table is a Guid, then update should not try to update it.
This could be resolved by changing the appropriate line in SqlGenerator.Update to

var columns = classMap.Properties.Where(p => !(p.Ignored || p.IsReadOnly || p.KeyType == KeyType.Identity || p.KeyType == KeyType.Guid));

[garyhuntddn]

Tim - if I put together a pull request for this would you consider approving it? I'm using it in my own branch but wondered if it's something you'd consider for core?

Due to the way that DE creates it's parameter list for the update statement it never creates multiple parameters for items in the fields to be updated and the fields for the where - therefore we can safely say that nothing in the where clause for a single entity update should be updated.

My fix is to use:

var columns = classMap.Properties.Where( p => !( p.Ignored || p.IsReadOnly) && p.KeyType == KeyType.NotAKey ) );

Is there ever a scenario where updating a primary key is likely? The only time I can think of is if the PK is not abstract, such as a String or DateTime but even then any FK relationship is guaranteed to fail.