toastwallet/core

This repo contains the core code for Toast Wallet. It is built for iOS, Android and browser directly from this repository. PC builds are built from the browser version using Electron.

core's Issues

Restore backup should offer to scan a QR code

On the mobile app, I see the option to scan the QR code for the secret, but not for "Restore an existing backup wallet", e.g. I created a wallet from the desktop, it would be nice from the desktop app to be able to show that long json as a QR image to scan, and from the mobile app scan it to have restore the backup on mobile.

Copy pasting the backup to a phone, using email or other sharing services or whatever is not really secure. Also to backup from the phone should offer the option to scan a QR, so from a desktop PC (maybe airgapped, for extra security) with a webcam a user could scan the code from there and safely paste the backup code in a safe place.

Maybe this relates to #16 a bit.

Trailing zeros destination tag fails

If I try to use a valid destination tags that includes trailing zeros, it fails:

Forced Fullscreen Mode

Hey guys, great app! Can you guys reconsider fullscreen mode on the Android app? It is really clunky right now because the navigational buttons are hidden until you swipe up from the bottom of the screen. Swiping up from the bottom of the screen causes one of the tab actions to be executed due to the 'on down event' rather than the Android standard 'on up event'.

This is likely due to stock Cordova logic causing any touch event to trigger an 'on click' event. Anyway, it seems the app would work fine in a non-fullscreen mode fashion.

Backup code toast wallet, XRP

Hello please, I have my pass phrase and recovery phrase, but I didn't back up my wallet, after a factory reset I can't have back access into the wallet on my phone. Such a novice, please can anyone help, I promise to give out a considerate amount of coins in return. I know it can never be enough but for the sake of humanity I'm begging please someone help me, anyone. Thank you

Potential Error: Sending XRP

I have tried to send XRP to multiple accounts and keep getting hit with the error "An error occurred when trying to make your payment. Most likely lack of funds in the account you are sending from. ( The network requires a minimum account balance.) This error can also be caused by an invalid or not activated destination address or if the Ripple network is overloaded."

I have tried multiple addresses including the address for sending tips and nothing seems to progress.

Additionally, I have ample XRP in the address I am sending from.

Please let me know if you have any idea why this may be happening.

Uncaught TypeError on launch

Source: Toast Discord #help

Problem Statement: Multiple users reporting the following error when opening the app (and when updating passphrase);

We're sorry: An unexpected error has occured with Toast Wallet. Please report the below to [email protected] along with what you were trying to do at the time the error occured. If you haven't already it would be prudent to make a backup of your wallet. You may need to restart Toast Wallet by closing it manually. Uncaught TypeError: Keyboard.shrinkView is not a function https://toastwallet.com/browser/index.html 113

Appears to be version dependent as it has not been seen in existing app instances running on older versions of browsers (tested in both Chrome 68 and Opera ).

Web search turns up Medium article citing (undocumented?) keyboard API as the source of the issue.

Does not occur in:

Version: | 54.0.2952.71 - Restart Opera to update to version 55.0.2994.37  Stable Windows 7 32-bit

iPhone splash screens

Some sizes of iPhone still show the default cordova / phonegap logo. These need to be tracked down and splash screens created for those screen sizes.

recovery phrase rejected

I have restored my wallet using my backup and recovery phrase, now every time I try to use my recovery phrase it is rejected as the wrong set of words, I have forgotten my passphrase and want to change it

Question about Specific Platform Repo...

This contains the core javascript and css of the wallet. Each specific platform has a repo that wraps the html5 app.

Where are the specific repo? Are these public? And why not? I couldn't find... Where could I find?

Thanks a lot..

Giorgio

PIN keyboard partially disappears while entering code

Happens every time I'm opening the app on a Samsung model SM-504FM (retail name is A50).

Screen Rotates 90 degrees when program opens

This may sound super strange, but on my Yoga 13, when I open this program, the screen literally rotates 90 degrees so I need to tilt my head to even see it.

I've tried running it in compatibility mode and nothing seems to work. It even rotates the screen with screen rotation off.

iTunes Restore keeps the money/private keys in the Cloud.

to my brother... that was weird... a security flaw.
Jaxx does not upload private keys to iTunes iCloud.
when iPhone is restored, Jaxx is empty...

that is good for people that forgot to write down the private keys & Pair ID/QR...
that should be optional, disabled by default, asked when creating a wallet.

Feature request - Escrow

Feature request for the toast development team to add a built in feature to utilize the escrow cabalities of the XRP ledger in a user friendly way.

running in web server documentation?

Hello,

I am new to ToastWallet but would like to try and run it on a Ubuntu 18.04 system in a web server like on your wewbsite:

https://toastwallet.com/browser/index.html

Can you please give installation directions?
Thanks

Copy button does Not work...

iOS12.2
iPhone 6s Plus

Copy Button does Not work...

The data below is your encrypted wallet backup

You should make a new backup whenever you add a new account to your wallet, change your passphrase or change your pin. Toast Wallet will prompt you when a new backup is required.
{Copy}

Your backup

b04ebe8c{"walletversion":"1.0","pindata":........

BUT... Versioon: 2,5,8
iPhone8,2 - iOS - 12.2
wss://s-west.ripple.com

Feature Request: Add 2FA

I believe it would be useful to implement 2FA for the Toast Wallet. It is not only incredibly user-friendly now with services like Google Authenticator and such, but adds a layer of security that cannot be captured with a simple passcode.

XRP wallet now says not activated

Please help! My toast wallet had thousands of XRP but now it is saying not activated. I can still see the previous transactions showing the XRP I sent to the wallet. Restoring from backup didn’t help. How can I retrieve my XRP now?

Linux build?

Hello,

I am running Ubuntu 18.04 and would like to know if there is a linux build?
Thanks

Issues with Recovery Phrase

With the last rally in cryptocurrencies, I decided now was a good time to sell some, or all, of my current XRP holdings. I am able to access the funds and see that they are still being held in my wallet, but I cannot move them. The pass phrase that I originally set for my wallet is “incorrect”, but I am sure that it is the right passphrase. I also wrote down and stored away the recovery phrase, but this is also “incorrect”. It is possible that 1 letter could be off in the phrase, but I am doubtful of this because I take extreme caution when dealing with this much crypto. I was wondering if anyone else has had this issue and if there is any way to resolve this? Thank you in advance for your time.

Method for secure deletion of App

Need to create a set of instructions for each platform on how to delete an instance Toast.

Use Case: User loses recovery word set and wants to make a new one. Has backup code and passphrase so can remediate by installing a new instance to get a new recovery word set then restoring from backup. Needs to delete original instance afterwards.

Ability to show/hide passphrase

Best practice for a passphrase is to use a long sequence of words/numbers and it can be cumbersome and error prone to type the passphrase out on a mobile device.

I would love if we could add the option to show the passphrase in plain text.

Here is a quick prototype: https://codepen.io/anon/pen/OjwZab?editors=1010#0

Feature Request/ Inquiry - Android Intent to load with receivers address

Hi there,

I'm starting to hash out a project, and was wondering if there's a way to use an intent in one app to open ToastWallet straight to the send screen (after PW screen, of course) with receivers address (and possibly the amount) pre-populated from the intent?

Not sure if this is something that's implemented already.

Regards,
Codeward

Feature request - latest transaction on top

Currently toast wallet shows all transactions in chronological order.

Could you make reverse chronological the default? (with maybe the option for chronological), like on my bank account?

Feature request: Show account value in other currencies

Right now it displays the amount only in USD. I'd like to have it displayed in Euros

Sent XRP from ToastWallet to binance. XRP didn't make it, no transaction log. It's as if it just vanished.

As the topic says, XRP blockchain was under pressure today. I sent XRP from my wallet to binance and it never made it. Binance asked me to reach out to you. I suspect it's their issue but trying to find a transaction id from you - nothing shows up in my wallet.

Lots of folks reporting the same issue.

Deeplinks die at pin entry screen

I'm currently using a deeplink (xrpl://) to provide a quick way for users to send payment if they are already on their mobile device and therefore can't scan the provided QR. Toast wallet handles the intent properly and opens the app; however if the app isn't already open and unlocked the pin entry screen is shown. If I then enter the pin it opens the app, but not to a payment screen with the proper info entered, but to the default accounts screen.

Signed releases

Currently there doesn't seem to be a way to authenticate the binary releases downloaded from the website (please correct me if I'm wrong). Signed releases would help (at least with detection) in case something like this: https://bitcointalk.org/index.php?topic=2060864.0 happened to ToastWallet.

Ripple URIs in QR codes

Some exchanges (shapeshift for example) provide their users with a QR code which contains a Ripple URI. However no officially supported URI scheme currently exists.

To our knowledge these URIs are generally formatted like so: ripple:

&dt=
However other exchanges might use other formats.

A roundup of common defacto formats should be made and an intelligent parser built out of multiple regular expressions to be attached to the QR code scanner for ease of user interaction.

This is the only published documentation on Ripple URIs and it is quite clearly abandoned:
https://wiki.ripple.com/Ripple_URIs

We have PM'd David Schwartz on xrpchat.com about this issue but have not received a response -- possibly indicating that Ripple Labs do not have a policy on these URIs at all currently.

Restore an existing Wallet on mobile

I have a ToastWallet on my Desktop. Can I work with that wallet with my mobile as well? I thought I could "Restore an Existing Wallet" on my mobile, but do I then have to type in manually that enormously long string that looks like JSON from the Wallet Backup of my Desktop version? That's hardly doable. Is there an easier way?

navigator.connection.type == 'Connection.NONE'

In line 7579 of index.html, you need to leave out the quotation marks, in order to access the Connection object.
As it is implemented now, it will not detect whether there is an internet connection or not

Account rename feature

Common feature request we get is account rename feature.

Pretty straight forward feature but needs careful programming to ensure data cannot lost.

Stay on the transaction screen if there is a problem sending XRP

Related to #23, I really need to transfer XRP to another address, but there is some error and I'm returned to the previous screen. It would be nice if I stayed on the send screen if there is an error, so I don't have to scan the QR code again or enter the (complicated) passphrase again. (I can't stand typing on a phone with my Shrek thumbs...)

Thanks for this project!

Backup code on toast wallet, XRP

Hello please, I have my pass phrase and recovery phrase, but I didn't back up my wallet, after a factory reset I can't have back access into the wallet on my phone. Such a novice, please can anyone help, I promise to give out a considerate amount of coins in return. I know it can never be enough but for the sake of humanity I'm begging please someone help me, anyone. Thank you

Unfunded Error Despite Retaining 20 XRP

For the last few months, I am trying to get my XRP out of Toast Wallet but keep getting the 'tecUNFUNDED_PAYMENT' error. Here's my Toast public address that you can look up to see: tecUNFUNDED_PAYMENT error.
rLtx5RKuf2gYo5QP4fmwBWFTpGh9vtvirN

Please don't ask the obvious: yes, the address was correct. I even tried sending to different addresses with the correct tags. Yes, 20 XRP was left to Toast. I even tried sending just 5 XRP which worked before. You can see all those logs if you go to:
https://bithomp.com/explorer/rLtx5RKuf2gYo5QP4fmwBWFTpGh9vtvirN

Any idea?

Method to generate and verify checksums for code downloads from toastwallet.com

A user request a way to do this in #help

Allow import of regular keyed addresses

Ripple allows an address to use a different address for signing through setregularkey.

What this looks like is a keypair that doesn't match. So an address that has a non-matching secret. However the network will still accept transactions signed using the "wrong" secret for the address in question provided the address was setup correctly.

With knowledge of the above we need to provide an advanced import screen that allows specification of both public and private parts of a ripple address.

recovery phrase

Hi there, somehow i lost my recovery phrase and my pass phrase, i only know my pin number, is there anything i can do to get back my recovery phrase? so ill be able to fix my problem.
since now thank you very much for your help.

Automated test library

As the wallet grows in features it becomes harder to test them all manually and easier to break something with a small change. We need automated GUI testing. This will probably be a tack-on javascript library that simulates DOM events and reads DOM elements.

Account not activated after restore

Hi everyone,
I have restored my exciting wallet which I opened from my PC to my mobile app and it’s says that it is not been activated.
I have a nice amount of Ripples there.

I have also downloaded the wallet to my new PC after recovery and same thing there.
What should I do?

Please provide AppImages for download on GitHub Releases

This project is already set up to produce AppImages, so it would be nice if you could provide one for download on GitHub Releases.

core/package.json

Line 33 in 96358a1

"target": "AppImage"

Providing an AppImage would have, among others, these advantages:

• Applications packaged as an AppImage can run on many distributions (including Ubuntu, Fedora, openSUSE, CentOS, elementaryOS, Linux Mint, and others)
• One app = one file = super simple for users: just download one AppImage file, make it executable, and run
• No unpacking or installation necessary
• No root needed
• No system libraries changed
• Works out of the box, no installation of runtimes needed
• Optional desktop integration with appimaged
• Optional binary delta updates, e.g., for continuous builds (only download the binary diff) using AppImageUpdate
• Can optionally GPG2-sign your AppImages (inside the file)
• Works on Live ISOs
• Can use the same AppImages when dual-booting multiple distributions
• Can be listed in the AppImageHub central directory of available AppImages
• Can double as a self-extracting compressed archive with the --appimage-extract parameter

Here is an overview of projects that are already distributing upstream-provided, official AppImages.

If you have questions, AppImage developers are on #AppImage on irc.freenode.net.

How to import Rippex?

Hello my secret key from Rippex does not work in Toast and Rippex is closed. How do I use Rippex in Toast please?

Feature request - Allow restore of Ripple wallet using HEX private key from wallet apps using BIP44.

Can you add support for restoring Ripple wallet using HEX private key from wallet apps using BIP44?

From Exodus.io app Ripple account is exported as private key, for example "f3ff9817dacfe1ae2522894f33696a7e26ffb1e2892b6bfe72434a0000000000" (not actual private key)

The ToastWallet is expecting the Ripple secret key, for example "snoPBrXtMeMyMHUVTgb0000000000"

I used the offline version of this website with my 12-word recovery seed for testing.
https://iancoleman.io/bip39/

BIP32 Derivation Path for XLM = m/44'/144'/0'/0

Accessibility: UI elements should respond to click events, not just touch ones

I tried Toast Wallet on Android, iOS and Mac, and in all three cases observed the same accessibility barrier (coming from the shortcomings of the JS/CSS implementation). In particular, when a screen reader, e.g. Talkback on Android, VoiceOver on Mac OS/iOS, attempts to activate any of the UI elements, nothing happens. Quite likely, the reason is that those elements expect touch/mouse events exclusively. For accessibility clients to function properly, the click events should be respected as well.
As it stands now, many disabled users who rely on accessibility tools will have difficult time using Toast Wallet app(s).

I sent XRP from my wallet to binance and it never made it.

From last three days i am trying to find out where does it goes my transection id says its successfully done but i cant see my xrp in binance whose fault is this no one is replying also

feature request - contacts

Could you allow me to save wallet adresses as contacts, for repeat payments?

connectivity

if i setup my own ripple network..how do i point the wallet to my own domain?

Local folder path for DB saving, Useful for portable apps

It is just a suggestion, not an issue.
Is there any method (or improvement) to save a DB into User specific folder.
Actually, APP is saved into a computer in %appdata%/toastwallet for windows system.
If this folder can be specified into a USB drive (or any location), Is it will be useful as a hardware wallet ?

The phone on which toast wallet was installed is broken

The phone on which toast wallet was installed is broken and all the apps where deleted including toast wallet. Is there a way to install it again on another phone and access my xrp? Can you please guide me step by step what to do?

Harfbuzz version too old (1.3.1)

ToastWallet 3.0.0 is failing to start on Archlinux x64

`./ToastWallet-3.0.0-x86_64.AppImage

(toastwallet:2926): Pango-ERROR **: 19:08:53.553: Harfbuzz version too old (1.3.1)

Trace/breakpoint trap (core dumped)`

Propose removing arbitrary password rules.

NIST’s new password rules

No composition rules. What this means is, no more rules that force you to use particular characters or combinations, like those daunting conditions on some password reset pages that say, “Your password must contain one lowercase letter, one uppercase letter, one number, four symbols but not &%#@_, and the surname of at least one astronaut.”

Let people choose freely, and encourage longer phrases instead of hard-to-remember passwords or illusory complexity such as pA55w+rd.

https://blog.codinghorror.com/password-rules-are-bullshit/