tobiasrohloff / nestedscrollwebview Goto Github PK

An Android WebView that implements NestedScrollingChild, in order to use it with CoordinatorLayout and AppBarLayout.

License: Other

Java 100.00%

nestedscrollwebview's Introduction

NestedScrollWebView for Android

A WebView that implements NestedScrollingChild, in order to use it with CoordinatorLayout and AppBarLayout from the Android Design Support Library. This is necessary since embedding a regular WebView in a NestedScrollView causes height issues (e.g. infinite height, tested with design:23.1.1).

This is just a workaround, until Google will hopefully fix it.

The code is based on this and this.

Setup Instructions

(1) Using gradle

Add the JitPack repository to your root build.gradle at the end of repositories:

allprojects {
    repositories {
        ...
        maven { url "https://jitpack.io" }
    }
}

In your application's main module (usually called "app"), edit your build.gradle to add a new dependency:

dependencies {
    implementation 'com.github.rhlff:NestedScrollWebView:v1.1.1'
}

(2) Using git submodule

In the root of your application's project add the library as a git submodule:

git submodule add https://github.com/rhlff/NestedScrollWebView

In the root of your application's project edit the file "settings.gradle" and add the following lines:

include ':NestedScrollWebView:lib'
project(':NestedScrollWebView').projectDir = new File('/NestedScrollWebView')

In your application's main module (usually called "app"), edit your build.gradle to add a new dependency:

 dependencies {
    ...
    compile project(':NestedScrollWebView:lib')
 }

Now your project is ready to use this library.

To update the library, follow these steps:

From the root of your application's project change directory to the library:

cd NestedScrollWebView

Pull the last changes:

git pull origin master

Now the library is up to date.

Usage

In your layout.xml include the following:

<com.tobiasrohloff.view.NestedScrollWebView
            android:id="@+id/webView"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:focusable="true"
            android:focusableInTouchMode="true"
            app:layout_behavior="@string/appbar_scrolling_view_behavior" />

Known Issues

Doesn't work well with CollapsingToolbarLayout, mainly tested with the regular ToolbarLayout.

License

Copyright (C) 2016 Tobias Rohloff

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

nestedscrollwebview's People

Contributors

Stargazers

Watchers

Forkers

cqululei benjaminvadon filipnabrdalik shidongdi zondaof2012 gerenvip huyanghu cheah r0b3rdv yanyanlun ebonhart bluebupang thomasmarchaud yangteng2013 iknow4 chenlove she1014 zeroplucky xiaoming0214 lvfeimeng lsprite reborty kingslou hanfengzqh songbigb yixiaolunhui achievozhou masayukisuda forksource xmmdream swillk dxiaogang hurbet huanglei365 it212 cccfly-bake zhttong dev-seungyeon chintanbhadra knifer month12 wycliffepeart hungtdo schle qsxs 751496032 loper7 seamanz wk1995 chiwaichoi wchl09 zhuqingyuan zabochen daveboy qw805880101 lxlyhm victory-over jicanghai37927 lichangbo chapliny jingmeng rohitnotes huangchuangyun kaiyuanshengshichangan ptrainbow shaycormac newpersonking jhanay yangyong915 poisonousjohn flyfire zyjwall zoushiqing suifeng07 uvneshtring albusd-tez

nestedscrollwebview's Issues

Failed to sync Gradle project

Hello, I was excited to see that you provided a gradle compile statement. I tried using the command, compile 'com.github.rhlff:NestedScrollWebView:v1.0.2' ... but i keep getting the error "Could not find com.github.rhlff:NestedScrollWebView:v1.0.2" Is there a different command I should be using?

Thanks,

Bouncy scrolling in BottomSheetDialogFragment

Hi, I tried using this library in a BottomSheetDialogFragment, and it worked pretty well, apart from the bouncy scrolling when settling the BottomSheet by dragging the finger. Does anyone have an idea of the cause of this issue? Also, sometimes, the WebView scrolls up while dragging the bottom sheet from expanded to peek state.

NestedScrollWebView does not open soft keyboard

Hello!

NestedScrollWebView does not open soft keyboard when I click to input fields on web-page. Tested on Android 6.0.1 and 4.3.

No (visible) scroll bar

Hi,
thanks for your project. I just replaced my old vanilla WebView with NestedScrollWebView and while everything else seems fine, there is one difference:
NestedScrollWebView has no scroll bar on the right side. Are you seeing this on your end too?

Thanks
Kai

`onTouchEvent` does not handle `MotionEvent.ACTION_POINTER_UP`

When I zoom a WebView by pinching, zooming will suddenly be canceled.
It seems that onTouchEvent does not handle MotionEvent.ACTION_POINTER_UP.
I added case MotionEvent.ACTION_POINTER_UP at L109 (or changed L108 - L110 to default:),
and it works fine.
Could you confirm this?

Unable to import package.

implementation 'com.github.rhlff:NestedScrollWebView:v1.1.1' in maven repo definition

package com.tobiasrohloff.view; in library.

This way I was unable to import the package after adding the above implementation to my dependency list. This worked before cbb0a83

Note that neither import package com.tobiasrohloff.view; nor import com.github.rhlff:NestedScrollWebView, nor import com.github.tobiasrohloff.NestedScrollWebView works.

Multitouch is broken

Multitouch doesn't work within NestedScrollWebView.
We need to stop scrolling when second touch is active. I found this way to fix it:

case MotionEvent.ACTION_POINTER_DOWN: // added to fix multitouch
case MotionEvent.ACTION_UP:
case MotionEvent.ACTION_CANCEL:
        stopNestedScroll();
        result = super.onTouchEvent(event);
        break;

Doesn't work well with CollapsingToolbarLayout

hello !

when NestedScrollingParent consume all motion event (AppBarLayout is still show) , the scrolling state is shake .

actually when NestedScrollingParent is scrolling NestedScrollWebView is also have small reciprocate move , because result = super.onTouchEvent(trackedEvent) is aways exe even deltaY == 0.

you can set AppBarLayout height bigger to get this performance

project level build.gradle

allprojects { 
    repositories {
        google()
        jcenter()
        maven { url 'https://jitpack.io' }
        maven { url 'https://oss.sonatype.org/content/repositories/snapshots' }
        flatDir {
            dirs "../libs"
        }
    }
}

app level build.project
implementation 'com.github.rhlff:NestedScrollWebView:v1.0.2'