tochemey/netcore8583

NetCore8583 is a library that helps parse/read and generate ISO 8583 messages for .NET Core

netcore8583's Issues

Fields with decimals throws an error

If we have decimals in the field num's then we get an exception. This is a 'valid' ISO message scenario, for example in Postilion Payment Switch interface they do have this a lot and we need to cater for this.

To Reproduce
Use below config file

<?xml version="1.0" encoding="UTF-8"?>

<n8583-config>

    <header type="0100">0100</header>

  <template type="0100">        
        <!-- Original Card Acceptor ID Code -->
        <field num="127.48" type="LLLVAR" />
        <!-- Dynamic Currency Conversion (DCC) status code -->
        <field num="127.49" type="LLLVAR" />
        <!-- Card Acceptor Additional Data -->
        <field num="127.59" type="LLLVAR" />
        <!-- Payment Token Identifier -->

    </template>

</n8583-config>

Expected Result
Works the same as if it was an integer

Observed Result
Logger.Error($"ISO8583 Cannot parse XML configuration {e}");

Add SourceLink for better debugging

Would be great to add source link for package.
https://github.com/dotnet/sourcelink

Get in touch

I would like to get in touch with you urgently 0244937428

User guide to use NetCore8583

Hello there. What's up?

May you share a user guide to use NetCore8583 ?

Or maybe you cloud explain how I can to use it

I can't find out how I can use it.

Add coverage report

Is your feature request related to a problem? Please describe.
This will show the code coverage level of the project and set a benchmark for any PR request.

Describe the solution you'd like
Add the coverlet dependency and enable codecov on the repo to display coverage report

Fix nuget credentials to cut release 2.2.0

@amammes I will fix this and release it.

Upgrade to .Net 8

Opening this issue to track upgrade to .Net 8

Migrate to the latest C# features

This is a discovery task to see whether there is a need to change some of the used c# features with the new ones.

Dictionary error

Hi,

I'm trying to use your library and it seems I'm getting errors.

The given key '-16' was not present in the dictionary.

Co-Maintainer wanted

I am looking for someone to help co-maintain this repo.

License?

Could please you add license statement for this library?

Is it MIT?

Upgrade to .NET 7

Raising this ticket to track upgrade to .NET 7

how we can send sbyte[] in .net core socket? can you create example for send data by socket?

Can't parse message if the field 125 is in parsing template while it's not in the message

Hi @Tochemey !

Trying to use your lib with the UK FasterPayments (FPS) integration and there's might be an issue:

Message: 9804000001020000000089118000000000000000007 (Type 9804, ASCII, BCD bitmap)

FPS has their own implemetation of the ISO8583 and fields of the message above are:

• 24, Numeric, Lenght 3 (n 3)
• 31, LLVAR (ans..18)
• 125, LLVAR (ans..60)

The problem with the 125 field that is conditional and it might be in the message (with the secondary bitmap) but might be not (therefore secondary bitmap is also absent). So the description of the lib says:

A message does not need to contain all the fields specified in a parsing template, but a parsing template must contain all the fields specified in the bitmap of a message, or the MessageFactory won't be able to parse it because it has no way of knowing how it should parse that field (and also all subsequent fields).

And it works perfectly with fields up to 64 even though they are not presented in the message. But once I have field 125 in my parsing template and it is not presented in the message AND secondary bitmap is not presented as well the parsing crashes with the message in my case:

System.ArgumentOutOfRangeException: 'Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index') Actual value was 124.'

If I remove 125 from parsing template, then it works.

What I want is be able to put any conditional fields in the parsing template regardless of bitmap they are belong and get correct message with posibility to check whether conditional fields parsed or not. Looks like the lib relies on the bitmaps presented, so If there are no field AND no bitmap it crashes.

Seems like it's MessageFactory.cs, Line 588:
if (bs.Get(i - 1))