tokelplatform/nspv-js

UTXO coins functions implemented in pure JavaScript, with komodo cryptoconditions support

nspv-js's Issues

dApp shows wrong TX value if transaction change address is different

Operation System

MacOS

Expected Behavior

If I receive a transaction and the change address for that transaction is different than the sender, the dApp should still ignore change value when displaying the tx in my activity.

Current Behavior

the dApp will recognize the whole value of the tx as an activity for my address.

Possible Solution (Not obligatory)

Filter tx.ins for the logged in address, so we can always ignore inputs and outputs not related to our address, when displaying wallet activity

Update nspv js protocol to 006 version

https://github.com/dimxy/bitgo-komodo-cc-lib/tree/tokel-nspv6-no-ntz-bracket

Incorrect tx values

Transaction have incorrect value after parsing

Better Error handling

We need to throw errors with stacktrace so we can actually see what is going on in the log. Currently erorrs are saved in the log without any further information

Parsing does not take into account transactions which are sent to your own address

http://explorer.komodoplatform.com:20000/tx/f0899280b7e90324589683d1939ea549fb451ad3f5f8a6d4bbc8732705b91430/TOKEL

This type of transaction should be included in the output twice as incoming and as an outgoing transaction for the wallet.

Implement validateTxUsingNtzsProof

All the transactions that we are polling from nspv have to be checked using that function.

So that is coin and token transactions.

Renovate Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

npm

package.json

• @tokel/cryptoconditions-js 0.1.3
• bech32 2.0.0
• bigi 1.4.2
• bip39 ^3.0.0
• bip66 ^1.1.0
• bitcoin-merkle-proof ^0.1.0
• bitcoin-ops ^1.3.0
• bitcoin-protocol ^4.1.3
• bitcoin-util ^2.0.0
• bitcoind-rpc ^0.9.1
• blake2b ^2.1.3
• bs58check 3.0.1
• bufferutil ^4.0.3
• create-hash ^1.1.0
• create-hmac ^1.1.3
• debug ~4.3.4
• ecurve ^1.0.0
• envify ^4.1.0
• event-cleanup ^1.0.3
• get-browser-rtc ^1.0.2
• merkle-lib ^2.0.10
• object-assign ^4.1.0
• old ^0.2.0
• once ^1.3.3
• pushdata-bitcoin ^1.0.1
• randombytes ^2.0.1
• safe-buffer ^5.2.1
• secp256k1 ^5.0.0
• setimmediate ^1.0.4
• sha.js 2.4.11
• through2 ^4.0.0
• typeforce ^1.11.3
• utf-8-validate ^6.0.3
• varuint-bitcoin ^1.0.4
• webassembly ^0.11.0
• websocket-stream ^5.0.0
• wif ^4.0.0
• bip65 ^1.0.1
• bs58 ^5.0.0
• dhttp ^3.0.0
• minimaldata ^1.0.2
• mocha 10.4.0
• nyc 15.1.0
• proxyquire ^2.0.0
• sinon ^18.0.0
• standard ^17.0.0
• node >=20.0.0

webpack-samples/package.json

• webpack ^5.0.0
• webpack-cli ^5.0.0
• webpack-dev-server ^5.0.0

travis

.travis.yml

• node 6
• node 7
• node 8
• node 9
• node 10
• node 7
• node 7

---

• Check this box to trigger a request for Renovate to run again on this repository

Documentation updates

1. Definitely the encode/decode part - I made the functions myself (remember the Toolks page I made) and I believe @jorian had to deal with the decoding part too.

2. The documentation is very "Komodo", which means if you are familiar with Komodo-cli / Komodod than it is very straight forward. I notice that the Tokel community will need more handholding, I'd suggest more hand holding.

3. What is really missing are the things that ARE working and the things that DONT work. This is not with so much the cli, because that is pretty much the lowest level where a Tokel developer needs to go (full node, etc). Bitgo, pretty much difficult, because yes nSPV, but not following the Komodo standard - which is okay of course, so there should be a set of API that needs a much more clear definition of what it does, and why it does it that way.

4. I think there should be some technical writing in place as Tokens/Assets CC uses some Antara magic. There needs to be some kind of manifest / cover all grounds tutorial. I think this should also be in collaboration with the Komodo team, because both parties will benefit from it.

5. Probably the most difficult part is that there are no step-by-step tutorials that allows you to adopt knowledge - yes, you can follow steps like a robot, but newbs like me, miss out on a lot of info, not because it is not available, but it is too deep (and can be mind boggling)
   (probably a good idea to combine the above with your marketing and stylist)

Bug: Consolidated transactions issue

Transactions which are consolidated from many inputs (mining transactions) do not have addresses. I think this is a bug in parsing.