tomasky/bookmarks.nvim

A Bookmarks Plugin With Global File Store For Neovim Written In Lua.

bookmarks.nvim's Issues

SUGGESTION

Invalid 'line': out of range

Not sure what's going on, everytime I enter window i'm getting this error. Clearing all bookmarks and adding a new one gets rid of the error.

Feature Request (Project Scope for bookmarks)

Is it possible to give an option to save booksmarks per project also instead of global scope.

Icons redraw issue

The icons not update/refresh before terminal focus will lost.

OS: Linux, OsX
Terminal: Iterm2, alacritty

The icons isn't load when file is open.
The icons not change after was edited by "mi"
Add/Remove new mark is worked normally.

After file was opened, or icon was changed by "mi" @f
need to lost focus of terminal and return. For example Alt+Tab or mouse action.
After this action all icons is loaded and updated.

Save file e.t.c. doesn't help.

FR: Statusline Component with count of bookmarks in the current buffer

Sometimes, I do forget that I have placed bookmarks in the current file. Such a statusline component might be useful as a reminder for that?

Telescope Picker Complains about opts = nil

Enjoying my emoji bookmarks 💯 🚀

Also when I try to use the telescope picker, I see:

E5108: Error executing lua ...scope.nvim/lua/telescope/previewers/buffer_previewer.lua:41: attempt to index local 'opts' (a nil value)
stack traceback:
...scope.nvim/lua/telescope/previewers/buffer_previewer.lua:41: in function 'qflist_previewer'
...y/bookmarks.nvim/lua/telescope/_extensions/bookmarks.lua:68: in function 'list'
[string ":lua"]:1: in main chunk

Maybe there is something wrong with my mapping, or I am failing to pass in default opts somewhere? I'm in lazyvim btw, and fairly new to the plugin setup style
https://www.lazyvim.org/extras/util/project

Notably, telescope opts is set to nil (?), but I'm not seeing this issue with other plugins. Let me know if I should send this to Telescope or Lazyvim..

Thanks 🤝

---

-- Overriding editor.lua for better grep with telescope, fzf
local Util = require("lazyvim.util")

return {

  {
    "nvim-telescope/telescope.nvim",
    config = function()
      local actions = require("telescope.actions")
      require("telescope").setup({
      defaults = {
        mappings = {
          i = {
            ["<esc>"] = actions.close,
            ["<c-j>"] = actions.move_selection_next,
            ["<c-k>"] = actions.move_selection_previous,
          },
        },
      },
      })
    end,
    dependencies = {
...
      {
        "tomasky/bookmarks.nvim",
        config = function()
          require("bookmarks").setup({
            -- sign_priority = 8,  --set bookmark sign priority to cover other sign
            save_file = vim.fn.expand("$HOME/.bookmarks"), -- bookmarks save file path
            keywords = {
              -- You can just copy these from emoji keyboard in browser (since it's using same font)
              ["@t"] = "🔥", -- mark annotation startswith @t ,signs this icon as `Todo`
              ["@w"] = "⚠️ ", -- mark annotation startswith @w ,signs this icon as `Warn`
              ["@f"] = "⛏ ", -- mark annotation startswith @f ,signs this icon as `Fix`
              ["@n"] = "🧠", -- mark annotation startswith @n ,signs this icon as `Note`
            },
            on_attach = function(bufnr)
              local keymap = vim.keymap.set
              local bm = require("bookmarks")
              keymap("n", "<leader>mm", bm.bookmark_toggle, { desc = "# Toggle Emoji Bookmark" })
              keymap("n", "<leader>mi", bm.bookmark_ann, { desc = "# Change annotation" })
              keymap("n", "<leader>mc", bm.bookmark_clean, { desc = "# Clean all marks in buffer" })
              keymap("n", "<leader>mn", bm.bookmark_next, { desc = "# Jump to next mark in buffer" })
              keymap("n", "<leader>mp", bm.bookmark_prev, { desc = "# Jump to prev mark in buffer" })
              keymap("n", "<leader>mq", bm.bookmark_list, { desc = "# Show marked file list in quickfix window" })
              require("telescope").load_extension("bookmarks")
              keymap(
                "n",
                "<leader>ml",
                [[:lua require("telescope").extensions.bookmarks.list()<cr>]],
                { desc = "# Telescope bookmarks list" }
              )
            end,
          })
        end,
      },
    },
...

Feature Requeset: Delete all marks

It would be helpful to have an action that deletes all marks in all buffers.

Bug: attempt to call global warn (a nil value)

Failed to run `config` for bookmarks.nvim

...l/share/nvim/lazy/bookmarks.nvim/lua/bookmarks/async.lua:45: The coroutine failed with this message: .../share/nvim/lazy/bookmarks.nvim/lua/bookmarks/config.lua:52: attempt to call global 'warn' (a nil value)
stack traceback:
	.../share/nvim/lazy/bookmarks.nvim/lua/bookmarks/config.lua: in function 'validate_config'
	.../share/nvim/lazy/bookmarks.nvim/lua/bookmarks/config.lua:73: in function 'build'
	.../.local/share/nvim/lazy/bookmarks.nvim/lua/bookmarks.lua:67: in function <.../.local/share/nvim/lazy/bookmarks.nvim/lua/bookmarks.lua:66>

Config

return {
  "tomasky/bookmarks.nvim",
  event = "VeryLazy",
  config = function()
    require("bookmarks").setup {
      on_attach = function(bufnr)
        local bm = require "bookmarks"
        local map = vim.keymap.set
        map("n", "mm", bm.bookmark_toggle) -- add or remove bookmark at current line
        map("n", "mi", bm.bookmark_ann) -- add or edit mark annotation at current line
        map("n", "mc", bm.bookmark_clean) -- clean all marks in local buffer
        map("n", "mn", bm.bookmark_next) -- jump to next mark in local buffer
        map("n", "mp", bm.bookmark_prev) -- jump to previous mark in local buffer
        map("n", "ml", bm.bookmark_list) -- show marked file list in quickfix window
      end,
      require("telescope").load_extension "bookmarks",
    }
  end,
}

Bug: signs aren't loaded on startup

Thanks for this plugin, wouldn't have found it if it wasn't just listed recently (#1).

I noticed that the signs (in the signcolumn) do not appear on initial startup. The bookmarks are there and work for going to the next bookmark, but the signs only appear after you switch to a different buffer and then switch back.

I have tried it without lazyloading, still the same issue. I also tried disabling other plugins that add things to the signcolumn (e.g. gitsigns) in case of conflicts there, but the issue persists even then

Underrated

I think that's some good work presented in this plugin.

If it's not to bothering for you i'd submit it to awsome neovim for you, to expose it to a larger user base.

Conflict with gitsigns plugin

When we are use gitsigns plugin the bookmarks isnt working.
But on the same time another plugin like

		"yaocccc/nvim-foldsign",

Work normaly

Feature Request: Telescope delete action

Would be awesome to have a telescope action to delete a bookmark.

SUGGESTION: Bookamrks comments as toggleable "ghost" scratchpad nead code line

Though that'd be useful if you could see the bookmarks comments as toggle scratchpad text instead of having to open the telescope bookmarks list everytime to want to reveal the bm text and that might be quite eay to do with some prior similar experience(for some of us...)

Feature Request: infer/default bookmark name

First of all, I love this plugin and use it daily for keeping track of and jumping around different large codebases.

I often create bookmarks for functions or structs, and if would as such be great if bookmarks could use treesitter or similar to look up the name of the current function/ident and prefill the popup for the bookmark name with the ident of it.

Thank you

Allow to resize the items in the results view

The notes we add to the mark are being trimmed too much.

Is it hardcoded here for 30 chars?
https://github.com/tomasky/bookmarks.nvim/blob/main/lua/telescope/_extensions/bookmarks.lua#L40

It would be great to have them named and allow to configure them individually.