tomkeuper/bedwars2023

A minecraft minigame where you have to defend your bed and destroy the others. Once your bed is destroyed, you cannot respawn.

bedwars2023's Issues

game end no winner?

Describe the bug
when a game gets to the end of the game end countdown there is no message at the end and no winner.
Maybe there should be no winner but it should announce that the game has finished,

To Reproduce
Steps to reproduce the behavior:
wait... (set timers to a low number :) )

Expected behavior
game end screen

Better Translations support

Is your feature request related to a problem? Please describe.
Use CrowdIn to aquire translations for languages

Will require language method to be redone an supply a readable format for CrowdIn like yml.
Message mapping for all languages should be done in a single class

/bw leave don't leave immediately :angry:

like the title described

Implement different shop types (Old Hypixel, new Hypixel, etc)

implement it, the defualt one doesnt have enough possibility

BedWars Addon Improvements

Is your feature request related to a problem? Please describe.
Actually, when you create an addon for BedWars1058 you need to follow some steps linked inside andrei wiki

Describe the solution you'd like
An addon class to extend inside your bw addon to register in main plugin class (an addon system like mbedwars one)

A bug where you can put tools or swords in chest inventory or enderchest inventory

Describe the bug
A bug where you can put tools or swords in chest inventory or enderchest inventory

To Reproduce
Steps to reproduce the behavior:

Expected behavior

Screenshots
viedo here

Base.Profile.2023.05.21.-.14.58.21.02.mp4

System (please complete the following information):

• OS: windows
• Server software paper
• Server Version 1.8.8
• Plugin Version 23.3-SPAPSHOT

Additional context

Sword bug | Chest

Describe the bug
Open chest and put wooden sword in chest by use ur mouse click wooden sword in your inventory and move cursor mouse to chest inventory then left click it will close the chest and drop wooden sword but when you pick it up your sword will disappear

To Reproduce
Steps to reproduce the behavior:
1.Put Wooden Sword in chest
2.Pick the wooden sword that got drop after you put it in chest
3.Your sword disappear unless you press E on ur keyboard then right or left click on the first slot (or the slot that u set for being sword)

Video
https://streamable.com/dr99lt

Fireball damange too high

Describe the bug
Direct hits have 2 different hit events:

And the config value seems to be ignored as fireball.damage.enemy is set to 0

water can be placed above build limit

Describe the bug
A water bucket can be emptied on top of the build limit blocks. This way you are also not able to remove the source block

To Reproduce
Steps to reproduce the behavior:

Expected behavior
No water above build height

Screenshots

Spectator see chat via a permission

Is your feature request related to a problem? Please describe.
Yes you can't see a game's chat for now

Describe the solution you'd like
I'd like for normal player to able to see shout and player with permission to see all chat

Describe alternatives you've considered
No alternative for now

Additional context
None

checkWinner Method Null

Describe the bug

To Reproduce
Steps to reproduce the behavior:

Expected behavior

Screenshots

System (please complete the following information):

• OS:
• Server software
• Server Version
• Plugin Version

Additional context
https://pastebin.com/KpAyExeW
https://pastebin.com/QJViHEuP

Translated messages in chat are based of event player, not recipient player

Describe the bug
plugin doesnt send message in recipient lang

Screenshots

Wooden Sword Issue

When i get the sword from the chest the wooden sword doesn't disappear like the big network, please fix that and make the sword disappear!

Add double/float support for forge upgrades

Is your feature request related to a problem? Please describe.
It's extremely inconvenient if we can't use decimals for generator speed.

Describe the solution you'd like
Add the possibility to use decimals as delay for forge upgrades.

Describe alternatives you've considered
None.

Additional context
None.

Make tab and nametag support displayname

Tab and nametag doesn't have displayname option, my nick system is screwed :vaporized:

More Commands and Additions to the setup thingy

Is your feature request related to a problem? Please describe.
No it is not, but it will help with adding more features and additions to the fork if these features are added

Describe the solution you'd like
Would like the addition of the following commands:
/bw displayName || To Add the Display_Name from the Setup Scenario
/bw setBorder || To Set The Arena Border from the Setup Scenario
/bw useBedHologram false || To Set The BedHologram above the Bed to be shown or not
/bw allowMapBreak false || To Allow the map to be breakable
/bw emptyTeamNPC true || Basically disable-npcs-for-empty-teams setting but as a command
/bw killHeight || To Set what the height at which the player will die will be
/bw islandRadius || To set the island radius
/bw emptyTeamGenerator || To set if empty teams generators will work or not
/bw SetGameRule <true/false> || Set the gamerule for the Arena World
/bw ToggleVanillaDrops <true/false> || To allow vanilla Drops to be enabled
/bw SetGenProt || To Set the generator Spawn Protection
/bw SetUpgradesProt || To Set the Upgrade NPCs spawn protection
/bw SetShopProt || To set the shop npcs spawn protection
/bw setspawnprot || To Set the spawn protection
/bw SpawnInvincibility || To disable or enable the invincibility period for when your spawn back in.

NPE on announcement when arena is empty

Describe the bug
Announcements dont get cleaned up after an arena is finished

To Reproduce
Steps to reproduce the behavior:

Log
[23:29:37 WARN]: [BedWars2023] Plugin BedWars2023 v1.0-SNAPSHOT generated an exception while executing task 4967
java.lang.NullPointerException: Cannot invoke "java.util.List.iterator()" because the return value of "com.tomkeuper.bedwars.arena.Arena.getPlayers()" is null
at com.tomkeuper.bedwars.arena.Announcement$1.run(Announcement.java:53) ~[bedwars-plugin-1.0-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.v1_19_R3.scheduler.CraftTask.run(CraftTask.java:101) ~[purpur-1.19.4.jar:git-Purpur-1962]
at org.bukkit.craftbukkit.v1_19_R3.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[purpur-1.19.4.jar:git-Purpur-1962]
at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[purpur-1.19.4.jar:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
at java.lang.Thread.run(Thread.java:833) ~[?:?]

Expected Behaviour
Clean up announcements after an arena is finished.

System (please complete the following information):

• OS: Linux
• Server software Purpur
• Server Version 1.19.4
• Plugin Version 1.0-dev

Use Redis to store SWM worlds + sync configs

Implement the use of Redis or MongoDB in bedwars2023 for fast, efficient and memory free loading of arenas, shops, stats, and more

PopUp towers go above build limit

Describe the bug
Placing a popup tower right under the build limit will cause it spawn partly above the build limit.
Someone also mentioned this was the case with bridge eggs but I havent been able to reproduce this error

Screenshots
Note: limit is set at 180

System (please complete the following information):

• OS:
• Server software
• Server Version
• Plugin Version

Additional context

When the build session is enabled, the block can be destroyed but cannot be placed.

Describe the bug

To Reproduce
Steps to reproduce the behavior:

Screenshots
https://user-images.githubusercontent.com/85287520/236636578-55a3e58b-d9a9-4707-b83c-724e62d70b12.mp4

System (please complete the following information):

• OS: Windows
• Server software paper
• Server Version 1.8.8
• Plugin Version 23.3-SPAPSHOT

Set upgrade shop pricing per group

I would like to set the upgrade price per group. Is it possible to add?

Teleport GUI target wrong person when parsing placeholders

What the title said

Implement Footsteps on all versions.

Describe the bug
The current setup only works up untill 1.12 because Minecraft decided to remove the FOOTSTEP particle in 1.13.
https://minecraft.fandom.com/wiki/Particles

The texture is still in the game so maybe it can still be used when creating custom paritcles.

Additional context
Possible options are:

• Creating particles with PacketPlayOutWorldParticles
• Using a different particle for all versions.
• Suggestions??

Database Improvements

Is your feature request related to a problem? Please describe.
Is your feature request related to a problem? Please describe.
BedWars1058 actually supports 2 types of databases (SQLite and MySQL).

Describe the solution you'd like

• Implement a database API with methods like initialization, stopping, saving stats, etc (could be an idea moving the Database.class from bedwars-plugin to bedwars-api) and implement new database types for saving stats/shops (especially NoSQL databases like MongoDB).
• Implement a method BedWars#setDatabaseAdapter(IDatabase database)

Additional context

make bw join random actually random

Is your feature request related to a problem? Please describe.
I'm always frustrated when doing a command such as /bw join random or /bw join <group> and it not taking you to an actual random arena, and instead taking you to the first arena available in alphabetical order.

Describe the solution you'd like

• While making sure to maintain the feature of still sending you to an arena with most players, if the arenas are empty/full, it should take you to one of the available arenas RANDOMLY and not in alphabetical order

• If you specify the group with /bw join <group> , make it send you to the arena in that group with the most players, and if there is none, then just send to a random arena in that group, again not in alphabetical order.

Additional context
This is especially annoying and can be seen when joining a random arena after ending a game, as it will just send you to the same arena over and over and over again unless you choose one.

New API

Is your feature request related to a problem? Please describe.
Following the implementation of the various new APIs, bw2023 has achieved a major improvement, but it is not 100% complete

Describe the solution you'd like
New API still:

• IPlayerStats#getCustomStat(String stat) method.
• IPlayerStats#saveCustomStat(String stat, int amount) method.
• Create Column for custom stat.
• Remove Column for custom stat. (Needed?)
• New API for handlers (example: handler bw-team-selector and opens team selector) mbw inspired
• API methods for creating your own Lobby/Waiting/Spectator Item

For any other ideas respond with a message in this issue and that idea will be evaluated as well

Invisibility Potion fix

Describe the bug
When invis, other teammates are not able to see their invis teammates. When a player loses his invis, his body isn't visible, only his armor is visible.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
Teammates are able to see their invis teammates. Whole player should be visible after losing invis.

Screenshots

System (please complete the following information):

• OS: Linux
• Server Software Spigot
• Server Version 1.8.8
• Plugin Version 23.3.1-BETA2 (current code compiled)

Additional context

Event call issue

Describe the bug
When you join an arena as player or spectator the PlayerJoinArenaEvent is called after the join message.
To fix this problem is enough moving the PlayerJoinArenaEvent call before the join messages inside the methods addPlayer & addSpectator

message for build limit reached

Describe the bug
When building to the build limit set in the config there is no message displaying that you've reached the build limit.
This might be a feature but I concider this a bug for now

To Reproduce
Steps to reproduce the behavior:
build to the build limit

Expected behavior
A message in chat that the build limit has been reached

Tnt in off hand doesnt give particles

Describe the bug
The inventory move event isnt made to check off hand as its based of 1.8.

To Reproduce
Steps to reproduce the behavior:

1. Buy Tnt
2. Move tnt too off hand from inventory
3. Look from a different player

Screenshots

Rewrite the party system to make it work properly

Is your feature request related to a problem? Please describe.
The current party system doesnt work properly and its filled with bugs

Describe the solution you'd like
Rewrite the party system and add more party support

Describe alternatives you've considered
I dont think there are alternatives for this

Additional context
Suggestion to allow other plugins to use their own party system

Like implementing a interface and setting the party system throught the API

Wrongly parsed placeholders

In kill messages, %bw_player% is parsed as player's name instead of displayname

OreGenerator#Disable doesnt disable the generator

Describe the bug
When triggering the .disable function of a ore generator it doesnt stop the generator from spawning ores

To Reproduce
Steps to reproduce the behavior:

1. Get a generator thru the api
2. Try to disable it with IGenerator#Disable

Expected behavior
The generator stops producing

Above head particles dont reset after death

Describe the bug

To Reproduce
Steps to reproduce the behavior:

1. get tnt
2. Die

Sword drop Enchant

Describe the bug
When you drop stone, iron or diamond sword while u have team upgrade Sharpness
Your will get normal wooden sword that not have sharpness.
It should have Sharpness on Wooden Sword too when drop not only When Respawn

To Reproduce
Steps to reproduce the behavior:

1. Play game
2. Upgrade Sharpness
3. Buy Stone Sword
4. Drop it
5. You get only wooden sword that not have anything enchant on it.

Suggestion to add group stats

Is your feature request related to a problem? Please describe.
Add group stats to the main bedwars plugin instead of using a addon

Describe the solution you'd like
Implementing group stats to bedwars1058

Describe alternatives you've considered
Using a addon

Join and leave message is parsed wrongly

The viewer is the one who get parsed, not the actual player that join or leave

Can buy items in your inventory instead of the shop that you open and should buy from there

Describe the bug
When you click in your side of your inventory in the villager shop it will detect it as if you were clicking in the shop

To Reproduce
Steps to reproduce the behavior:

1. Open the quick buy (or any submenu in the quickbuy)
2. Click in your inventory side

Expected behavior
Items only buyable in the inventory that the items are in

(Not sure if this is understandable)

Play again addon

Adds a play again feature to BedWars1058, allowing players to quickly start another game without returning to the lobby

• Approval from original dev
• Implement into base plugin
• Test features

https://polymart.org/resource/1946/

elapsed time placeholder bug

Describe the bug
When 60 seconds pass with the %bw1058_elapsed_time% placeholder the minute gets added but the seconds don't get resetted

To Reproduce
Steps to reproduce the behavior:
1: Add elapsed time placeholder in sidebar or tab
2: wait 60 seconds
3: bug appears

Screenshots

System (please complete the following information):

• OS:
• Server software NachoSpigot
• Server Version 1.8.8
• Plugin Version latest

API Improvements

Is your feature request related to a problem? Please describe.
BedWars1058 enjoys a good amount of APIs that make the plugin remarkably customizable with addons, but in some parts of APIs it still lacks

Describe the solution you'd like
New APIs for greater customization:

• Shop API (for example ShopManager or ShopIndex API)
• Chat & Economy API (for economy also an event of moneyGain like PlayerXpGainEvent)
• Database API, see #40
• Stats API (Player Stats change event, stats interfaces and methods for creating new custom stats in addons with auto-implement in db)
• Make MoneyGain & XpGain events cancellable
• Upgrades API (like IUpgradesManager or a method to set an upgrade, like sharpened swords, to to a certain or maximum tier)
• BedWars Addon system, see #166

Bed Destruction cooldown bug

Describe the bug
The countdown for bed destruction in the scoreboard is bugged out. The time left is not shown in the desired format and instead is shown in a bugged out red manner.

To Reproduce
Steps to reproduce the behavior:

1. Join any arena and start
2. Wait for bed destruction countdown to start
3. It should be bugged

Expected behavior
It should not be bugged and should be shown in the desired manner like the other countdowns.

Screenshots
I'll provide screenshots later I'm making the bug report rn cuz ig a lot of people already know abt the bug.

System (please complete the following information):

• OS: Linux
• Server software Spigot
• Server Version 1.8.8
• Plugin Version 23.3

Additional context

Float and Double support for Generator Upgrade

float/double based Generator Speed doesn't work with Upgrades

Completely remove respawn screen

Is your feature request related to a problem? Please describe.
When a player dies they get a quick view of the respawn screen which then dissapears

Describe the solution you'd like
Completely remove the respawn screen. This is mainly for esthatics

Describe alternatives you've considered
Tried to implement this before but main struggles were:

1. Canceling the last damage event and then manually triggering the death event. This is not really an option since we will lose the death cause. causing other components to break. Maybe there will be a work around but from what I've seen so far it will mainly cause problems. Implementation inspired of #144

public static void checkPlayerHealth(Player p, EntityDamageEvent e, IArena a) {
    e.setCancelled(true);
    Bukkit.getServer().getPluginManager().callEvent(new PlayerDeathEvent(p, Arrays.asList(p.getInventory().getContents()), p.getTotalExperience(), null));
    Bukkit.getServer().getPluginManager().callEvent(new PlayerRespawnEvent(p, a.getReSpawnLocation(), false));

This method made the death cause get lost as its not passed to the PlayerDeathEvent which is used in the code.

2. Triggering a respawn event right before the player actually respawns. this will cause the player to appear as respawned making the respawn screen go away as long as its combined with the spigot player respawn. But this add the weird delay which is not caused by the plugin as both commands can be executed at the same exact time and still the delay will happen.

// send respawn packet
Bukkit.getServer().getPluginManager().callEvent(new PlayerRespawnEvent(victim, a.getReSpawnLocation(), false));
Bukkit.getScheduler().runTaskLater(BedWars.plugin, () -> {
    victim.spigot().respawn();
}, 3L);

Not Able to Use /bw setMinBuildHeight

Describe the bug
Not able to set the Minium Height of the Arena via command /bw setMinBuildHeight in SetupArena scenario. I am able to do /bw setMaxBuildHeight Command but not /bw setMinBuildHeight

To Reproduce
Steps to reproduce the behavior:

setJoinMessage and setQuitMessage for PlayerJoinArenaEvent and PlayerLeaveArenaEvent

i'd like to add event.setJoinMessage() and event.setQuitMessage() to PlayerJoinArenaEvent and PlayerLeaveArenaEvent

RGB support

Is your feature request related to a problem? Please describe.
Since the 1.16 version Minecraft has implemented the possibility to use RGB codes in messages, actually BedWars1058 not supports this feature.

Describe the solution you'd like
Implementing a config option like rgb/hex-enable:true/false and adding RGB support (mabye by using some libraries like IridiumColorAPI)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Can buy item when no inventory space

Describe the bug
When your inventory is full you can buy items from the shop, this will take the cost out of your inventory but it will not give you the item.

To Reproduce
Steps to reproduce the behavior:
Inv full > buy item from shop

PerMinuteTask throws an error during gameplay

Describe the bug
PerMinuteTask throws an error during gameplay

To Reproduce
Steps to reproduce the behavior:

Expected behavior

Screenshots

System (please complete the following information):

• OS: windows
• Server software paper
• Server Version 1.8.8
• Plugin Version 23.3

Additional context
https://pastebin.com/FtvwL0SP

Game start shortend gets ignored

Describe the bug
Default shortend time in config is 10 seconds but in game its 5 seconds.

To Reproduce
Steps to reproduce the behavior:
use /bw start

Expected behavior
10 seconds countdown.