ton-blockchain/governance-contract

governance-contract's Issues

Signed data replay protection

While there are no economic benefits of replaying signatures in Elector/Config it is still expedient to

1. add cross-network replay protection by adding global_id to the signed data and checking that it is equal to new GLOBALID
2. signed data should include sender field and check it, thus eliminating risks of replay.

No negative incentives for voting for any complaint

There can be some funds required to lock on each vote, and those will only be returned once the vote is passed.
Alternatively, validators may suggest complaint on other validators who voted for invalid complaints

Elector sends recovered stake with bounce=true instead of bounce=false

The elector currently sends back the stake with bouce=true:

https://github.com/newton-blockchain/ton/blob/b38d227a469666d83ac535ad2eea80cb49d911b8/crypto/smartcont/elector-code.fc#L421

This is not elegant since it's potentially millions of ton and the elector doesn't handle bounced messages. If we somehow reach a weird state that the depositor is frozen, the stake will be lost.

It's not easy to reach a state where the depositor is frozen, because it just sent a transaction to ask to recover state, but still, this should be fixed.

During the next elector update, please consider sending recovered stake with bounce=false, so if the recipient is somehow frozen, it will still be received.