topcoder-platform/submission-review-ui

Submission Review App UI

submission-review-ui's Issues

Challenge card is huge when I have many roles

Submissions and Artifacts accessible in Submission Review after Marathon Match

Just like members have access to submissions in OR, on a similar permission model can we have members access submissions in Submission-Review app? Also, now that we are working on making members look at their own submissions in My Submissions Tab. We can make submissions of everyone accessible their itself after the Match.

Can view submission from different challenges

I can visit http://local.topcoder-dev.com:3000/challenges/30054563/submissions/10df5797-20f8-4e55-be89-f3d2c5a39416 and see the content just fine even if the submission 10df5797-20f8-4e55-be89-f3d2c5a39416 does not belong to the challenge 30054563

Layout is broken when we have many prizes

Expected behavior:

• The timeline should have a min-width to make sure the layout won't break.
• Prizes should show up in multiple lines if they don't fit in a single line instead of pushing the content to the right.

Data Science/Development/Design links directing to blank Challenge Listing's page.

Description:

Data Science/Development/Design links directing to blank Challenge Listing's page

Steps to Reproduce:

1. Login with an account that has no active challenges.
2. Click the Data Science/Development/Design links available.
3. Observe the screen.

Actual Result:

1. Data science link directed to URL https://www.topcoder.com/challenges?filter[tracks][datasci]=true
2. Development link directed to URL https://www.topcoder.com/challenges?filter[tracks][develop]=true
3. Design link directed to URL https://www.topcoder.com/challenges?filter[tracks][design]=true

Expected result:

1. Data science link should direct to URL https://www.topcoder.com/challenges?tracks[DS]=true
2. Development link should direct to URL https://www.topcoder.com/challenges?tracks[Dev]=true
3. Design link should direct to URL https://www.topcoder.com/challenges?tracks[Des]=true

bandicam.2021-01-14.18-04-26-753.mp4

UUIDs are ugly

We should replace the UUIDs with something else in the UI.

The app crashes when accessing right after I launch an F2F

Seems like when no phase is open yet, the app is throwing an error.

Show scorecard / review system details

right now we list the review systems w/ their scores and the final review system w/ it's score.

we should, once the new v5 scorecard system is completed, add a link and/or details to the overarching scorecard and what criteria for the reviews are. This will bring full transparency to how a submission is being judged.

[$30] App crashes if user rating is missing

UI issue when having many roles

Review scores should show up in the main page

Expected behavior:

• We should be able to view scores (when available) without having to open the submission details page.

fix: disable downloading of infected submissions

infected submissions are flagged as such and disabled from download

Add tests

Cover the app with snapshot testing

[$20] Artifacts tab color is wrong

The selected state should have white background, not gray

Publicly Accessible .git directory

The https://submission-review.topcoder.com/.git/HEAD file is accessible meaning that the Git repository can potentially be mirrored.

##Steps To Reproduce:##

1. Visit https://submission-review.topcoder.com/.git/HEAD
2. Use a tool such as https://github.com/arthaud/git-dumper to dump the Git repository
3. Checkout the latest commit to obtain a copy of the working tree

##Supporting Material/References:##
Result of requesting URL: ref: refs/heads/master

##Impact##
By checking out the latest commit from the dumped Git repository, all version controlled objects for the application can be accessed. This could include source code and secrets which should not be publicly accessible.
No attempt has been made to dump the Git repository for further analysis, however this can be done if necessary in order to ascertain further details of a potential impact.

##Source:##
https://topcoder.atlassian.net/browse/VULN-1591

Update the submission details page

Update the existing submission details page based on the following requirements:

• Use tabs layout based on the design below.
• The Review summary tab should be enabled by default.
• The Artifacts tab should render data fetched from the /challengeSubmissions/:submissionId/artifacts endpoint.
• Clicking the download icon on the Artifacts tab should call the /challengeSubmissions/:submissionId/artifacts/:artifactId/download endpoint to download the artifact. This should work similarly to how downloading the submission currently works.

Design

• https://tc-sub-review-app-design.herokuapp.com/#artboard6
• https://tc-sub-review-app-design.herokuapp.com/#artboard7

Backend Dependencies

• topcoder-platform/submission-review-api#8

Github ticket rules

How to work with git tickets

The basic flow for handling a ticket is as follows:

1. Assign the ticket to yourself, change the label to "tcx_Assigned", remove the "tcx_OpenForPickup" label. Please only assign tickets to yourself when you are ready to work on it. I don't want tickets assigned to someone and then not have them work on a ticket for 24 hours. The goal here is a quick turnaround for the client. If you can't work on a ticket immediately, leave it for someone else.

2. Complete the ticket and create a merge request within 24 hours. Please ensure your merge request can be merged automatically and that it's against the latest commit in Git when you create it.

3. Change the label on the ticket to "tcx_ReadyForReview"

After seeing a ticket marked as "tcx_ReadyForReview", the copilot will review that ticket, usually within 24 hours.

Note that you are expected to keep your changes in-sync with Git - make sure to do a pull before you push changes to make sure there aren't any merge issues.

Accepted fix

If a fix is accepted, a payment ticket will be created on the Topcoder platform within 5-10 minutes of the issue being closed. You should see the payment in your PACTs within 24 hours.

Rejected fix

If a fix is rejected, a comment, and possibly a screenshot, will be added to the ticket explaining why the fix was rejected. The status will be changed to "tcx_Feedback".

If a fix is rejected, that ticket is your priority. You should not assign yourself any more tickets until you complete the required additional fixes!

Payment amounts

Each ticket in GitLab has a dollar value. That is the amount you will be paid when the ticket is completed, merged, and verified by the copilot. Note that there is still a 30 day waiting period as the payment will be treated as a regular TopCoder challenge payment.

Important Rules:

• You can assign any unassigned issue to yourself with an "Open for pick up" label (first come first serve)

• You can only assign ONE AT A TIME. The nature of it being assigned will indicate it is not available to anyone else.

• You will fix the ticket by committing changes to the master branch.

• After marking a ticket "tcx_ReadyForReview" you are eligible to accept another. You do NOT need to wait for the copilot to validate your fix.

• You can do as many tickets as you want, as long as you follow the rules above.

• If an assigned task is not done in 24 hours, you will need to explain why it is not completed as a comment on the ticket.

• You can ask questions directly on the GitLab ticket.

ANYONE NOT FOLLOWING THE RULES ABOVE WILL BE WARNED AND POTENTIALLY LOSE THEIR GITLAB ACCESS!

Deep linking to a submission details page fails

When following a link to a submission details page, the app redirects me to the challenge details page.

eg https://submission-review.topcoder.com/challenges/30092166/submissions/e9a70653-c237-4d78-8fe0-32cb10846264 redirects to https://submission-review.topcoder.com/challenges/30092166

I'm assuming something is wrong in the order we're doing the access checks.

Challenge card is not actually a link

Currently, the ChallengeCard component uses an onClick event to redirect to the challenge details page.

This needs to change to an actual link.

Use the Link component from react-router-dom to wrap the top-most element of the ChallengeCard.

[$100] Update all configs to properly read from env

1. Currently, based on process.env.NODE_ENV, it’s loading the configs from different places. I think we can just put process.env.<var name> || 'default value' in there to read from the env.

eg CHALLENGE_API_URL: process.env.CHALLENGE_API_URL || 'https://api.topcoder.com/v4'

2. Fix the code so it properly read env vars during the build (see slack convo with Guna)