tpay-com/tpay-magento2-basic

Magento2 basic payments module

tpay-magento2-basic's Issues

PHP8.x support

With PHP8, this module throws an error during code compilation

PHP Fatal error:  Declaration of tpaycom\magento2basic\Controller\tpay\Notification::createCsrfValidationException(Magento\Framework\App\RequestInterface $request) must be compatible with Magento\Framework\App\CsrfAwareActionInterface::createCsrfValidationException(Magento\Framework\App\RequestInterface $request): ?Magento\Framework\App\Request\InvalidRequestException in /builds/magento2/hyva-demo-package/vendor/tpaycom/magento2basic/Controller/tpay/Notification.php on line 109

Fixed in PR #37

Mage-OS support

Currently this module's composer.json

tpay-magento2-basic/composer.json

Line 14 in 82dc7a8

"magento/product-community-edition": "^2.3",

specifies a require on Magento's product-community-edition meta package, according to docs:

Do not specify a dependency on meta packages (e.g. product-community-edition).

Since mage-os uses a different meta-package this constraint cannot be satisfied.
PR #35 should fix this.

Nieaktualizowany stan zamówienia

Po poprawnej płatności zamówienie zmienia swój status na "Processing", jednak stan ("state") pozostaje nie zmieniony (cały czas jest "pending_payment")

Tpay module (both ^1.0.0 and ^2.0.0) doesn't work with Magento 2.4.6-p6 due to Csp issues

Due to some recent Csp security fixes, both versions of your module doesn't work.

VM11861:5 Refused to execute inline script because it violates the following Content Security Policy directive: "(...)" Either the 'unsafe-inline' keyword, a hash ('...'), or a nonce ('nonce-...') is required to enable inline execution.

The offending code I believe is:

• tpay-magento2-basic/Model/ApiFacade/TpayConfig/ConfigOpen.php

  Line 68 in dfabe43

  public function createScript(string $script): string

• tpay-magento2-basic/Model/ApiFacade/TpayConfig/ConfigOrigin.php

  Line 69 in dfabe43

  public function createScript(string $script): string

  
  And for the ^1.0.0 version:
• https://github.com/tpay-com/tpay-magento2-basic/blob/v1.5.5/Model/TpayConfigProvider.php#L119

The fix should be adding nonce attribute to the script as suggested in the console log.
Reference from Adobe: https://developer.adobe.com/commerce/php/development/security/content-security-policies/#using-csp-nonce-provider-to-allow-inline-scripts

EDIT: Also, it seems it's jQuery error: https://stackoverflow.com/a/42464060

Nie można zainstalować z najnowszą wersją magento 2.4

Podczas próby instalacji z najnowszą wersją Magento 2.4, która wymaga PHP w wersji 7.3 lub 7.4 wyskakuje następujący błąd:
- tpaycom/magento2basic 1.5.1 requires magento/product-community-edition ^2.3 -> satisfiable by magento/product-community-edition[2.4.0].

installation via composer

Your repo is not registered on official composer repos, so installation via require tpaycom/magento2basic is not working

manual installation is also not working because there are other module names than you specified
"php bin/magento module:enable tpaycom_tpay" simply cannot handle it - check your repo structure