transport-protocol/cadspracticalexamvs

Includes the files to start with the VS practical exam part 1 @HAW Hamburg Powered by Cads

cadspracticalexamvs's Issues

Interface for Robot Abstraction

Gibt es ein Interface, welches die Funktionalität des Roboters abstrahiert?
Zum Beispiel ein Interface, von dem sich CaDSEV3RobotHAL ableitet?
So wäre es möglich einen Wrapper für CaDSEV3RobotHAL zu bauen.

Grab/ Release does not work as expected

I started the simulation and printed the grap percent to the console.

Then i pressed R (Release?) in the simulation window. The sphere is red, console prints 100.
After pressing G (Grab/p?) in the simulation window the sphere is green, console prints 0.

Now i know this:

100 R   Released (Open) Red
0   G   Grabbed (Close) Green

now i use doClose()
Expectiation: the sphere turning green and the console prints 0.
Simulation: the sphere stays red, console prints 100.
Roboter: not tested.

removeService not working as expected

The method void removeService(java.lang.String service) implemented in org.cads.ev3.gui.swing.CaDSRobotGUISwing is not working as expected (as far as we have got the semantics straight that is)

• Expected behaviour: remove the String service from the Service chooser drop down menu (if existent)

• Actual behaviour: no change to the gui is registered

JSON Status Method access modifier should be private/ protected

Why should I have access to the methods giveFeedbackByJSonTo and onStatusMessage? The code in the dissassembler looks like a internal helper method: its only fire the event to the class given into the constructor.

That shouldn't be available to the user of CaDSEV3StudentImplementation so the methods should be private/ protected?

caller = new CaDSEV3StudentImplementation(new CaDSBase(),this,this);
caller.giveFeedbackByJSonTo(data);
caller.onStatusMessage(data);

Grap/ Grapper isn't an english word

should be named grab or grabber...

Another question: what exactly are we building here: dict.cc/?s=grabber?

JSON Status angle isn't an angle

a 0° to ~180° angle given in a percentage between 0 and 100 should be named "percentage" and not "angle".
Grapper has to be called with "doGrap()" and "doRelease()". There should be no percentage value as status information about it. { "grapping":true/false, ... } would be nice.

Denglish word in status message

procent is a denglish word and should be named "percent", "percentage" or something like that.

GUI with swing shows not always a reaction

Workaround, if possible use FX.
Update in next milestone

startGUIRefresh in CaDSRobotGUISwing not working

when executing startGUIRefresh it throws the following exception:

Exception in thread "main" java.lang.ClassCastException: cads.gnarls.Controller cannot be cast to org.cads.ev3.rmi.consumer.CaDSRMIConsumer
	at org.cads.ev3.gui.swing.CaDSRobotGUIRefresh.<init>(Unknown Source)
	at org.cads.ev3.gui.swing.CaDSRobotGUISwing.startGUIRefresh(Unknown Source)

the Cast probably should be to the interface ICaDSRMIConsumer instead of CaDSRMIConsumer.

Roboter 2 ist defekt

Moin,

Roboter zwei ist heute nicht an gegangen. Eventuell ist das Netzteil kaputt.

Liebe Grüße,
Fabian

TestProviderOpenClose

why does the ev3 version is named TestProviderCloseOpen and the simulation version TestProviderOpenClose?

and why do they do something different:

if(on)
  caller.doClose(); 
else
  caller.doOpen();

if(on)
  caller.doOpen(); // grap
else
  caller.doClose(); // release

GUI method contain degree in method name and deliver a percentage value

GUI method name moveVerticalToDegree and moveMoveHorizontallyToDegree deliver a percentage value. Method names should be named move*ToPercent.

(And moveMoveHorizontallyToDegree should not contain a double 'move' in the name)

VS-Hardware gesucht

an Hauke:
wir würden ein Ethernet oder Wifi Shield für einen Arduino benötigen (Milestone 3/4).

intuitive status message content for grap

"grap" has a percentage value that is not very intuitive to use (is 100% grapped open or close? I shouldn't have to ask this question with a well written status message)

possible values for grab: ["open", "closed" ]

While opening or closing the grapper it could send back a "unstable" instead of "open" or "closed" (for values else then 100 or 0)

typos/ inconsistent naming

IIDLCaDSEV3RMIMoveHorizontally
IIDLCaDSEV3RMIMoveVertical

• should be adverb (horizontally) or adjective (horizontal) and not both

---

ICADSRMIComsumer

• coMsumer should be coNsumer
• cAds A should be lower case like everywhere else

---

ICaDsEV3StatusListener

• cadS S should be upper case like everywhere else

---

ICaDsEV3StatusListener
ICaDSGripperFeedBack

both are Interfaces to handle status/ feedback from the gripper

• both Listener or both not Listener suffix
• both EV3 or both Gripper in prefix

---

caller.moveRight();
caller.moveLeft();
caller.moveUP();
caller.moveDown();

• moveUP() should be written with a lowercase p -> moveUp()

moveRight() should move clockwise and not counterclockwise

while using moveRight() the horizontal axis is moving counterclockwise (but to the right side of the simulation screen).

I would expect moveRight() to rotate clockwise.

same problem with moveLeft().

(Simulation, not tested on the robot)

left and right are non blocking in simulation.

The Realsystem uses blocking calls for realsystem.
The simulation works like a non blocking simulation. This is NOT correct.

Gripper von Robo 2 + 3 defekt

Der Gripper von den Robotern 2 und 3 funktioniert nicht.