travis-ci/gh

Layered GitHub API client

gh's Issues

Remove GitHub client ID and Secret from Query Strings

When using GitHub Basic Auth there is no need for the client_id or client_secret, so we should clean up the API calls to remove them from the query string

gh/lib/gh/token_check.rb

Line 21 in 27e30fd

http :head, path_for("/applications/#{client_id}/tokens/#{token}?client_id=#{client_id}&client_secret=#{client_secret}"), "Authorization" => auth_header

/cc @rkh

Not seeing versions > 0.18.0 published to rubygems

Due to the issue mentioned in the title, installing and using the travis gem on my local results in a Faraday incompatibility, where the new (and required) travis version needs 2.7 but gh 0.18.0 specifies 1.x.

New mergeable_state for pull requests

It seems that pull requests recently got a new mergeable_state which is unknown to GH:

unknown mergeable_state "unstable" for https://api.github.com/repos/.../.../pulls/1

ActiveSupport dependency

Currently released versions of gh (0.16 and 0.17) depend on ActiveSupport 5. This makes gh incompatible with any application that uses AS 6.

In my case, my application uses travis which depends on gh. Although I do not directly use gh I must either use an old version of travis that uses pre-0.16 gh which does not depend on AS at all, or I cannot use AS 6 in my application.

The old versions of travis/gh use pre-1.0 faraday dependency, thus if I want to have AS 6 and faraday 1.0 in my application I am unable to figure out how to use travis at all.

License is not specified

Hi,

There is no license specified, either in the repository or in the gem metadata. Please include this licensing information.

Thanks!

Robert

Relax constraints on faraday and faraday_middleware

Hi,

With faraday 1.1.0 and faraday_middleware 1.0.0, gh fails to build/work, only because of the ~> constraints. If it could be >= instead, that'd work great!

---

Here's a patch:

Author: Utkarsh Gupta <[email protected]>
Bug-Debian: https://bugs.debian.org/976163
Last-Update: 2020-11-30

--- a/gh.gemspec
+++ b/gh.gemspec
@@ -19,8 +19,8 @@
   s.add_development_dependency 'rspec'
   s.add_development_dependency 'webmock'
 
-  s.add_runtime_dependency 'faraday',     '~> 0.8'
-  s.add_runtime_dependency 'faraday_middleware', '~> 0.12.2'
+  s.add_runtime_dependency 'faraday',     '>= 0.8'
+  s.add_runtime_dependency 'faraday_middleware', '>= 0.12.2'
   s.add_runtime_dependency 'activesupport', '>= 5.0', '< 6.1'
   s.add_runtime_dependency 'multi_json',  '~> 1.0'
   s.add_runtime_dependency 'addressable', '~> 2.4'

update faraday to ~> 2.0 and remove faraday_middleware

We'd like to update faraday in debian to 2.0+ and gh has a stricter requirement for faraday. Please update faraday to ~> 2.0 and while at it, faraday_middleare is deprecated so will need to be replaced with specific middle ware gems instead of a single gem.

I would like to talk to Konstantin about a GH feature or change

Please release the gem

Hey there. I'm wondering if you could please cut a new release of the gem. I'd really like to get the looser addressable dependency out there. It would allow us to bring the 2.5.2 release into our environment which has some nice fixes.

Thanks,
Tim

.travis.yml: The 'sudo' tag is now deprecated in Travis CI

Travis are now recommending removing the sudo tag.

"If you currently specify sudo: false in your .travis.yml, we recommend removing that configuration"

Headers not being merged in setup method in Remote class

Something I noticed when working on this is that when the "X-GitHub-OTP" header was set, it would only send that header.

Not entirely sure if this is intended functionality so feel free to close this issue :)

net-http-persistent v3.0 failed all test on ruby 2.1- platform

net-http-persistent v3.0 requires Ruby v2.1: https://rubygems.org/gems/net-http-persistent/versions/3.0.0

which fails tests on ruby 2.0/1.9.3. E.g., https://travis-ci.org/travis-ci/gh/builds/169336691

I propose either of the following fix:

• depending on net-http-persistent v2.9 only
• requires Ruby 2.1+