Comments (4)
Thanks @andretchen0 you are completely right, I just created the PR #602
from tres.
Maybe @andretchen0 can you give me a hand with this one? The problem is here
Lines 197 to 199 in 8efe6e0
v4
I was trying to avoid needing to duplicate the code inside of createElement, but now that nodeOps
is a function, this is no longer correct.
Let me know
from tres.
Sure thing. I'll have a look!
from tres.
Hey @alvarosabu !
Fix
One approach to this would be to define the functions and then collect them into an object to return.
Concretely, right now nodeOps looks like ...
export const nodeOps: () => RendererOptions<TresObject, TresObject | null> = () => {
let scene: TresScene | null = null
// NOTE: functions are defined in the return object
return { createElement(tag, _isSVG, _anchor, props): TresObject | null {
if (!props) props = {}
if (!props.args) {
props.args = []
}
But if it's like the following, then you can call createElement( ... )
from within any function that's defined after.
export const nodeOps: () => RendererOptions<TresObject, TresObject | null> = () => {
let scene: TresScene | null = null
// NOTE: createElement, etc. are still defined within the nodeOps function, so they close over scene
const createElement(tag, _isSVG, _anchor, props): TresObject | null => { ... }
const patchProp(node, prop, prevValue, nextValue) => { ...
...
// NOTE: patchProp now closes over createElement, so you can call it like so ...
const newInstance = createElement('primitive', undefined, undefined, { ...
...
}
// NOTE: assemble the `RendererOptions` object and return it.
return {
createElement,
patchProp,
...
}
}
Question
Would you like me to submit a PR?
from tres.
Related Issues (20)
- v-for doesn't rerender color after 47 elements HOT 3
- Cookbook 🧑🍳
- glTF KTX2.0 Texture support HOT 1
- NodeOps shares `scene` across multiple`TresCanvas`s HOT 3
- Clicking on the scene cannot update model events HOT 2
- Docs `extend` example throws error HOT 2
- Typos in docs
- move codesnippets to md files HOT 3
- Use default slot props to get Canvas context HOT 14
- provide default slot props in TresCanvas HOT 1
- Using .glb suffix files causes the project to become unresponsive? HOT 1
- Tres docs' cookbook/orbit-controls code throws error
- Use window for pointerevents HOT 2
- Git pre-push hook to `lint --fix` the project HOT 9
- Move `TresObject.__tres` to a `WeakMap`
- 如何设置<TresCanvas>背景颜色为透明? HOT 1
- `useRenderLoop().onLoop` ticks before the renderer can meaningfully render HOT 2
- THREE material `defines` can't be set via Tres props
- `useRenderLoop`: render after updates HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tres.