trevorforrey/ser316labcr

ser316labcr's Issues

No banner on public methods

Description : No banner on public methods

Location(s):
AccountServerFactory.java - 12, 20
Checking.java - 12, 16, 24, 39, 58
Savings.java - 7, 11, 18, 32, 49
ServerSolution.java - 17, 71, 79, 92, 96, 107

// Has java-doc, but not correct
Account.java - 27, 34, 46, 57, 62, 72
AccountServer.java - 18, 24, 30, 35, 40, 46
Main.java - 22
MainFrame.java - 30

Defect Numbers:
7 - 38 from Jake
3, 10, 18, 23, 26, 17, 22, 25 from Trevor

Category: CG, LOW

No banner comment at top of files

Description : No banner comment at top of class

Location(s): Every file

Defect Numbers:

1 from Jake

1 from Trevor

Category: CG, LOW

No class banner comment

Description : No class banner comment

Location(s):
AccountServerFactory.java - 4
Checking.java - 3
Savings.java - 3
Account.java - 3
AccountServer.java - 6

Defect Numbers:
2 - 6 from Jake
2, 9, 16, 21 from Trevor

Category: CG, LOW

Deposit Method Always returning false

Description : Deposit Method Always returning false

Location(s):
Savings.java - 18

Defect Numbers:
5 from Lilian

Category: FD, MJ

No leading _ before private/protected variables

Description : No leading _ before private/protected variables

Location(s):
Checking.java - 6
Savings.java - 5

Defect Numbers:
40-41 from Jake
5, 12, 19, 27, 31 from Trevor

Category: CG, LOW

Accounts are not saved to the accounts.ser file

Description : Accounts are not saved to the accounts.ser file

Location(s):
ServerSolution.java - 107

Defect Numbers:
7 from Lilian

Category: FD, MJ

Literal Value Used

Description : Literal Value Used

Location(s):
Main.java - 24, 26
Checking.java - 25, 27, 40 , 42, 45, 46, 47
Savings.java - 19, 20, 21, 33, 36, 37, 39
ServerSolution.java - 13, 74

Defect Numbers:
42 - 58 from Jake
33 from Trevor

Category: CG, LOW

Does not conform to brackets style (8.a)

Description : Does not conform to brackets style (8.a)

Location(s):
Checking.java - 56
Savings.java - 47
MainFrame.java - 42, 115, 138, 150, 164, 177
ServerSolution.java - 34, 37, 41, 57, 60, 65, 116, 119, 123

Defect Numbers:
68 - 71 from Jake
8, 15, 30, 35 from Trevor

Category: CG, LOW

Empty/null inputs throw exception in the background

Description : Empty/null inputs throw exception in the background

Location(s):
ServerSolution.java - 107

Defect Numbers:
11 from Lilian

Category: FD, MJ

Not Following Class Structure Standards

Description : Not Following Class Structure Standards

Location(s):
Savings.java
ServerSolution.java
Checking.java
Account.java
AccountServerFactory.java
MainFrame.java

Defect Numbers:
59, 60 from Jake
6, 13, 20, 24, 29, 34 from Trevor

Category: CG, LOW

Single-Lined Conditionals

Description : Single-Lined Conditionals

Location(s):
Checking.java - 45
Savings.java - 36
ServerSolution - 30

Defect Numbers:
61 - 63 from Jake
7, 13, 36 from Trevor

Category: CG, LOW