truecar/graphql-decorate

Easily decorate graphql-ruby types with a flexible API

graphql-decorate's Issues

Block merge unless YARD documentation is at 100% completion.

Add a note in the documentation about a connection class needing to respond to `map`.

Fix delegation on connections

Delegation to connections wrapped with GraphQL::Decorate::Connection is not working at the moment.

Fix decoration being applied before connection pagination.

Decoration seems to happen before any pagination from the built in connections. This results in more objects being processed than are actually returned. The most likely cause is adding the decoration extension before all other extensions by pushing it to the beginning of the list.

Refactor spec_helper classes into multiple files.

GraphQL 2.0 compatible but dependencies too restrictive to use

I think with the last few commits this is now graphql ruby 2 compatible but the gemspec still restricts it to < 2. Can we lift that restriction now?

Add rubocop

Some autoloading strategies can leave type classes without desired decorator attributes

When a type implements an interface that eventually connects back to the same type in the graph, the type class given to the field may not contain the proper decorator attributes as that class has not been fully initialized. This was observed in a Rails 6 app with zeitwerk. In production environments where everything is loaded upfront this is not an issue.

A workaround for now is to specify the types for fields as strings instead of the class itself. field :rectangle, Rectangle vs field :rectangle, 'Rectangle'. You can also just ensure that the decorate_with and decorator_metadata methods are defined first in your type files.

Broken in graphql-ruby 1.13+

Legacy .to_graphqlobjects are deprecated and will be removed in GraphQL-Ruby 2.0. Remove.to_graphql to use a class-based definition instead.

This gem no longer works :(