feat: validate raw path params

[EinfachHans]

feat: validate raw path params

[Romakita]

First: I hope i don't annoy you with all of my tickets. If that is the case, let me know^^

No. Your issues are clear and highlight some problems and real bug. It help me a lot ;)

ok so if I understand you want to change the useValidation to true by default ? ha no you want option to configure the RawPathParams. Ok, it should be not a problem ;)

[Romakita]

The problem described in the doc required that the validation is disabled, because in this case, the validator will take the PersonModel as schema validation. It's completely wrong, because, the input is an ID.

I realize my example is probably not complete to reflect a real valid usecase. The correct custom decorator implementation should be that:

import {string} from "@tsed/schema";

export function UsePersonParam(expression: string): ParameterDecorator {
  
  return useDecorators(
     RawPathParams({expression, useValidation: true, useType: String}), 
     Schema(string().required().pattern("some pattern")), 
     UsePipe(PersonPipe)
  );
}

But it's not the problem of your issue here ;)

[Romakita]

PR ready #2517

[EinfachHans]

Hey @Romakita,

with your explanation i managed to create a decorator by:

return PathParams({
  expression,
  useType: Number
}

i was not 100% aware of the useType - but i think your pr makes sense anyway?

[Romakita]

The useType is here to override the original type set on the parameter. By default Ts.ED use the metadata stored by Typescript to generate the schema validation. But in this case, the type set on parameters is the final result expected by the dev, but the type that should be used as model validation for ajv ;). So it's really important to override it (for ajv and swagger doc).

[EinfachHans]

Awesome, useType: Number works like a charm for me here 👍🏼

[github-actions]

🎉 Are you happy?

If you appreciated the support, know that it is free and is carried out on personal time ;)

A support, even a little bit makes a difference for me and continues to bring you answers!

[Romakita]

🎉 This issue has been resolved in version 7.44.0 🎉

The release is available on:

• v7.44.0
• GitHub release

Your semantic-release bot 📦🚀