tshelburne/csci-e39

csci-e39's Issues

Edge case: docker clean

If youmake stop and then run make all , docker errors and asks for an argument (can't stop if already stopped)

Fix char limit on messages in chat

Docker for Windows only works for Windows 10

Under that, they suggest downloading docker toolbox - consider options that will work purely via online

Windows isn't passing ENV vars properly

Conversation below from Slack.

Ashley Davis [12:59 AM]
Hi Tim, some updates on this. I had to make some changes to package.json to account for Windows command line issues, and now the app does build using purely npm. I'm still getting "Unexpected failure - please try again" once I go to the URL, though.

I may just install a linux VM or something and run the project that way.

Tim [2:04 PM]
Have you migrated? If you look at the logging, you might see "missing students table" or something like that

Ashley Davis [9:41 PM]
Hi Tim, it's working....sort of. This was the issue: w3tecch/express-typescript-boilerplate#7 Once I edited package.json to include the fix, it was finally able to migrate properly and create/seed the dev.sqlite3 database.
GitHub
Windows - broken setup/serve scripts · Issue #7 · w3tecch/express-typescript-boilerplate
Some scripts from the package.json do not work correctly on windows machines. for example, when I run npm run setup there is an error when executing knex: C:\path\to\project\node_modules.bin\knex:...
The new issue is that I get "Student ID does not exist". I'm guessing because in the console log, this is showing "GET http://localhost:35729/livereload.js?snipver=1 net::ERR_CONNECTION_REFUSED" and on a refresh, this: polling-xhr.js?9d7b:264 GET http://localhost:3000/socket.io/?studentId=undefined&EIO=3&transport=polling&t=MAyf6Gt net::ERR_CONNECTION_REFUSED

Tim [9:45 PM]
Is the .id file there with your id?

Ashley Davis [9:46 PM]
It is there. Also, here is the dump of the students table:
CREATE TABLE IF NOT EXISTS "students" ("id" integer not null primary key autoincrement, "unique_id" varchar(255) not null, "name" varchar(255) not null, "created_at" datetime not null default CURRENT_TIMESTAMP, "updated_at" datetime not null default CURRENT_TIMESTAMP, "confirmed_at" datetime null);
INSERT INTO students VALUES(1,'71126498','Test Student','2018-04-13 01:02:23','2018-04-13 01:02:23',NULL);

Tim [9:46 PM]
Harrumph

Ashley Davis [11:29 PM]
Hi Tim, the issue is that for some reason src/config.js is not grabbing any of the actual environment variables or perhaps Windows isn't setting them correctly. It isn't an issue for the port, backend, etc because they have alternatives if they're not found, but studentId does not. If I hardcode the studentId value in config.js or set it in the terminal before running start, then it loads correctly. Let me know if you have any ideas how to fix this.

💬 Better error messages for makefile

Common error could use the following error message:

"Your database isn't set up - run make migrate"

Using with "volumes" does not work

per Muhammad Abdurrahman (Monday Jan 22 at 1:40pm) in canvas.harvard.edu

Appreciate the step by step directions which were easy to follow. Initially I was a bit stuck trying to install Docker in a different volume (I wonder if anyone has resolved this already):

docker: Error response from daemon: Mounts denied: 
The paths /volumes/scratch/csci-39-master/... and /volumes/scratch/csci-39-master/...
are not shared from OS X and are not known to Docker.
You can configure shared paths from Docker -> Preferences... -> File Sharing.

package.json has bug

"build.server": "mkdir -p build && babel -d ./build ./src -s",

leaves a -p directory and messes up the build.

Thanks for fixing!
Judy

`make stop` isn't actually killing some make processes

Below, note that make live and make run appear to still be running (multiple instances). I would have expected these to die when make stop is run.

tshelburne@Tims-MacBook-Pro: ~/Projects/csci-e39 (master) [!]
$ make stop
docker stop e06b5d0605e2 || true
ps -ahle06b5d0605e2

tshelburne@Tims-MacBook-Pro: ~/Projects/csci-e39 (master) [!]
$ ps -ahl
  UID   PID  PPID        F CPU PRI NI       SZ    RSS WCHAN     S             ADDR TTY           TIME CMD
  501 28050 28048     4006   0  31  0  4307464  14252 -      Ss                  0 ttys000    0:00.03 /Applications/iTerm.app/Contents/MacOS/iTerm2 --server bash
  501 28051 28050     4006   0  31  0  4297772   6196 -      S                   0 ttys000    0:00.46 bash
  501 28532 28051     4006   0  31  0  4277096   1256 -      T                   0 ttys000    0:00.01 /Library/Developer/CommandLineTools/usr/bin/make live
  501 28545 28532     4006   0  31  0  4295528   1288 -      T                   0 ttys000    0:00.02 /Library/Developer/CommandLineTools/usr/bin/make run args=--expose 3000 -p 3000:3000 --expose 35729 -p 35729:35729 -e BACKEND=csci-e39.herokuapp.com
  501 28558 28545     6006   0   0  0        0      0 -      Z                   0 ttys000    0:00.00 (docker)
  501 29127 28051     4006   0  31  0  4286312   1288 -      T                   0 ttys000    0:00.01 /Library/Developer/CommandLineTools/usr/bin/make live
  501 29140 29127     4006   0  31  0  4295528   1312 -      T                   0 ttys000    0:00.02 /Library/Developer/CommandLineTools/usr/bin/make run args=--expose 3000 -p 3000:3000 --expose 35729 -p 35729:35729 -e BACKEND=csci-e39.herokuapp.com
  501 29153 29140     6006   0   0  0        0      0 -      Z                   0 ttys000    0:00.00 (docker)
    0 29253 28051     4106   0  31  0  4268180   1240 -      R+                  0 ttys000    0:00.00 ps -ahl
  501 28563 28048     4006   0  31  0  4308488  14264 -      Ss                  0 ttys002    0:00.03 /Applications/iTerm.app/Contents/MacOS/iTerm2 --server bash
  501 28564 28563     4006   0  31  0  4298796   6504 -      S+                  0 ttys002    0:00.21 bash

`make live` needs a message saying it is up and running

DB maxes out at 20 connections

I have reached out to Heroku, awaiting response.

Syntax errors kill watch process

Description

Curtis Wilcox [11:23 AM]
Say I cause an error like this:

[0] ERROR in ./src/assignments/project-1/components/pendingfiles.jsx.js
[0] Module build failed: SyntaxError: Adjacent JSX elements must be wrapped in an enclosing tag > (7:1)

the last line of output from make watch is [0] npm run watch.js exited with code 1
Once that has happened, it seems to no longer be watching, no changes to my code cause it to do anything

Full Error

[0] ERROR in ./src/assignments/project-1/components/pendingfiles.jsx.js
[0] Module build failed: SyntaxError: Adjacent JSX elements must be wrapped in an enclosing tag (7:1)
[0] 
[0]    5 | 
[0]    6 |  <h2>In Progress</h2>
[0] >  7 |   <ul {...props}>
[0]      |  ^
[0]    8 |      {myFiles.map(file => {
[0]    9 |          const {id, name, progress} = file
[0]   10 | 
[0] 
[0]  @ ./src/assignments/project-1/index.jsx.js 19:20-60
[0]  @ ./src/ui/app.jsx.js
[0]  @ ./src/client.js
[0] npm ERR! 
[0] code ELIFECYCLE
[0] npm ERR! errno 2
[0] npm ERR! [email protected] build.public.js: `webpack`
[0] npm ERR! Exit status 2
[0] npm ERR! 
[0] npm ERR! Failed at the [email protected] build.public.js script.
[0] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[0] 
[0] npm ERR! A complete log of this run can be found in:
[0] npm ERR!     /root/.npm/_logs/2018-03-29T15_23_09_508Z-debug.log
[0] [nodemon] failed to start process, possible issue with exec arguments
[0] events.js:188
[0]       throw err;
[0]       ^
[0] 
[0] Error: Unhandled "error" event. (2)
[0]     at Bus.emit (events.js:186:19)
[0]     at ChildProcess.<anonymous> (/usr/src/app/node_modules/nodemon/lib/monitor/run.js:126:11)
[0]     at emitTwo (events.js:126:13)
[0]     at ChildProcess.emit (events.js:214:7)
[0]     at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
[0] npm ERR! code ELIFECYCLE
[0] npm ERR! errno 1
[0] npm ERR! [email protected] watch.js: `nodemon --ext js,pug --watch ./src --exec 'npm run build.public.js && babel-node src/server.js'`
[0] npm ERR! Exit status 1
[0] npm ERR! 
[0] npm ERR! Failed at the [email protected] watch.js script.
[0] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[0] 
[0] npm
[0]  ERR! A complete log of this run can be found in:
[0] npm ERR!     /root/.npm/_logs/2018-03-29T15_23_09_527Z-debug.log
[0] npm run watch.js exited with code 1

✏️ Consider: "Almost done" copy

Consider updating the "almost done" copy to update when a student has completed the module 0 and pushed the button.

Support control+C to kill running tasks

For some reason, control+C won't stop our make tasks (start, live, watch).

`make stop` still has issues with dying

Sometimes it still dies before any docker containers have actually been started.

docker command not working in command substitution on windows

PS C:\Users\roberto\github\csci-e39> bash make.sh all
make.sh: linha 59: docker: comando não encontrado
make.sh: linha 59: docker: comando não encontrado
make.sh: linha 39: docker: comando não encontrado
make.sh: linha 39: docker: comando não encontrado
PS C:\Users\roberto\github\csci-e39> docker -v
Docker version 17.10.0-ce, build f4ffd25