tslagle13/smartthingspersonal

All my code made public for the STs community!

smartthingspersonal's Issues

missing commas lines 87 and 94

I think you are missing commas around lines 87 and 94 near the titles. Also I am getting an error "you are not authorized to preform the requested operation" when I try and open the app. any thoughts?

Thanks

Vacation Lighting Director invalid syntax.

In the def setup, theres a few comma's in the wrong spot and/or missing.

Example below, missing the comma before required. Thanks for all your hard work!

def frequency_minutes = [
    name:           "frequency_minutes",
    type:           "number",
    title:          "Minutes?"
    required:   true

Vacation Lighting Director is unreliable

I can't seem to get this smartapp to run for more than a day or two without quitting. I think the basic issue is that it uses runIn() to reschedule the next run every time it runs. According to the Smartthings docs this practice is not recommended because if for some reason a run does not succeed, the rescheduling for the next run does not happen and the app is essentially dead. (At least until the mode is toggled again.) I think the way to fix this is to use schedule() to run the app every day at the programmed start time. That could also fail, but the next day it will try again and likely succeed.

Maybe it's just me, but I have found the current implementation which starts the app based on a mode change to be unintuitive. When I think of a vacation lighting program, I would expect it to start in the early evening, then check to see if the mode is correct. I've found it so unintuitive that I've had to study the code closely in order to get it to work at all. For example, in the current implementation, the app won't run when first installed if you're already in the selected (let's say 'Away') mode. You have to change to a different mode, then back to 'Away' to get it to fire up and start checking the time and other parameters.

So I recommend changing the implementation to use schedule() as the primary trigger to start the app at a certain time every day, then check other states such as mode and day of the week to determine whether to switch lights on and off or not.

A workaround I came up with on a recent long vacation where I had enough time to study the issue (but no facility to program) was to use other smartthings facilities to do a mode change to 'Home' then back to 'Away' every day just before the starting time of the Director. But this is unsatisfactory because when I got home I had to remove this program and would have to reprogram it before the next vacation.