Comments (4)
Wouldn't be better to add a @Skip decorator to those tests if they don't pass yet?
Good idea! I've just updated the tests and created a new release.
from somajo.
Yes, currently these four tests fail. The reason is simply that they test something that hasn't been implemented, yet 😉. In a future version, I would like to add an option to output sentence boundaries as XML tags which is tricky if the input is already XML and you want to have well-formed XML output. I've already created some tests, but the actual functionality is not there, yet.
from somajo.
I see. I have packaged SoMaJo for Nix/NixOS. The standard Nix tooling runs unit tests and builds will fail if any of the unit tests fail (which is a good thing ;)). Wouldn't be better to add a @skip
decorator to those tests if they don't pass yet?
I guess I'll add a patch which disables these tests, since I don't want to disable tests altogether.
from somajo.
Thanks a lot!
from somajo.
Related Issues (20)
- Quotation Marks HOT 1
- Phonenumber and sad emoje HOT 1
- Tokenizer outputs single characters per line HOT 4
- Thread safety HOT 6
- Segmentation of sentences in lowercase HOT 2
- Apostrophe die Vokale ersetzen HOT 5
- How do I split sentences but not words? HOT 2
- False Positives with URLS HOT 2
- tokenize with continue multiple punctions HOT 1
- Tokenizer text recovery problem HOT 1
- Domain adaptation to law texts HOT 4
- publish on conda-forge HOT 2
- Document all possible values for `token_class`. HOT 6
- Dates at the end of sentences HOT 1
- Markdown link splitting bug. HOT 6
- Issue with Markdown style links. HOT 3
- Other issue with Markdown style links. HOT 1
- Other MD issue. HOT 2
- German text to sentence segmentation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from somajo.