Giter Site home page Giter Site logo

Failing unit test in 2.0.2 about somajo HOT 4 CLOSED

tsproisl avatar tsproisl commented on September 2, 2024
Failing unit test in 2.0.2

from somajo.

Comments (4)

tsproisl avatar tsproisl commented on September 2, 2024 1

Wouldn't be better to add a @Skip decorator to those tests if they don't pass yet?

Good idea! I've just updated the tests and created a new release.

from somajo.

tsproisl avatar tsproisl commented on September 2, 2024

Yes, currently these four tests fail. The reason is simply that they test something that hasn't been implemented, yet 😉. In a future version, I would like to add an option to output sentence boundaries as XML tags which is tricky if the input is already XML and you want to have well-formed XML output. I've already created some tests, but the actual functionality is not there, yet.

from somajo.

danieldk avatar danieldk commented on September 2, 2024

I see. I have packaged SoMaJo for Nix/NixOS. The standard Nix tooling runs unit tests and builds will fail if any of the unit tests fail (which is a good thing ;)). Wouldn't be better to add a @skip decorator to those tests if they don't pass yet?

I guess I'll add a patch which disables these tests, since I don't want to disable tests altogether.

from somajo.

danieldk avatar danieldk commented on September 2, 2024

Thanks a lot!

from somajo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.