tstriker/apx

A QIX clone

apx's Issues

Add sound FX

Oh if only someone could make sound effects for APX

font license

At Fedora, it is a difference if we have real source code or some additional content. Both need to be legalized individually.
Please provide an own license text for the font file (04b03.ttf).

Crash with Python 3.5

Reproducible with Python 3.4, too. But no issue in Python 2.

Description of problem: Crashes at launch.
Version-Release number of selected component (if applicable): apx-0.1-7.fc24
How reproducible: Start apx

Actual results:

  File "/usr/bin/apx", line 26, in <module>
    from apx.lib import graphics
  File "/usr/lib/python3.5/site-packages/apx/lib/graphics.py", line 185, in <module>
    class Graphics(object):
ValueError: 'colors' in __slots__ conflicts with class variable

Expected results: Run.

Support for setuptools

https://pythonhosted.org/setuptools/setuptools.html

Maybe something like:

cat > setup.py << EOF
#!/usr/bin/env %{__python2}
# - coding: utf-8 -
import os
from setuptools import setup
setup(
    name = "%{name}",
    version = "%{version}git%{scommit}",
    author = "Toms Bauģis",
    author_email = "toms.baugis at gmail.com",
    description = ("%{summary}"),
    license = "%{license}",
    keywords = "",
    url = "%{url}",
    packages=['%{name}', '%{name}.lib'],
    long_description=open(os.path.join(os.path.dirname(__file__), '%{readme}')).read(),
    classifiers=[
        "Development Status :: 2 - Pre-Alpha",
        "Environment :: X11 Applications :: GTK",
        "Intended Audience :: End Users/Desktop",
        "Topic :: Games/Entertainment",
        "License :: OSI Approved :: %{licence} License",
    ],
)
EOF

fonts not found

trying 722c52e, under openSUSE Leap-15

apx
Traceback (most recent call last):
  File "/home/ederag/.local/bin/apx", line 386, in <module>
    utils.install_font("04b03.ttf")
  File "/home/ederag/.local/lib/python3.6/site-packages/apx/lib/utils.py", line 11, in install_font
    shutil.copyfile(os.path.join("assets", font_filename), font_path)
  File "/usr/lib64/python3.6/shutil.py", line 120, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: 'assets/04b03.ttf'

The assets directory does not exist. Here is the relevant installation log:

python3 setup.py install --user
...
creating /home/ederag/.local/share/fonts
creating /home/ederag/.local/share/fonts/04b03
copying data/04b03.ttf -> /home/ederag/.local/share/fonts/04b03

Crash on start

Another float error on setting a timeout.

$ ./apx.py
Traceback (most recent call last):
File "/home/bryce/src/Hamster/apx/lib/graphics.py", line 1968, in do_draw
self.tweener.update(delta)
File "/home/bryce/src/Hamster/apx/lib/pytweener.py", line 105, in update
if tween.on_complete: tween.on_complete(tween.target)
File "/home/bryce/src/Hamster/apx/sprites.py", line 109, in
on_complete = lambda sprite: kill(sprite, True)
File "/home/bryce/src/Hamster/apx/sprites.py", line 88, in kill
callback(self)
File "./apx.py", line 156, in
self.board.cube.beam_out(lambda cube: self.game_over())
File "./apx.py", line 232, in game_over
self.change_speed(0.3)
File "./apx.py", line 227, in change_speed
self.pause(False)
File "./apx.py", line 254, in pause
self.start_ticking()
File "./apx.py", line 287, in start_ticking
gobject.timeout_add(1000 / (45 * self.game.speed), self._tick)
TypeError: integer argument expected, got float

Hardcoded icon path in launcher

Hi,

currently the icon path specified in the created .desktop launcher file is set to:
Icon=/usr/share/apx/icons/apx.svg

This prevents icon theming without editing the launcher file.

I'd like to ask you to change the icon location as well as the icon path line in the launcher according to the freedesktop.org standards.

Please find more info here:
http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
https://github.com/Foggalong/hardcode-fixer/wiki/What,-Why-&-How

According to the above resources standard icon locations are:

/usr/share/icons/hicolor/[size]/apps/[icon name]
~/.local/share/icons/hicolor/[size]/apps/[icon name]
or simply:
/usr/share/pixmaps/[icon name]

The corresponding standard icon line in the .desktop launcher is:
Icon=[icon name] (without full path, without file extension)

for instance
Icon=apx

(for an icon apx.svg or apx.png stored in standard location

Could you please move the icon to one of those locations and adjust the icon path in the .desktop file accordingly?

Difficult to see with some desktop themes

apx is almost invisible when using the default theme on GNOME 3.

Crash after collision

$ ./apx.py
Traceback (most recent call last):
File "/home/bryce/src/Hamster/apx/lib/graphics.py", line 1968, in do_draw
self.tweener.update(delta)
File "/home/bryce/src/Hamster/apx/lib/pytweener.py", line 105, in update
if tween.on_complete: tween.on_complete(tween.target)
File "/home/bryce/src/Hamster/apx/sprites.py", line 109, in
on_complete = lambda sprite: kill(sprite, True)
File "/home/bryce/src/Hamster/apx/sprites.py", line 88, in kill
callback(self)
File "./apx.py", line 156, in
self.board.cube.beam_out(lambda cube: self.game_over())
File "./apx.py", line 232, in game_over
self.change_speed(0.3)
File "./apx.py", line 227, in change_speed
self.pause(False)
File "./apx.py", line 254, in pause
self.start_ticking()
File "./apx.py", line 287, in start_ticking
gobject.timeout_add(1000 / (45 * self.game.speed), self._tick)
TypeError: integer argument expected, got float

A desktop file for fonts?

This showed up today in Fedora rawhide: https://github.com/hughsie/createrepo_as_logs/blob/master/a/apx.log

Is that summary correct?! If it's supposed to be for the game, please consider writing and installing an AppData file with the application description and some screenshots, else it looks really bad in the GNOME and KDE Software Centers.

See http://people.freedesktop.org/~hughsient/appdata/ for details; thanks!

Richard