tsuru / docker-cluster Goto Github PK

View Code? Open in Web Editor NEW

249.0 27.0 33.0 614 KB

Go library for clustering support on Docker.

Home Page: http://godoc.org/github.com/tsuru/docker-cluster

License: BSD 3-Clause "New" or "Revised" License

Go 99.88% Shell 0.12%

docker-cluster's Introduction

docker-cluster

Support for running Docker on multiple hosts, with autoscaling capabilities and pluggable scheduling algorithms.

For more details on the API, check the Docker remote API docs.

docker-cluster's People

Contributors

Stargazers

Watchers

docker-cluster's Issues

data race in the round robin scheduler

detected from an internal tsuru's CI:

==================
WARNING: DATA RACE
Read by goroutine 69:
  github.com/tsuru/docker-cluster/cluster.(*roundRobin).Schedule()
      /tmp/gopath/tsuru/src/github.com/tsuru/docker-cluster/cluster/scheduler.go:43 +0x21c
  github.com/tsuru/docker-cluster/cluster.(*Cluster).CreateContainerSchedulerOpts()
      /tmp/gopath/tsuru/src/github.com/tsuru/docker-cluster/cluster/container.go:35 +0x159
  github.com/tsuru/tsuru/provision/docker.(*container).create()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/docker.go:212 +0xd2f
  github.com/tsuru/tsuru/provision/docker.func·005()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/actions.go:90 +0x377
  github.com/tsuru/tsuru/action.(*Pipeline).Execute()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/action/action.go:133 +0x745
  github.com/tsuru/tsuru/provision/docker.start()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/docker.go:346 +0x4ec
  github.com/tsuru/tsuru/provision/docker.func·027()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/provisioner.go:234 +0x152

Previous write by goroutine 124:
  github.com/tsuru/docker-cluster/cluster.(*roundRobin).Schedule()
      /tmp/gopath/tsuru/src/github.com/tsuru/docker-cluster/cluster/scheduler.go:44 +0x23c
  github.com/tsuru/docker-cluster/cluster.(*Cluster).CreateContainerSchedulerOpts()
      /tmp/gopath/tsuru/src/github.com/tsuru/docker-cluster/cluster/container.go:35 +0x159
  github.com/tsuru/tsuru/provision/docker.(*container).create()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/docker.go:212 +0xd2f
  github.com/tsuru/tsuru/provision/docker.func·005()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/actions.go:90 +0x377
  github.com/tsuru/tsuru/action.(*Pipeline).Execute()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/action/action.go:133 +0x745
  github.com/tsuru/tsuru/provision/docker.start()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/docker.go:346 +0x4ec
  github.com/tsuru/tsuru/provision/docker.func·027()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/provisioner.go:234 +0x152

Goroutine 69 (running) created at:
  github.com/tsuru/tsuru/provision/docker.addContainersWithHost()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/provisioner.go:240 +0x7b4
  github.com/tsuru/tsuru/provision/docker.func·010()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/actions.go:150 +0x208
  github.com/tsuru/tsuru/provision/docker.(*S).TestProvisionAddUnitsToHostForwardWithoutHost()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/actions_test.go:386 +0x751
  runtime.call16()
      /var/lib/jenkins/go/src/pkg/runtime/asm_amd64.s:360 +0x31
  reflect.Value.Call()
      /var/lib/jenkins/go/src/pkg/reflect/value.go:411 +0xed
  launchpad.net/gocheck.func·006()
      /tmp/gopath/tsuru/src/launchpad.net/gocheck/gocheck.go:733 +0x51b
  launchpad.net/gocheck.func·004()
      /tmp/gopath/tsuru/src/launchpad.net/gocheck/gocheck.go:628 +0xf4

Goroutine 124 (running) created at:
  github.com/tsuru/tsuru/provision/docker.addContainersWithHost()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/provisioner.go:240 +0x7b4
  github.com/tsuru/tsuru/provision/docker.func·010()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/actions.go:150 +0x208
  github.com/tsuru/tsuru/provision/docker.(*S).TestProvisionAddUnitsToHostForwardWithoutHost()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/actions_test.go:386 +0x751
  runtime.call16()
      /var/lib/jenkins/go/src/pkg/runtime/asm_amd64.s:360 +0x31
  reflect.Value.Call()
      /var/lib/jenkins/go/src/pkg/reflect/value.go:411 +0xed
  launchpad.net/gocheck.func·006()
      /tmp/gopath/tsuru/src/launchpad.net/gocheck/gocheck.go:733 +0x51b
  launchpad.net/gocheck.func·004()
      /tmp/gopath/tsuru/src/launchpad.net/gocheck/gocheck.go:628 +0xf4
==================
==================
WARNING: DATA RACE
Read by goroutine 69:
  github.com/tsuru/docker-cluster/cluster.(*roundRobin).Schedule()
      /tmp/gopath/tsuru/src/github.com/tsuru/docker-cluster/cluster/scheduler.go:47 +0x270
  github.com/tsuru/docker-cluster/cluster.(*Cluster).CreateContainerSchedulerOpts()
      /tmp/gopath/tsuru/src/github.com/tsuru/docker-cluster/cluster/container.go:35 +0x159
  github.com/tsuru/tsuru/provision/docker.(*container).create()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/docker.go:212 +0xd2f
  github.com/tsuru/tsuru/provision/docker.func·005()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/actions.go:90 +0x377
  github.com/tsuru/tsuru/action.(*Pipeline).Execute()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/action/action.go:133 +0x745
  github.com/tsuru/tsuru/provision/docker.start()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/docker.go:346 +0x4ec
  github.com/tsuru/tsuru/provision/docker.func·027()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/provisioner.go:234 +0x152

Previous write by goroutine 124:
  github.com/tsuru/docker-cluster/cluster.(*roundRobin).Schedule()
      /tmp/gopath/tsuru/src/github.com/tsuru/docker-cluster/cluster/scheduler.go:45 +0x258
  github.com/tsuru/docker-cluster/cluster.(*Cluster).CreateContainerSchedulerOpts()
      /tmp/gopath/tsuru/src/github.com/tsuru/docker-cluster/cluster/container.go:35 +0x159
  github.com/tsuru/tsuru/provision/docker.(*container).create()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/docker.go:212 +0xd2f
  github.com/tsuru/tsuru/provision/docker.func·005()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/actions.go:90 +0x377
  github.com/tsuru/tsuru/action.(*Pipeline).Execute()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/action/action.go:133 +0x745
  github.com/tsuru/tsuru/provision/docker.start()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/docker.go:346 +0x4ec
  github.com/tsuru/tsuru/provision/docker.func·027()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/provisioner.go:234 +0x152

Goroutine 69 (running) created at:
  github.com/tsuru/tsuru/provision/docker.addContainersWithHost()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/provisioner.go:240 +0x7b4
  github.com/tsuru/tsuru/provision/docker.func·010()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/actions.go:150 +0x208
  github.com/tsuru/tsuru/provision/docker.(*S).TestProvisionAddUnitsToHostForwardWithoutHost()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/actions_test.go:386 +0x751
  runtime.call16()
      /var/lib/jenkins/go/src/pkg/runtime/asm_amd64.s:360 +0x31
  reflect.Value.Call()
      /var/lib/jenkins/go/src/pkg/reflect/value.go:411 +0xed
  launchpad.net/gocheck.func·006()
      /tmp/gopath/tsuru/src/launchpad.net/gocheck/gocheck.go:733 +0x51b
  launchpad.net/gocheck.func·004()
      /tmp/gopath/tsuru/src/launchpad.net/gocheck/gocheck.go:628 +0xf4

Goroutine 124 (running) created at:
  github.com/tsuru/tsuru/provision/docker.addContainersWithHost()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/provisioner.go:240 +0x7b4
  github.com/tsuru/tsuru/provision/docker.func·010()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/actions.go:150 +0x208
  github.com/tsuru/tsuru/provision/docker.(*S).TestProvisionAddUnitsToHostForwardWithoutHost()
      /tmp/gopath/tsuru/src/github.com/tsuru/tsuru/provision/docker/actions_test.go:386 +0x751
  runtime.call16()
      /var/lib/jenkins/go/src/pkg/runtime/asm_amd64.s:360 +0x31
  reflect.Value.Call()
      /var/lib/jenkins/go/src/pkg/reflect/value.go:411 +0xed
  launchpad.net/gocheck.func·006()
      /tmp/gopath/tsuru/src/launchpad.net/gocheck/gocheck.go:733 +0x51b
  launchpad.net/gocheck.func·004()
      /tmp/gopath/tsuru/src/launchpad.net/gocheck/gocheck.go:628 +0xf4
==================

cluster: next() panics with the message "integer divide by zero" when cluster has no nodes

We can keep the panic, but use a custom error message,

cluster/images: ImportImage should store image on cluster storage

When removing a node from the cluster it should remove it from the image host list

image push

links to docker api are broken

The shortened urls are like that:
http://docs.docker.io/en/latest/api/docker_remote_api/#list-containers
But the anchor stopped working, now the url must have the api version
e.g: http://docs.docker.io/en/latest/api/docker_remote_api_v1.4/#list-containers

Automatically handle errors on nodes and quarantine nodes

Automatically handle errors on nodes. When an error happen it should try another node and move the node to some kind of quarantine zone.
The cluster should try to use nodes on quarantine for some time. After a number of errors a recovery process should be started, possibly spawning a new node and moving containers from one node to another.
The recovery process should be handled by the client implementing some kind of Recovery interface provided by the Cluster

cluster: support container export

container attach

Example Usage

I see that this project implements two libraries but no daemons or command line tools. Are there any examples of this in use?

storage image list should not add a host more than one time by image

image remove

cluster/containers: ExportContainer does not work with storage disabled

Image commit should remove all hosts from storage image list

Move segregated scheduler main logic from tsuru/tsuru

Related to tsuru/tsuru#848

support container commit

cluster/scheduler: Registrable interface should have Unregister function

add daemon implementing the Docker API

docker-cluster should have a daemon, that implements the Docker API, so we will be able to use the docker client to manage Docker clusters, and even use a Docker cluster as a node in another cluster.

storage: RetrieveNodes should not return a map

Returning a map breaks round robin. We need to return a slice.

image pull

Allow metadata associated to each node and filtering by metadata

Related to tsuru/tsuru#848

cluster: add Scheduler

Scheduler will be an interface representing the scheduling strategy used by a cluster. It will be immutable in the cluster. The interface would look like this:

type Scheduler interface {
    Schedule(config *docker.Config) (string, *docker.Container, error)
    Register(nodes ...Node) error
}

Then the function New would receive the scheduler instance, using a default implementation (round robin strategy).

cluster: add Storage

Storage will be an interface that will store information about containers. This is how the interface may look like

type Storage interface {
    Store(containerID, hostID string) error
    Retrieve(containerID string) (hostID string, err error)
}

A naive implementation using maps would look like this (untested):

type MapStorage struct {
    m     map[string]string
    mutex sync.Mutex
}

func (s *MapStorage) Store(containerID, hostID string) error {
    s.mutex.Lock()
    s.m[containerID] = hostID
    s.mutex.Unlock()
    return nil
}

func (s *MapStorage) Retrieve(containerID string) (string, error) {
    s.mutex.Lock()
    defer s.mutex.Unlock()
    host, ok := s.m[containerID]
    if !ok {
        return "", errors.New("No such container")
    }
    return host, nil
}

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.